richardtallent / vue-object-merge Goto Github PK

Hi Richard,
This commit in 0.1.6 breaks IE11 compatibility. Works fine still against 0.1.5.

Hi! Thanks for the few lines.
Just wanted to mention an odd behavior I can't explain.
When I import the stateMerge function in my Vuex actions file, reactivity doesn't work.
When I copy-paste the function directly in my file instead of importing, reactivity is preserved.
I don't know how that's possible though. My only clue maybe, it could be Vuex black magic that prevents access to the state from outside its actions.

This seems to be throwing Cannot read property 'hasOwnProperty' of null:

stateMerge({ p: null }, { p: { t: {} } });

I noticed that I had a computed watching an object property that doesn't necessarily exist at first, like

computed: {
  thing () {
    if (someObject.archived) {
      ...
    }
  }
}

Even if the object itself is reactive, adding the archived property afterwards won't trigger reactivity. You either have to

• set the archived property from the beginning (to false for example)
• replace the object itself, and not add the property to it

It's reactivity 101, but I had not anticipated this before I noticed the issue.
Thank you