ricardoccpaiva / opentelemetry_tesla Goto Github PK

There is a new (important) release of opentelemetry, we should update.

Not sure, but probably the only change is :otel_propagator.text_map_inject/1 -> :otel_propagator_text_map.inject/1.

Nice to see this getting started! I poked around the code and noticed there's a lot of deviation from the required semantic conventions for http. It's important to adhere to the spec as much as possible and not add any extra attributes than what are outlined. If the user wants to add more, they should probably be advised to do so through additional custom middleware.

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/http.md

Feel free to drop any questions or ask for reviews in the opentelemetry channel on the Elixir slack!

I forget if we discussed this on Slack and since there is no history I'm just opening this here.

Are you able to submit this app to https://github.com/open-telemetry/opentelemetry-erlang-contrib

The latest release has this code snippet:

        {:error, _} = e ->
          e |> IO.inspect(label: "------>")
          IO.puts("---------> HAAAAAAAAAAA")
          # TODO: update span's status to with appropriate error code and message
          e

The code on the master branch doesn't seem to have it so probably something got messed up when the package was published. Could you please do a re-release?