ricalo / jekylldocker Goto Github PK

See if we I can integrate LiveReload with Hawkins in the image.

At this moment, the default command executes the following:

jekyll liveserve --config _config.yml,_config_dev.yml

This assumes that the site has the following:

• Hawkins plugin for Jekyll
• _config_dev.yml file

That might not be the case, and the container shouldn't force developers to include these dependencies.

HtmlProofer is taking too long on some sites. I could just serve the site and then start running the tests so developers don't have to wait to start working.

HtmlProofer fails with an HTTP error 999 when checking LinkedIn URLs.

*  External link https://www.linkedin.com/in/... failed: 999 No error

HtmlProofer should ignore such errors.

Check the site with html-proofer before serving it.
I need to add the gem to the image at build time, so adding the following line to Dockerfile

RUN gem install html-proofer

The default command should do the following:

• Install dependencies bundle install
• Build the site jekyll build
• Test with html-proofer htmlproofer ./_site
• Serve the site jekyll serve --config _config.yml,_config_dev.yml

So I need to add instructions to build the site and test with html-proofer.

The container runs HtmlProofer when started. However, if there are HTML errors, the container doesn't start.

This is not right.

We also should remove the --url-ignore "/feed.xml" flag.

It should report the errors and start the container, if possible.

It doesn't look like a good design to have Jekyll and other gems installed at image build time. Instead, I should assume that developers specify their own dependencies in their Gemfiles.

This has been especially problematic with Jekyll plugins.

Can we attach our tests to the watch pipeline in jekyll serve?

Ignore SampleSite and other irrelevant files

I'm creating an image tag just to append --force_polling to make the image work on Windows. Maybe I can get rid of that extra tag if I use an ENTRYPOINT instead of a CMD.

The script assumes that some Gems are already installed. We should make sure that those Gems are already installed at image build time with RUN statements in Dockerfile. So far we need:

• Jekyll
• HtmlProofer

Jekyll plugins should not (and can't) be installed at image build time.

This is in conflict with #10.