riban-bw / fluidbox Goto Github PK

Is it possible to use Pirate audio hat with drivers for ST7789 displays ?

Update is performed via USB, offered automatically on startup so the "Update" option in the "Edit" menu can be removed.

Selecting a drum kit (different bank) does not select the drums but instead plays the piano (bank 1).

• Adjust an effect parameter, e.g. Reverb room size.
• Press UP button
• Press DOWN Button
• Observe first press of DOWN button increases value
  Subsequent presses act as expected.
  Similar behaviour for UP button.

The word "preset" is used to describe a set of parameters; soundfont, programs, levels, etc. This is used consistently throughout the code and documentation. It conflicts with Fluidsynth's use of the word which is equivalent to a MIDI program. Also it isn't necessarily intuitive for a user.
I suggest using an alternating word, at least in documentation, maybe "scene" or "snapshot".

• Navigate to Program Edit menu
• Press Left button several times to return to Performance page
• After a couple of seconds the Power menu is displayed.

The preset edit name screen allows each character of the preset's name to be altered but extra characters may not be added.

There is a dependency on logo.bmp being available. What happens if this is missing?

Select an effect parameter to adjust and increase its value to maximum.
The value display (triangle) increases in size beyond the bounds of the screen, corrupting the title bar.

• Select a preset
• Navigate to Mixer page
• Adjust some channel levels
• Save preset
• Select another preset
• Select the previously save preset
  Expected behaviour: Previously adjusted mixer levels are restored.
  Actual behaviour: Mixer levels are reset.

Each preset is prefixed with '*' if it is modified but there is no indication if a preset has been deleted or if all modified presets are scrolled off screen.

Maybe add '*' prefix to performance menu title.

Startup fluidbox.
Preset list is shown with the first preset highlighted eve if another has been loaded due to persistent storage.

Do you know how to connect several buttons and an lcd screen to gpios in rapsberry pi?

The effects parameter adjustment page shows the current value to 6 decimal places! Should be fewer.

The update mechanism checks USB attached storage for files from which to update. With FAT file systems (and possibly others) it detects files with uppercase characters in the filename but attempts to copy files with lowercase character filenames only.

• Create a preset
• Assign different programs to each channel
• Save config
• Reload config
  Expected behaviour: Preset's programs are restored.
  Actual behaviour: Preset's first program is set to the last changed program. All others are program 0.

The manager app acts as a bootloader and must be resilient. Need to test for vulnerabilities.

Maybe worth wrapping functions in try / catch exception handling.

Both header and selection bar are blue. Should be different.

• Select Preset Program page
• Observe list of channels with associated instruments.
• Send MIDI Program Change with a program that is not available in soundfont
• Channel disappears from list
• Send MIDI Program Change with a program that is available in soundfont
• Channel reappears in list

It would be advantageous to have similar indication of MIDI input on the Mixer page as is seen on the program select page.

Navigate to the effects screen - Reverb shows as disabled and Chorus shows as enabled.
These should be the actual enable state of each effect.

• Navigate to "Manage soundfonts -> Delete soundfont" screen
• Select a soundfont to delete
• Press either Yes or No
• Press BACK / CANCEL / LEFT button
  Expected behaviour: Navigates to "Manage soundfonts" screen.
  Actual behaviour: Shows "CONFIRM DELETE" screen.

It would be advantageous to be able to backup the configuration (presets, etc.) to and restore from USB storage.

• Select a soundfont and selection of programs for each channel
• Select a different soundfont for the preset
  Expected behaviour: Program names correspond to the selected program sound.
  Actual behaviour: Program names are updated but previously selected instruments sound.

Show "Preset Program" list.
Play some MIDI.
Activity appears on channel + 1.

• Select a preset and navigate to the "Delete preset" menu option.
• Press enter button
  Expected behaviour: Confirmation screen displayed allowing confirmation or cancel of request.
  Actual behaviour: Preset is deleted immediately.

In performance screen, select first preset.
Delete preset.
Highlight is removed from Performance Screen and navigation is not possible.

• Navigate to "Edit Preset - >Program"
• Select a channel
  Expected behaviour: Program list shows with currently selected program highlighted.
  Actual behaviour: Program list shows with last selected program highlighted.

After making changes to presets there is an indication that the config is dirty and requires saving. A user may wish to undo such changes and revert to the previous state. This can currently be done by rebooting the device without saving.
It would be advantageous to allow resetting to saved configuration without rebooting.

The selection sometimes turns green and header sometimes has red line when pressing up / down button in list. This may happen after changing screen, e.g. create new preset then cursor through list.

• Press and hold a button, e.g. left / back.
• Expected hold action occurs
• Back action occurs

Only expect hold action to occur.

• Select sound / instrument with long sustain
• Send MIDI note on
• Press and hold RIGHT / ENTER / SELECT button

Expected behaviour: Sound silences (panic function).
Actual behaviour: Sound continues.

Edit the name of a preset does not show in the preset list.

Apply power to Raspberry Pi - screen remains blank with no backlight.

• Navigate to "Edit-> Edit preset ->Program"
• Step down through list of available programs
  Expected behaviour: Sound changes as each is highlighted
  Actual behaviour: Sound changes after selection of an entry

• Edit preset name
• The currently selected character in the name is not indicated / highlighted

Enabling reverb or chorus has no effect on the sound.

It would be advantageous to be able to control the overall volume of the fluidbox.

• Select mixer page
• Send MIDI volume change on channel 5
• Observe that channel 5 is displayed as selected
• Press UP / DOWN button
• Observe that channel 1 is actually selected

• Select a preset which has a large soundfont
• Press up / down to select another preset
• Unresponsive interface until soundfont is loaded

We could add a progress indication to show system is busy.

• Navigate to Effects
• Select an effect parameter to adjust
• Adjustment page shows but is blank
• Should show current parameter value

It may be advantageous at startup to show the page that was showing when fluidbox closed.
This may not be desirable behaviour for everyone so it could be configurable.

• Select a preset
• Navigate to "Edit preset -> Soundfont"
  Expected behaviour: Preset's current soundfont is highlighted.
  Actual behaviour: Last highlighted soundfont in list is highlighted.

When changing program via MIDI program change, some of the previous name may be left behind. It looks like the bottom row of pixels is not being cleared from the screen.

Attempt to select space for a character in a preset's name results in an underscore being used.

There is a version / release number in the title bar which is static. This should be elsewhere and is not updating.

During reboot a screen is briefly displayed saying "Rebooting". The text is left justified - should be centred and the screen is too bright red.

Similar issue for Power off.

Open the mixer page - channel 16 is shown as selected but channel 1 is actually selected.

• Select a list, e.g. Preset Program
• Press and hold down button
• Highlight only moves down one but should continue to move down