riatelab / spatialposition Goto Github PK

The vignette is fantastic!

Question: Do you have a version based on mapsf? As I'm new to this I wanted to learn straight from the successor to cartography.

Minor comment: GDP is an income concept, not a wealth concept. So the title should be "Income Inequality in Europe" or more precisely "GDP per capita Inequality in Europe". European wealth is in fact much higher. See Piketty and Zucman on this.

see commit 3c9e4c8 and spatsmooth function on parallel branch.
please review @hcommenges

id problems with sp data

The default parameter for the typefct argument is said to be pareto in the doc but is actually "exponential" in the function...

Please import st_make_valid from sf rather than from lwgeom, because upcoming lwgeom will cause CRAN errors of this kind:

* installing *source* package ‘SpatialPosition’ ...
** package ‘SpatialPosition’ successfully unpacked and MD5 sums checked
** using staged installation
** R
** data
*** moving datasets to lazyload DB
** inst
** byte-compile and prepare package for lazy loading
Error: object ‘st_make_valid’ is not exported by 'namespace:lwgeom'
Execution halted
ERROR: lazy loading failed for package ‘SpatialPosition’
* removing ‘/tmp/SpatialPosition.Rcheck/SpatialPosition’

Please fix and resubmit to CRAN

Functions such as stewart which relies on CreateDistMatrix should probably be able to pass a bypassctrl argument to the CreateDistMatrix function, so that they can be used in non-interactive settings.
I'll try to come up with a PR.

D'abord un grand merci pour ce package.

En testant l'exemple présent dans la vignette "Drawing global accessiblity to public hospitals"
j'ai un très léger décalage entre le masque et les polygones qui se visualise par du blanc.

Sur mon jeu de données, cela semble plus important

For stewart when knownpts ou unknownpts are very large

internals?

The message for to big matrices in the CreateDistMatrix ask "Do you really want to compute potentials"
This is not potentials but distance matrices!

stewart: if SpatialPolygonsDataFrame as input => use centroids
span: span in map units
plotStewart: Error in cut.default(as.vector(x), breaks, include.lowest = TRUE) :
'breaks' are not unique