revolution-messaging / mobilize-php Goto Github PK

Right now, the library assumes that request and response models are the same, which leads to server errors once it hits Mobilize. Example: when PUTting a request to the server for a list, noOfSubscribers should not be included because it can't be changed directly.

I'll likely handle this at he same time that I take care of mandatory/optional properties.

Page.php:47-48 needs to change

You might consider using the "magic methods" for this class if this is going to be a php5+ class.

http://php.net/manual/en/language.oop5.magic.php

...it'll make the class more succinct. Though, you will then have to make the documentation, itself, more robust to account for the loss in readability in the code itself.

This is a common enough function that I want to include it in the library; it's also something that scripts in production rely on. If we're going to make improvements on master, we should be careful that they don't invalidate anything clients rely on.

Anyway, probably the right thing to do here is to provide a method that will return mobileText with keywordName removed, which I'm going to go and do, and then try to find anything that uses the other way and update.