Gracefuly failing when adblock prevents the JS file from being loaded? about angular-google-analytics HOT 7 CLOSED

good to know, thanks. maybe obfuscating the gg tracker could help.
you have adblock+firefox ?

from angular-google-analytics.

I did not but when users reported the error, I reproduced it and the bug is indeed there, same with adblock on Safari.

Not sure whether obfuscating will work in the long term... I'd rather have some way to gracefully fail and keep running the app without analytics.

from angular-google-analytics.

yep i have to check what really happens installing it. thanks for reporting

from angular-google-analytics.

after tested on firefox with adblock plus and an app using the script, cant reproduce the problem.

• which adblock do you use ?
• any sample failing url ?

Thx,

Ju

from angular-google-analytics.

Have you enabled "EasyPrivacy" ? I believe that's what's causing the issue
on my end.

On Sun, Aug 4, 2013 at 1:07 AM, Julien Bouquillon
[email protected]:

after tested on firefox with adblock plus and an app using the script,
cant reproduce the problem.

• which adblock do you use ?
• any sample failing url ?

Thx,

Ju

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/5#issuecomment-22063667
.

from angular-google-analytics.

using adblock+firefox the "EasyPrivacy" - Filterlist seems to cause the problem for me as well. There is a filter rule for "-google-analytics." (which conflicts with the filename of "angular-google-analytics.js")

So: If you don't concatenate/minify your scripts, angular will fail with an error as described, because loading of the .js is blocked. After concetenating (or renaming the .js) everything works fine.

from angular-google-analytics.

EasyPrivacy is described as "an optional supplementary subscription that completely removes all forms of tracking from the internet"... which indicates that anyone using it does not want his or her actions to be tracked.

If individual developers want to concatenate and minify to work around that block, then they're doing it right. If not, I'm inclined to respect EasyPrivacy's intent in blocking our file.

I'll add a comment in the ReadMe to make it clear that AdBlock's EasyPrivacy module will block our filename and suggest that users either rename it or concatenate/minify.

from angular-google-analytics.