Git Product home page Git Product logo

Comments (7)

Sparksx avatar Sparksx commented on August 16, 2024 1

@revolunet No! You need to fix it in your code

AnalyticsProvider.setPageEvent('$stateChangeSuccess'); is now deprecated in angular-ui-router and need to be replaced in your code

from angular-google-analytics.

Sparksx avatar Sparksx commented on August 16, 2024

Hi,

This is due to ui-router update, check this: https://ui-router.github.io/ng1/docs/latest/modules/ng1_state_events.html

from angular-google-analytics.

codalprashant avatar codalprashant commented on August 16, 2024

I managed it using AnalyticsProvider.setPageEvent('$stateChangeStart') in config and

$rootScope.$on('$stateChangeStart',  
      function(event, toState) { 
        Analytics.trackPage($location.absUrl());
}); 

in run section.

from angular-google-analytics.

revolunet avatar revolunet commented on August 16, 2024

Can we close this issue ?

from angular-google-analytics.

BriceN avatar BriceN commented on August 16, 2024

@revolunet @Sparksx I agree that this should be fixed in the library, and not with a workaround.

from angular-google-analytics.

revolunet avatar revolunet commented on August 16, 2024

so someone should issue a pull request please, i dont use angular anymore sorry

@justinsa is now the main contributor

from angular-google-analytics.

justinsa avatar justinsa commented on August 16, 2024

My opinion is that the library should stop having an opinion on the route provider used and let the implementer handle that decision. We could then provide a Cookbook as part of the Wiki or the README to explain how to configure different route providers for auto-page tracking or this setPageEvent issue. This library should do Google Analytics the best it can and not need updating due to ng-router or ui-router changes.

If someone wants to issue a PR to fix this issue, great, if not, I will likely make a major version change to alleviate this possibility from being able to happen.

from angular-google-analytics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.