Validate mode - should perform formatting about formatter-maven-plugin HOT 6 CLOSED

Validate is meant for CI server.... so it will tell you it is broken.

If you change to format, CI will always tell you the code is fine, even if all classes are single liners =/

So, it should be validate only.

from formatter-maven-plugin.

maybe so but that prevents local builds. It would make more sense I think to have local as format and change it in travis ci so it validates there. Otherwise, how would I be expected to even run formatting locally?

from formatter-maven-plugin.

not really, if the format is correct it does build locally just fine....

if your local code is not formatted, you need either format on eclipse or use mvn formatter:format

from formatter-maven-plugin.

That's not the behavior I'm after. Enforce that on travis. Otherwise it's an unnecessary step fir developers.

Sent by Outlook for Android

On Tue, Sep 8, 2015 at 11:31 PM -0700, "Marvin Froeder" [email protected] wrote:
not really, if the format is correct it does build locally just fine....

if your local code is not formatted, you need either format on eclipse or use mvn formatter:format

Reply to this email directly or view it on GitHub:
#69 (comment)

from formatter-maven-plugin.

You could have a profile then

On Wed, 9 Sep 2015 22:55 Jeremy Landis [email protected] wrote:

That's not the behavior I'm after. Enforce that on travis. Otherwise it's
an unnecessary step fir developers.

Sent by Outlook for Android

On Tue, Sep 8, 2015 at 11:31 PM -0700, "Marvin Froeder" <
[email protected]> wrote:
not really, if the format is correct it does build locally just fine....

if your local code is not formatted, you need either format on eclipse or
use mvn formatter:format

---

Reply to this email directly or view it on GitHub:

#69 (comment)

—
Reply to this email directly or view it on GitHub
#69 (comment)
.

from formatter-maven-plugin.

This thread. I stand behind my points. This is why forcing at machine level makes no sense. You are suggesting using the IDE. All I did tonight, I didn't even have an IDE open. I did all changes using notepad. So formatting via eclipse was out of the question. Anyway, this is fixed on PR #80

from formatter-maven-plugin.