Comments (9)
hazendaz
commented on June 20, 2024
Not seeing this issue. Try maven 3.9.1 and see if that resolves it.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Delany ***@***.***>
Sent: Tuesday, March 21, 2023 6:05:41 AM
To: revelc/formatter-maven-plugin ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [revelc/formatter-maven-plugin] Large whitespace in debug output (Issue #713)
The debug output includes large blocks of whitespace.
mvn formatter:format -X -l output
Maven v3.9.0, formatter-maven-plugin v2.22.0
[DEBUG] New match='profiles/profile/setting'
[DEBUG] Fire begin() for ObjectCreateRule[className=net.revelc.code.formatter.model.Setting, attributeName=null]
[DEBUG] [ObjectCreateRule]{profiles/profile/setting} New 'net.revelc.code.formatter.model.Setting' using default empty constructor
[DEBUG] Fire begin() for SetNextRule[methodName=addSetting, paramType=null, paramTypeName=null, useExactMatch=false, fireOnBegin=false]
[DEBUG] Fire begin() for SetPropertiesRule[aliases={id=id}, ignoreMissingProperty=true]
[DEBUG] [SetPropertiesRule]{profiles/profile/setting} Setting property 'id' to 'id'
[DEBUG] [SetPropertiesRule]{profiles/profile/setting} Setting property 'value' to 'value'
[DEBUG] [SetPropertiesRule]{profiles/profile/setting} Set 'net.revelc.code.formatter.model.Setting' properties
[DEBUG] ***@***.***, {id=org.eclipse.wst.jsdt.core.formatter.insert_new_line_before_while_in_do_statement, value=do not insert})
[DEBUG] Convert string 'org.eclipse.wst.jsdt.core.formatter.insert_new_line_before_while_in_do_statement' to class 'java.lang.String'
[DEBUG] Converting 'String' value 'org.eclipse.wst.jsdt.core.formatter.insert_new_line_before_while_in_do_statement' to type 'String'
[DEBUG] Convert string 'do not insert' to class 'java.lang.String'
[DEBUG] Converting 'String' value 'do not insert' to type 'String'
[DEBUG] Fire begin() for SetPropertiesRule[aliases={value=value}, ignoreMissingProperty=true]
[DEBUG] [SetPropertiesRule]{profiles/profile/setting} Setting property 'id' to 'id'
[DEBUG] [SetPropertiesRule]{profiles/profile/setting} Setting property 'value' to 'value'
[DEBUG] [SetPropertiesRule]{profiles/profile/setting} Set 'net.revelc.code.formatter.model.Setting' properties
[DEBUG] ***@***.***, {id=org.eclipse.wst.jsdt.core.formatter.insert_new_line_before_while_in_do_statement, value=do not insert})
[DEBUG] Convert string 'org.eclipse.wst.jsdt.core.formatter.insert_new_line_before_while_in_do_statement' to class 'java.lang.String'
[DEBUG] Converting 'String' value 'org.eclipse.wst.jsdt.core.formatter.insert_new_line_before_while_in_do_statement' to type 'String'
[DEBUG] Convert string 'do not insert' to class 'java.lang.String'
[DEBUG] Converting 'String' value 'do not insert' to type 'String'
[DEBUG] endElement(,,setting)
[DEBUG] match='profiles/profile/setting'
[DEBUG] bodyText=''
[DEBUG] Fire body() for ObjectCreateRule[className=net.revelc.code.formatter.model.Setting, attributeName=null]
[DEBUG] Fire body() for SetNextRule[methodName=addSetting, paramType=null, paramTypeName=null, useExactMatch=false, fireOnBegin=false]
[DEBUG] Fire body() for SetPropertiesRule[aliases={id=id}, ignoreMissingProperty=true]
[DEBUG] Fire body() for SetPropertiesRule[aliases={value=value}, ignoreMissingProperty=true]
[DEBUG] Popping body text '
'
[DEBUG] Fire end() for SetPropertiesRule[aliases={value=value}, ignoreMissingProperty=true]
[DEBUG] Fire end() for SetPropertiesRule[aliases={id=id}, ignoreMissingProperty=true]
[DEBUG] Fire end() for SetNextRule[methodName=addSetting, paramType=null, paramTypeName=null, useExactMatch=false, fireOnBegin=false]
[DEBUG] [SetNextRule]{profiles/profile/setting} Call ***@***.***)
[DEBUG] Fire end() for ObjectCreateRule[className=net.revelc.code.formatter.model.Setting, attributeName=null]
[DEBUG] [ObjectCreateRule]{profiles/profile/setting} Pop 'net.revelc.code.formatter.model.Setting'
[DEBUG] characters(
)
[DEBUG] startElement(,,setting)
[DEBUG] Pushing body text '
'
—
Reply to this email directly, view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frevelc%2Fformatter-maven-plugin%2Fissues%2F713&data=05%7C01%7C%7C94e2e42a1f9444d1511c08db29f3d490%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638149899439442860%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=BWmKpXLHuijw7IfmaVfUOjYtjmLfzAL3XjJOXv5qv%2Fs%3D&reserved=0>, or unsubscribe<https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAHODI2NXLFEVZQEV7IN743W5F4PLANCNFSM6AAAAAAWCGQNPI&data=05%7C01%7C%7C94e2e42a1f9444d1511c08db29f3d490%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638149899439442860%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2Fkz6ePjQqLQE2wOJ42s8Cw7%2BJaV1GN%2BEtdK2UqfWSlA%3D&reserved=0>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
from formatter-maven-plugin.
delanym
commented on June 20, 2024
git clone --branch issue-713 https://github.com/delanym/formatter-maven-plugin.git
cd formatter-maven-plugin
./do
from formatter-maven-plugin.
ctubbsii
commented on June 20, 2024
These debug messages are not coming from this plugin. They seem to be coming from Maven, as it parses the configuration. I don't know why it's happening, but I don't think it's an issue for this plugin to solve.
from formatter-maven-plugin.
delanym
commented on June 20, 2024
Seems an issue with commons-digester3: https://issues.apache.org/jira/browse/MNG-7747
from formatter-maven-plugin.
hazendaz
commented on June 20, 2024
Likely coming from our usage of it here https://github.com/revelc/formatter-maven-plugin/blob/main/src/main/java/net/revelc/code/formatter/model/ConfigReader.java and https://github.com/revelc/formatter-maven-plugin/blob/main/src/main/java/net/revelc/code/formatter/model/RuleSet.java
So it seems unless I'm reading that wrong as I only quickly looked is that its doing a quick configuration it can read the xml file. Maybe we can do that some other way.
from formatter-maven-plugin.
hazendaz
commented on June 20, 2024
But yes, not maven, its that library which I know tomcat uses it and its incredibly noisy in debug in general. Still nothing we can do in regards to what is going on there I don't think. The code is certainly probably really old here. I probably did an upgrade from the old commons digester to latest but didn't even remember we use that.
from formatter-maven-plugin.
ctubbsii
commented on June 20, 2024
Oh, my mistake. When I saw that it seemed to be parsing Maven configuration, it seemed like Maven was responsible. But, I guess we're using it. Still, like @hazendaz said, I'm not sure there's anything we can do about it... the debug logs are going to be noisy. If there's a bug in the logs from the digester library, I suggest filing a report with the commons-digester3 maintainers. We can upgrade to the newer version if they release one that fixes it. We can also look into alternatives for reading the config file, but I'm not sure we have a compelling reason to do so. Noisy or poorly-formatted debug lines aren't really very compelling reasons, I think.
from formatter-maven-plugin.
ctubbsii
commented on June 20, 2024
It's a bit hard to troubleshoot how this config parsing code is being used, because it's a bit convoluted, and there's a bit of an overuse of the var keyword, obscuring the types everywhere, but I'm looking into it a bit, to see if there's an easy way to use something else, or strip this out entirely.
from formatter-maven-plugin.
ctubbsii
commented on June 20, 2024
After spending some time figuring out how we're using digester, I think it's best that we leave it as-is. It's possible we could switch to something like FasterXML's Jackson, which I'm more familiar with, but it would require rewriting the models, and the way it is currently implemented is pretty lightweight, has good validation for edge cases (like having multiple profiles in the XML file), and works for both the Java and the Javascript formatter config files. My recommendation is to leave it alone and maybe file a bug with upstream digester maintainers if the whitespace in the debug output is too annoying.
from formatter-maven-plugin.
Related Issues (20)
- NOTICE: Eclipse 2023-06 Requires jdk 17 for many parts HOT 7
- Eclipse Formatter Attribute Ignored: Parameter After Annotation HOT 1
- Sealed interfaces are not correctly formatted HOT 3
- Not able to run validate due to ExtensionRegistry return null value HOT 4
- False configuration used for line Indentation HOT 2
- lineEnding=KEEP breaks JSON validation on Windows HOT 6
- Report problematic line number in error message HOT 3
- Tab treated as one space for the purpose of line length HOT 3
- Includes are not honored by includeResources
- Rewrite the cache store to match that done on impsort HOT 1
- Please use change log or github releases
- Support 'windows' users for contributions
- No documentation for 'find-transitive-eclipse-updates.sh' and it does not work on windows without additional software
- Next Release: placeholder to prevent release HOT 6
- Java 21 compliance HOT 1
- Incorrect documentation HOT 3
- Formatter no longer formats in version 2.24.0 HOT 10
- Integration Tests needed - Good for first time contributors
- NPE: Cannot invoke "org.eclipse.jdt.internal.compiler.ast.TypeReference.extraDimensions()" with version 2.24 HOT 1
- Allow 'validate' to write violations to a file, and not stop the build
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from formatter-maven-plugin.