After bdd925b20 plugin lost the ability to run using defaults about formatter-maven-plugin HOT 8 CLOSED

Fixed at:
#64

from formatter-maven-plugin.

That prior commit has a bug plus the entire point was to fix it so it reads resources like jars. Pretty sure the javascript formatter is broke this way. We should be able to do both...no settings plus all other options.

Sent by Outlook for Android

On Fri, Aug 7, 2015 at 4:02 PM -0700, "Marvin Froeder" [email protected] wrote:
Fixed at:
#64

Reply to this email directly or view it on GitHub:
#63 (comment)

from formatter-maven-plugin.

Branch revert now exists for this as the original velo-merge was removed as it is in master. There were notes of merge conflicts so that will need rebased and looked at further.

from formatter-maven-plugin.

Marked as both a bug and enhancement given the changes were to retain original functionality before merge and it's a loss on the other end so it sort of fits both types.

from formatter-maven-plugin.

agreed

from formatter-maven-plugin.

This issue was indirectly resolved as a result of issue #109 closed on PR #114

from formatter-maven-plugin.

@velo ok maybe this isn't fixed yet entirely. It no longer fails for missing setup but it actually has nothing to default back too. The only thing I can think in the code it attempts to do is setting some compilation level items. However, that section is not reachable code.

I suspect you are referring to this code snippit. Can you confirm? If so, should this apply for both java and javascript or everything in general?

// TODO Review this as this is not exactly reachable code as file can never be null (ie defaults or spaces)
        Map<String, String> options = new HashMap<>();
        options.put(JavaCore.COMPILER_SOURCE, this.compilerSource);
        options.put(JavaCore.COMPILER_COMPLIANCE, this.compilerCompliance);
        options.put(JavaCore.COMPILER_CODEGEN_TARGET_PLATFORM, this.compilerTargetPlatform);

        return options;

from formatter-maven-plugin.

Above code is not reachable. Reviewed overall code. That was set in two places. Both were not reachable. I have reconfigured this. I'll open a new ticket regarding this issue. I'm closing this one.

from formatter-maven-plugin.