Format the project with the formatter about formatter-maven-plugin HOT 12 CLOSED

+1

I think we should format all git history as well... to prevent huge diffs caused only by format

But needs #27 first

from formatter-maven-plugin.

Re: "I think we should format all git history as well"

Please don't rewrite the history with formatting changes. That would be... very anti-git, and would confuse any attempt to merge existing outstanding work.

A huge diff is perhaps a bit annoying, but it's much more friendly than the alternative.

from formatter-maven-plugin.

The problem I see with the huge diff is that it kills history....

When you need/wanna understand why a change was introduced you wont get the information (at least not in a easy way)

from formatter-maven-plugin.

Understood, but rewriting history is not the answer. A commit which only changes formatting, and introduces no other change, is preferable. It's unfortunate that in some cases, it may make history harder to understand, but the effect is localized, limited in scope and in time. I've used this formatter plugin to reformat other projects in a single commit, and it has rarely been disruptive to the point where history could not be understood. This risk is minimal, and far preferred over the side-effect problems of rewriting history. That's my opinion, anyway.

from formatter-maven-plugin.

I wonder, what is the rewriting history side-effect?

I ask cause I'm about to do it for the ninth time =D

from formatter-maven-plugin.

The main problem is that you can't tell if a branch has already been merged, and it makes it difficult to merge cleanly back into a clone. It creates new history, which separates clones from each other, and makes it difficult to see their common ancestor (fork point). When merging, it can reintroduce the same commits, resulting in duplicates.

If you, and everybody who collaborates with you always use rebase, it's not that bad, but it can confuse rebase because of the difficulty of finding the merge-base.

It also breaks any links directly to a commit, and disassociates the tag history from the branch history.

from formatter-maven-plugin.

It's less important if you do it in your own clone/repos, but if you do it in a repository shared by or used by others, it is quite terrible.

from formatter-maven-plugin.

I see

from formatter-maven-plugin.

what is our default code formatter?
https://github.com/revelc/formatter-maven-plugin/blob/master/src/test/resources/sample-config.xml ?

or something else?

from formatter-maven-plugin.

Made a PR for it.

For start, is just eclipse vanilla formatter

Do you guys agree on that?

#65

from formatter-maven-plugin.

Also, made another PR regarding pom.xml format/order

https://github.com/revelc/formatter-maven-plugin/pull/66/files

from formatter-maven-plugin.

Fixed

from formatter-maven-plugin.