Comments (5)
@ctubbsii: Hi, #133 was closed being too broad. IntellyJ based formatting would be beneficial because it is much more precise than eclipse.
from formatter-maven-plugin.
The inability to work out a set of eclipse formatting rules that are equivalent to what we use in IntelliJ basically prevents us from using this very handy plugin. IntelliJ can import eclipse code styles, but I'm not sure how accurate the translation is and the opposite direction is not supported.
from formatter-maven-plugin.
Closing this, since it is encompassed by #133
from formatter-maven-plugin.
+1 for reopening this one
from formatter-maven-plugin.
The work of formatting is done by dependencies, and not done natively in this plugin's own code (for the most part). Therefore, to support both out-of-the-box would double up the dependency tree. I would be opposed to that. It makes much more sense for people to simply fork this plugin and create a different maven plugin that formats using IntelliJ rules/configuration/dependencies. The alternative is that, at some point, this plugin could be more modular... providing a framework with drop-in implementations, but that significantly complicates the deployment of this plugin (and, in any case, nobody has done the work to make this plugin work that way yet). You'd then have to provide a set of optional dependencies to implement optional behavior. And, that seems less useful than simply writing a different plugin based on IntelliJ.
So, I'm not inclined to reopen this PR. However, I would be willing to discuss a possible design, or to consider a PR, if somebody actually wants to pursue this and put effort into it. I'm still thinking that it would be better as an alternative plugin, rather than bloat this one, though. I think Maven plugins should be lightweight and modular, so you can pick and choose your preferred easy-to-use plugins, rather than use a small set of massive plugins that have a humongous number of configuration options.
from formatter-maven-plugin.
Related Issues (20)
- Release for Eclipse 2022-06 Support HOT 1
- Plugin does not know what to do when records have overridden getters HOT 2
- Cannot invoke IExtensionRegistry.getExtensionPoint because Platform.getExtensionRegistry()" is null HOT 2
- Allow resources to be included when formatting
- On the fly hash before and after to replace current caching system files. HOT 1
- Add support for xml-formatter 'deleteBlankLines' HOT 2
- Drop dependabot in favor of Renovate HOT 3
- Mockito WHEN Bug in Eclipse formatting jdt core 3.32.0 and 3.33.0 HOT 3
- Large whitespace in debug output HOT 9
- Bad format of sealed interfaces extending other interfaces HOT 9
- Option to fail to process invalid setting id HOT 2
- New Configuration hashing into file hash breaks existing caching - only confirmed with XML at the moment HOT 2
- NOTICE: Eclipse 2023-06 Requires jdk 17 for many parts HOT 7
- Eclipse Formatter Attribute Ignored: Parameter After Annotation HOT 1
- Sealed interfaces are not correctly formatted HOT 3
- Not able to run validate due to ExtensionRegistry return null value HOT 4
- False configuration used for line Indentation HOT 2
- lineEnding=KEEP breaks JSON validation on Windows HOT 6
- Report problematic line number in error message HOT 3
- Tab treated as one space for the purpose of line length HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from formatter-maven-plugin.