Add an ability to skip the goal about formatter-maven-plugin HOT 6 CLOSED

Original comment by [email protected] on 24 Mar 2014 at 2:41

• Added labels: Milestone-0.5

from formatter-maven-plugin.

On Mar 24, 2014 2:55 PM, "杨朔" <[email protected]> wrote:
Hi jecki

  I'm using this plugin to format my code, but sometimes I do not want the format plugin executing when I do mvn clean install.
  But currently there is no switch to turn this off.

  So I add an jvm parameter with name skipFormat to skip the formatting with value true.
  For example, when I execute the command mvn clean install -DskipFormat=true, then the format plugin will skip the format action.

 And I've attached the patch file with this mail, could you please check whether you can add it into your next release.

Original comment by [email protected] on 30 Mar 2014 at 2:34

from formatter-maven-plugin.

Committed in r131 and r132

Original comment by [email protected] on 30 Mar 2014 at 2:37

from formatter-maven-plugin.

This can be closed. the skip logic was added. See message above regarding that. I searched code and it is there.

from formatter-maven-plugin.

Before this is closed, I'd suggest we use a standard property naming convention for the user property, like -Dformatter.skip=true rather than the current -DskipFormat=true. This follows other plugins, which have findbugs.skip, checkstyle.skip, rat.skip, etc.

A quick modification is to add the options: alias="skip", property="formatter.skip" to the @Parameter.

Any thoughts or objections?

from formatter-maven-plugin.

I'm good with that. I've never personally used the formatter skip but can see why it's important and should be consistent to other maven plugins.

--- Original Message ---

From: "Christopher Tubbs" [email protected]
Sent: May 13, 2015 1:59 PM
To: "revelc/formatter-maven-plugin" [email protected]
Cc: "Jeremy Landis" [email protected]
Subject: Re: [formatter-maven-plugin] Add an ability to skip the goal (#25)

Before this is closed, I'd suggest we use a standard property naming convention for the user property, like -Dformatter.skip=true rather than the current -DskipFormat=true. This follows other plugins, which have findbugs.skip, checkstyle.skip, rat.skip, etc.

A quick modification is to add the options: alias="skip", property="formatter.skip" to the @Parameter.

Any thoughts or objections?

Reply to this email directly or view it on GitHub:
#25 (comment)

from formatter-maven-plugin.