revault / aquarium Goto Github PK

https://github.com/revault/aquarium/blob/master/test_framework/coordinatord.py#L192-L202

Describe the bug

soft_unicode is removed from MarkupSafe version 2.1.0, and this project uses it

I got an error with this versions 2.1.1 & 2.1.0

ImportError: cannot import name 'soft_unicode' from 'markupsafe'

Any version >=0.23 and <2.1.0 will work.

Solution

This project works well with MarkupSafe>=0.23,<2.1.0
Mentioning this in requirements.txt will solve the problem.

Describe the bug

When using non-bash shell say zsh, shell does not open.

In file aquarium.py,
executing subprocess.call([SHELL, "--init-file", f"{aliases_file}", "-i"])
produces error
/usr/bin/zsh: no such option: init_file

this is because zsh dont support providing init-file yet.

Expected Results

1. Since zsh don't support init-file, it should always start bash insteed
2. we can start bash only when default shell is zsh ie. if SHELL.endswith('zsh').
3. make it work for zsh

Solution1.

SHELL="/usr/bin/bash"
subprocess.call([SHELL, "--init-file", f"{aliases_file}", "-i"])

Solution2.

if SHELL.endswith('zsh'):
subprocess.call(["/usr/bin/bash", "--init-file", f"{aliases_file}", "-i"])
else:
subprocess.call([SHELL, "--init-file", f"{aliases_file}", "-i"])

Solution3.

since zsh dont support init-file this has to be done the hard-way.

Any solution to support zsh with aliases is most welcome.

Both revault/coordinatord@21456ca and revault/coordinatord@4ae392b changed the coordinator binary name, so revault_coordinatord shouldn't be hardcoded.

After revault/revault_tx#112 they are not mandatory anymore. Cosigning servers aren't needed for any of the feature we currently provide and even eventually i don't think they should be used for the vast majority of the deployments. Therefore they should not be used by default.

• After updating from revault/revaultd#290 add a new env config var WITH_COSIGS set to 0 by default