Comments (6)
I've added newVersion
and oldVersion
attributes to the config that are to be used in cases where you compare just the currently built project with its older version (which is an absolute majority of cases, IMHO). In this case specifying just the version overcomes the problems with the packaging vs. extension.
This is going to be present in revapi-maven-plugin-0.4.4
.
from revapi.
That's very cool, thanks!
from revapi.
hmm I've tried it and I can't make it work.
I have:
<plugin>
<groupId>org.revapi</groupId>
<artifactId>revapi-maven-plugin</artifactId>
<!-- Lock down plugin version for build reproducibility -->
<version>0.4.3</version>
<dependencies>
<dependency>
<groupId>org.revapi</groupId>
<artifactId>revapi-java</artifactId>
<version>0.6.3</version>
</dependency>
</dependencies>
<executions>
<execution>
<id>revapi-check</id>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<configuration>
<oldVersion>${xwiki.compatibility.previous.version}</oldVersion>
<skip>${xwiki.revapi.skip}</skip>
<analysisConfiguration><![CDATA[
{
"revapi": {
"filter": {
"elements": {
"exclude": [".*\\.internal\\..*", ".*\\.test\\..*"]
}
}
}
}
]]></analysisConfiguration>
</configuration>
I see in eb7d36d that this should work but it doesn't and when I run revapi, it says it's comparing to version 6.4.8 (it should be 8.0 since that's the value of ${xwiki.compatibility.previous.version}
(FTR I checked mvn help:effective-pom
and it's indeed 8.0 and the config seems ok).
Any idea? Thanks
from revapi.
Have you built the maven plugin from source? I see you are using revapi-maven-plugin-0.4.3 in you snippet above, but this will be available only in 0.4.4 that I haven't released yet...
from revapi.
oh my bad... I was using version 0.4.2 and upgraded to 0.4.3, without realizing that the change was in 0.4.4, sorry for the false alarm. Eagerly waiting for 0.4.4 to be released then :)
from revapi.
This should be present in revapi-maven-plugin:0.4.5
.
from revapi.
Related Issues (20)
- Usage of @Deprecated HOT 6
- java.class.externalClassExposedInAPI thrown for an API already exposed in another module HOT 1
- Possibly false-positive java.class.externalClassExposedInAPI HOT 4
- Version format check is too restrictive HOT 4
- Be able to substitute artifacts based on some pattern to handle the XWiki legacy strategy HOT 5
- Making a public constructor protected in an abstract class should not be reported as breakage HOT 2
- Maven site for revapi fails miserably
- Revapi produces inconsistent results
- Enforcing criticality HOT 2
- Running into an endless Loop at org.jvnet.hudson HOT 3
- Infinite loop in differences HOT 2
- externalClassExposedInAPI in dependencies ? HOT 15
- "Invalid element" when upgrading to revapi-java 0.27.0 HOT 2
- Potential NullPointerException in ClasspathScanner$Scanner HOT 5
- Add Concept for String or Pattern Match
- Ability to Enforce TreeFilter Ordering HOT 1
- revapi dependency org.apache.logging.log4j:log4j-core has multiple CVE against it
- how could a enum class be excluded from java.field.enumConstantOrderChanged? HOT 4
- Fix warnings reported by Maven when using the Revapi plugin
- Class visibility reduction from `public` to `package` is reported as `java.class.removed` in latest version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from revapi.