Possibly false-positive java.class.externalClassExposedInAPI about revapi HOT 4 CLOSED

Note that when Manuel wrote this ticket he didn't know about (https://revapi.org/revapi-site/main/faq.html#_how_to_deal_with_external_class_exposed_in_api) and that we're already excluding this check for XWiki classes (see https://github.com/xwiki/xwiki-commons/blame/master/xwiki-commons-tools/xwiki-commons-tool-verification-resources/src/main/resources/revapi.json#L81-L93).

Now the bug or problem seems to be that we're still getting these errors reported even though we're ignoring them.

@metlos do you see anything wrong at https://github.com/xwiki/xwiki-commons/blame/master/xwiki-commons-tools/xwiki-commons-tool-verification-resources/src/main/resources/revapi.json#L81-L93 ?

I noticed that in your example at https://revapi.org/revapi-site/main/faq.html#_how_to_deal_with_external_class_exposed_in_api you don't escape the .s inside the <code> element, whereas we do. Isn't the regex also for <code>?

Thx!

from revapi.

I think your use of escaped dots is ok.
But notice that the configuration uses the package regex: com\\.xpn\\.xwiki\\..*, whereas the package of class com.xpn.xwiki.XWikiException for example is com.xpn.xwiki. The regex only captures subpackages, not the com.xpn.xwiki itself. I think this should work if you changed your package regex to com\\.xpn\\.xwiki(\\..*)?...

from revapi.

Let me close this issue for now but please open a new one if you find any trouble with this.

from revapi.

Thanks a lot @metlos. I've now updated our code to use the new regex (thanks for noticing!): xwiki/xwiki-commons@43f427e

We'll see if it works.

from revapi.