Git Product home page Git Product logo

rxpguides's Introduction

rxpguides's People

Contributors

aaronma37 avatar ahmpy avatar calamityrxp avatar corporategoth avatar hong0311 avatar iainbrux avatar jazminite avatar justinmclapperton avatar kawo avatar ksuper2 avatar lardeck avatar medicrxp avatar mugen1976 avatar progton avatar sabrevalkyrn avatar saffathasan avatar semigall avatar sevenleaveswow avatar shiekrunner avatar tacticslol avatar thiddi avatar tommysalamiwow avatar yamanlol avatar zarant avatar zhirsch avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

rxpguides's Issues

Hide guides outside level range

The current list is very large and will only get larger with Wrath

image

Hide guides with zones outside mob XP (e.g. currentLevel - 9)

[Feature Request] Auto updating targeting macro

While unitscan has its uses, it would be nice if each step can also show a targeting macro to target the mobs that are needed for drop or kill quests.

The macro contents can be something like

/cleartarget
/target <mob name>
/cleartarget [dead]

And that macro could then be tied to RXPItemFrameButton1, and the 2nd mob tied to RXPItemFrameButton2 and so on.

Just remember that macros can be not created/edited in combat.

Boosted characters can't pick up quest

Description

TBC Classic has some quest bugged for boosted characters and at least one is part of the "Boosted Character 58-60" guide. The quest called "The First and the Last" early in the guide can't be picked up, probably because of a misconfiguration on Blizzard's end. Since it has around zero chance that they ever gone fix this, probably this quest should be removed from the guide.

Dev notes

Why does the Horde 20-23 guide have you doing level 17 quests?

There is a part of the 20-23 Horde Guide (Stonetalon/Barrens) where it has you going into the Wailing Caverns cave to do level 17, 18, etc quests like Serpentbloom and Deviate Hides.....

https://github.com/RestedXP/RXPGuides/blob/main/Guides/RestedXP%20Horde%2020-30.lua#L563

Why is this? That doesn't seem very optimal at all. A green level 17 quest for example is going to reward you with a low amount of xp per time spent when you are level 20, 21, 22, 23, etc...

These guides should have you doing yellow quests almost exclusively...

Waypoint Arrow label text size not saved between sessions

Steps to reproduce:
image

1. Change the font size of the Arrow Text Size in the Interface window. (in the example used i chose 11)
2. Click Okay in the Interface window.
3. Reload the UI.

Observed behavior:

  • The size of the font reverts to the default without visibly changing the slider or the number after reloading UI

image
image

Expected behavior:

  • The size of the font for the Arrow Text Size is expected to be saved between sessions

Unrelated to the bug:
Hi, new to github, but myself and my friends love your speedrun addon, so i had to make an account to address an issue that is mildly annoying but doesn't ultimately break any functionality of the addon. Thanks for your time! :)

Add option to disable flight map times

As a user of Leatrix Plus with with their flight time options enabled it would be nice if we had the option to disable the flight times that are now used by Rested XP on the flight maps when clicking the flight masters. As of now they are listed twice with RXP enabled.

Enhance player tooltips with leveling times

Depends on #78

Copy from Gogo's initial spec:

Gives people a way to broadcast their achievements to other users with the RestedXP add-on.

Helps with marketing.

Should allow users to select what they broadcast in the Options Interface… based on data Rested XP has.

Show Most Recent Level... and if we have data then we should also show time for:

Show Wrath of the Lich King (70-80)

Show The Burning Crusade (60-70)

Show Classic (1-60)

Broadcast should be done by a “yell” in hidden add-on channels, and should be turned off when in a raid, and when in a city (either by zone, or when a user is gaining rested XP).

Broadcasting the “XP to Level” for players that are not max level is nice. One less time you have to ask, “How close are you to level?”

Will also need some sort of data verification tool we can fire at login, but this is less important. Most users won’t know how to go in and edit the data the add-on broadcasts.

Suggestions@2x(2)

The grey ovals that are projected on the map as a background for step numbers are visible when map isn't open.

While leveling, I noticed that there were grey ovals scattered across my screen. It took me a while to figure out these were the ovals that are visible on your map, where they are used as a background for the step numbers.

I will post a screenshot later today.

I am using Leatrix Maps addon, which allows for a non-fullscreen map, so that might cause the issue, although it would be preferable to have this addon work together with such add-ons.

3.1.4 Bindings missing

A Bindings.xml file is missing from the root of the addon.
Contents would be something like this (judging from the name substitutions used in RXPGuides.lua)

<Bindings>
  <Binding name="CLICK RXPItemFrameButton1:LeftButton" header="RXPGuides" category="ADDONS">
  </Binding>
  <Binding name="CLICK RXPItemFrameButton2:LeftButton" category="ADDONS">
  </Binding>
  <Binding name="CLICK RXPItemFrameButton3:LeftButton" category="ADDONS">
  </Binding>
  <Binding name="CLICK RXPItemFrameButton4:LeftButton" category="ADDONS">
  </Binding>
</Bindings>

The Bindings.xml file is also never referenced in the .toc (the wow client loads it automatically if present) so it should be removed from the .toc (all 3 toc variants)

Add support for group quests

This is both a request for the addon and for the paid guides but I couldn't find an issue tracker for the guides so I'm not sure if this is the correct place for it.

When duoing from 1-60 as for example priest and warrior there are several quests that are difficult to do solo as either class but are easy as a duo that are not recommended in the guide.

Notably Defeat Nek'rosh, Fallen Sky Lake, and Khan Hratha provide decent rewards and are easy to duo while not being recommended in the priest/warrior guides.

The concrete suggestion is to add a group guard condition that is only activated while in a group, or possibly through a setting in the options.

Initially support for this could probably be easily achieved in existing guides by guarding difficult quests behind hunter || group instead of just hunter.

Auto hide in raid bug.

When entering an Alterac Valley the addon is hidden correctly.
When leaving the BG, the addon is still hidden.
Clicking on the minimap icon to "Toggle guide" does nothing.
Need to toggle "Hide Window" under General > Interface in order to get it to show again.

LUA Errors loading guides

Getting several LUA errors on startup, seems it's trying to load guides I don't have (and use/need).

Currently using the 1-70 guides for only Alliance, so I've got Alliance 1,2,3, and 4 installed. Getting errors for Alliance-5 and Horde 2,3,4,5 and an error for Bindings:

Message:  Error loading Interface\AddOns\RXPGuides\Guides/Alliance-5.lua
Time: Sun Jul  3 11:51:52 2022
Count: 2
Stack:  Error loading Interface\AddOns\RXPGuides\Guides/Alliance-5.lua

Locals: <none>

Message:  Error loading Interface\AddOns\RXPGuides\Guides/Horde-2.lua
Time: Sun Jul  3 11:51:52 2022
Count: 2
Stack:  Error loading Interface\AddOns\RXPGuides\Guides/Horde-2.lua

Locals: <none>

Message:  Error loading Interface\AddOns\RXPGuides\Guides/Horde-3.lua
Time: Sun Jul  3 11:51:52 2022
Count: 2
Stack:  Error loading Interface\AddOns\RXPGuides\Guides/Horde-3.lua

Locals: <none>

Message:  Error loading Interface\AddOns\RXPGuides\Guides/Horde-4.lua
Time: Sun Jul  3 11:51:52 2022
Count: 2
Stack:  Error loading Interface\AddOns\RXPGuides\Guides/Horde-4.lua

Locals: <none>

Message:  Error loading Interface\AddOns\RXPGuides\Guides/Horde-5.lua
Time: Sun Jul  3 11:51:52 2022
Count: 1
Stack:  Error loading Interface\AddOns\RXPGuides\Guides/Horde-5.lua

Locals: <none>

Message:  Couldn't open Interface\AddOns\RXPGuides\Bindings.xml
Time: Sun Jul  3 11:51:52 2022
Count: 1
Stack:  Couldn't open Interface\AddOns\RXPGuides\Bindings.xml

Locals: <none>

Fix hiding /played data on login

Originally built for TBC, this code adequately hid login /played data.

local ReportPlayedTimeToChat = false
local hookedChatFrame_DisplayTimePlayed = ChatFrame_DisplayTimePlayed
local function RequestTimePlayed()
ReportPlayedTimeToChat = false
return _G.RequestTimePlayed()
end
ChatFrame_DisplayTimePlayed = function(...)
if ReportPlayedTimeToChat then
return hookedChatFrame_DisplayTimePlayed(...)
end
ReportPlayedTimeToChat = true
end

Retrieving quest data...

I'm on the guide 40-43 Badlands / Lower Dustwallow and on step 21 it's just reading Retrieving quest data.
What can I do to fix this issue? I'm stuck on the guide.

Contributions

I've been slowly compiling a list of oddities, and additions for some of the guides, is there some way to submit those changes? I've added them to my own fork of the repo, so I could make a pull request if you want?

If you're not interested, no problem, no harm done 😉

localization

Hello author~ Can you add Chinese? This is a good plugin. Works better than Zygor in my opinion

Question on updated guides

Hi, quick question.

If a guide gets updated, does the guide automatically get updated when a new version of addon comes out? Or do we have to update the guide by reimporting the string from orders page?

Revisit profile support

Initial support was quick, revisit and ensure copying, new, shared, and deleting profiles all work as expected.

Only load/parse active or selected guide

Right now, all guides get loaded into memory, this is fairly heavy especially with Wrath adding even more guides.

Only load/parse guides that are actively selected, leave the rest as just strings in the menu.

Horde Hillsbrad / Druid quest order is a bit weird

https://github.com/RestedXP/RXPGuides/blob/main/Guides/RestedXP%20Horde%2020-30.lua#L1317

Here you just finish Battle of Hillsbrad, but it doesn't instruction you to turn it in. If you are a Druid, it instead has you try to complete your Pendant of the Sea Lion, but you can't do that unless you are already in Moonglade and are standing at the Shrine of Remulos.

Then the guide has you port to moonglade

Then hearth to Org. Then it says

"We're not going to turn these quests in until later on". I have no idea what quests it's talking about.

The order should be:

  1. Turn in Battle of Hillsbrad
  2. (If druid) Teleport to Moonglade
  3. (if druid) Go to Shrine of Remulos in Moonglade
  4. (if druid) Combine the pendants
  5. (if druid) Turn in the trial of the sea lion
  6. Hearth to Orgrimmar

Feature request: Show/Hide the step list

Hello, and thanks for doing an awesome job.

I am using v4.2.7 and have tried to find a way to hide the main addon widget containing the steps and options buttons, but could not find any options for this. It's kind of dramatic to disable the addon in order to be able to hide it. A suggestion of placement of this hide/show button is in the list that is shown when pressing the options button

image

Update UseContainerItem for DF

Reported on latest alpha

Message: Interface/AddOns/RXPGuides/HSBatching.lua:34: hooksecurefunc(): UseContainerItem is not a function
Time: Sat Oct 29 10:10:07 2022
Count: 1
Stack: Interface/AddOns/RXPGuides/HSBatching.lua:34: hooksecurefunc(): UseContainerItem is not a function
[string "=[C]"]: ?
[string "=[C]"]: in function `hooksecurefunc'
[string "@Interface/AddOns/RXPGuides/HSBatching.lua"]:34: in main chu

[BUG] Disappearing Arrow after BG's ["minimap"] option

The arrow disappears when coming back from a BG. Even if you click hide and then show in options or reload the arrow remains missing.

I narrowed the issue down to the minimap setting below. When you come out of the BG this option is inserted into the characters profile settings. If you then change show to true and relaunch the game the arrow is back.

It appears that the options UI is not reading this setting.

Another possible issue that needs further testing is that when coming back from the BG it seems to have reset my xprate back to one instead of 1.5.

RXPCSettings = {
	["profileKeys"] = {
		["Odinwulf - Mankrik"] = "Odinwulf - Mankrik",
	},
	["profiles"] = {
		["Odinwulf - Mankrik"] = {
			["windowScale"] = 1.3,
			["hideGuideWindow"] = false,
			["enableLevelUpAnnounceGuild"] = true,
			["minimap"] = {
				["show"] = false,
			},
			["mapCircle"] = true,
			["frameHeight"] = 125.0000076293945,
			["xprate"] = 1,
			["hardcore"] = false,
		},
	},
}

Error in chat on login

Error parsing guide 64-65 Nagrand: No item ID provided
.destroy 24475 You can delete "Gordawg's Imprint" from your bags, as it's no longer needed

Fix leveling tracker conflicts with BlizzMove

Bad anchor connections for "CharacterFrame":


"UIParent" is outside anchor family, but referenced by "UIParent.2962671b530" (created in "UnknownFile:0")

"PlayerStatLeftTop" is outside anchor family, but referenced by "PlayerStatFrameLeftDropDown" (created in "UnknownFile:605")

"PlayerStatRightTop" is outside anchor family, but referenced by "PlayerStatFrameRightDropDown" (created in "UnknownFile:622")

Doomkin got a workaround in place I forgot to follow up with https://discord.com/channels/826162743669162034/1019642310901911653/1022585579470344263

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.