resike / elvui_cpu Goto Github PK

In an attempt to profile ElvUI for performance reasons, I tried this addon.

I followed the guide on this site.
Unfortunately, I get an error when I use /ecpu and the window doesn't load.

Hoping you can fix it - or respond with a fix in the code that I can add.

The Lua error:

Message: Interface/AddOns/ElvUI_CPU/Widgets/Table.lua:233: attempt to call method 'SetMaxResize' (a nil value)
Time: Wed Nov  9 17:07:30 2022
Count: 1
Stack: Interface/AddOns/ElvUI_CPU/Widgets/Table.lua:233: attempt to call method 'SetMaxResize' (a nil value)
[string "=[C]"]: in function `SetMaxResize'
[string "@Interface/AddOns/ElvUI_CPU/Widgets/Table.lua"]:233: in function `CreateColumn'
[string "@Interface/AddOns/ElvUI_CPU/Widgets/Table.lua"]:195: in function `AddColumn'
[string "@Interface/AddOns/ElvUI_CPU/ElvUI_CPU.lua"]:193: in function `CreateOptions'
[string "@Interface/AddOns/ElvUI_CPU/ElvUI_CPU.lua"]:105: in function `?'
[string "@Interface/AddOns/ElvUI_CPU/ElvUI_CPU.lua"]:41: in function <Interface/AddOns/ElvUI_CPU/ElvUI_CPU.lua:40>
[string "=[C]"]: ?
[string "@Interface/AddOns/ElvUI/Core/Developer/Frame.lua"]:130: in function `?'
[string "@Interface/FrameXML/ChatFrame.lua"]:5219: in function `ChatEdit_ParseText'
[string "@Interface/FrameXML/ChatFrame.lua"]:4883: in function `ChatEdit_SendText'
[string "@Interface/FrameXML/ChatFrame.lua"]:4919: in function <Interface/FrameXML/ChatFrame.lua:4915>
[string "=[C]"]: in function `ChatEdit_OnEnterPressed'
[string "*ChatFrame.xml:127_OnEnterPressed"]:1: in function <[string "*ChatFrame.xml:127_OnEnterPressed"]:1>

Thanks!

When resetting the CPU data (by clicking the gear button), the time does not reset to that moment but stays as time since last UI reload. This skews the calls/sec data negatively from reality after clicking it once. Changing the function CPU:GetLoadedTime() to instead
return max(floor(GetTime() - self.loadedtime or ElvUI.loadedtime), 1) on line 109 lets the updated CPU.loadedtime call on line 262 to be used for these calculations instead of the constant time since UI reload. The max function is needed to avoid divide by zero issues.

This does not fix the calculations when doing a manual garbage dump (like shift-clicking the system datatext provided by ElvUI) which will still exhibit the incorrect timing as it is currently (since CPU.loadedtime isn't updated when doing this).

Maybe this is the intended behavior as Sympy alluded to in discord, but I think this change generally makes the data in the calls/sec column more accurate and valuable.

After manually implementing the pull request ( #3 ) that allows the table to open, the numbers are all set to 0%, 0ms, etc. The buttons do not do anything, and clicking on the settings gear causes a micro freeze that then disappears, with no reported lua error.