Git Product home page Git Product logo

Comments (2)

AaronErhardt avatar AaronErhardt commented on June 25, 2024

Thanks for the report!
I wasn't really aware of the differences between call site and mixed site so far despite writing thousands of lines of proc-macro code. Should be relatively easy to fix, probably most Ident::new calls simply have to be adjusted.

from relm4.

PJungkamp avatar PJungkamp commented on June 25, 2024

I've checked most invocations of quote! and quote_spanned! and the macro hygiene isn't to great in some places. Changing the span of most idents, I've found several places where identifiers such as __current_page and similar are created or used in an invocation of quote_spanned!. This makes those identifiers assume the provided span which in some places is a call site span. These kind of identifiers should really be created outside of the quote_spanned invocation and be given a mixed site span.

Rust macros really shouldn't need the C-style underscore prefixes, proper use of Span should take care of name conflicts.

from relm4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.