reidmain / fdmodel Goto Github PK

Currently FDModel has the concept of saving which attempts to save the model object to a FDModelStore but there is no way to delete the model from that store.

FDModel currently makes no attempt to ensure thread safety. If an FDModel object is being encoded while it is simultaneously being updated there is a chance that the encoding could crash https://devforums.apple.com/message/1079616. I'm sure there are also a host of other crashes that are probably just waiting to happen because of model objects being updated on multiple threads.

The first fix that comes to mind is that the FDModel, FDModelStore and FDModelProvider should share a NSOperationQueue that ensures that whenever a unsafe operation being performed it is thrown onto the queue. That immediately brings up the issue where what if the operation cannot be asynchronous so perhaps a recursive lock is better to ensure that deadlocks cannot occur.

Inside FDModel's copyWithZone: method it attempts to set the value of properties who are readonly but don't have a backing ivar. This is indicative of computed properties which will always fail and result in an exception that, while it will be caught, will be annoying when you have exception breakpoint turned on.