reflar / gamification Goto Github PK

When a new discussion is made and another user either replies or "likes" the post (or a mod performs some action on it that results in a post to the discussion such as renaming it), the OP gets a notification that a user has downvoted their post when they have in fact not done so.

I'm using PHP 7.1, Flarum 0.1.0-beta.7 and the extension version is 2.0.2.

• By agreeing to these terms, you can simply leave this checkbox checked.

Description

Me again…
With the new 3.0.1 version, when an user reaches the upvote points necessary to unlock the second and the following ranks, these are not automatically updated, next to the username.
The first rank remains instead.

Also, it is no longer possible to control who up/downvoted a post.

Many thanks!

Steps to Reproduce

video: https://www.dropbox.com/s/pj42f3ez3veq8jj/rank.mov?dl=0

Add the ability to change the upvote/downvotes icons and the word "Points". Suggested by SierraKiloGulf.

• By agreeing to these terms, you can simply leave this checkbox checked.

Description

Hi everyone.
When I upvote a post, at first I see the upvote correctly, but refreshing the page (or trying to cancel it), it becomes a downvote.
Also, if I try to cancel an upvote, initially it's removed resuming the previous amount, but refreshing the page it becomes a downvote (and viceversa: canceling a downvote, it becomes an upvote).
More over, my Points are decremented for each comment I definitively delete in a short time (you're going a little too quickly error).

Steps to Reproduce

1. Upvote
2. Refresh
3. Upvote becomes Downvote

Expected Behavior: correct view of the votes

Actual Behavior: Video: https://www.dropbox.com/s/pjvzx8g7ekgsb99/prova.mov?dl=0

Flarum/Server/Client Information

Technical Details

• Version of Flarum: v0.1.0-beta.7
• Version of extension: v2.0.3
• [OPTIONAL] Website URL where the bug is visible:
• The webserver you are running: Apache
• PHP version: PHP 5.6.35
• Hosted environment (Shared, VPS, etc):
• Hosting provider: SiteGround

Flarum Info

Flarum core 0.1.0-beta.7
PHP 5.6.35
Loaded extensions: Core, date, ereg, libxml, openssl, pcre, sqlite3, zlib, bcmath, bz2, calendar, ctype, curl, dba, dom, enchant, hash, fileinfo, filter, ftp, gd, gettext, SPL, iconv, session, intl, json, ldap, mbstring, mcrypt, standard, mysql, mysqli, pcntl, mysqlnd, PDO, pdo_mysql, pdo_pgsql, pdo_sqlite, pgsql, Phar, posix, pspell, readline, Reflection, imap, shmop, SimpleXML, soap, sockets, exif, sysvmsg, sysvsem, tidy, tokenizer, wddx, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, bz2_filter, mailparse, memcache, memcached, mhash, ionCube Loader
EXT flarum-approval v0.1.0-beta.7
EXT flarum-bbcode v0.1.0-beta.5
EXT flarum-emoji v0.1.0-beta.6
EXT flarum-english v0.1.0-beta.7
EXT flarum-flags v0.1.0-beta.7
EXT flarum-lock v0.1.0-beta.7
EXT flarum-markdown v0.1.0-beta.5
EXT flarum-mentions v0.1.0-beta.7
EXT reflar-gamification 2.0.3
EXT flarum-sticky v0.1.0-beta.7
EXT flarum-subscriptions v0.1.0-beta.6
EXT flarum-suspend v0.1.0-beta.7
EXT flarum-tags v0.1.0-beta.8

Such as flarum-ext-circle-groups

After enabling clarkwinkelmann/flarum-ext-circle-groups, there is a colored circle on the avatar.

See the screenshot:

But the colored circle is gone when I enable ReFlar/gamification.

• By agreeing to these terms, you can simply leave this checkbox checked.

Hi!
When you cancel a vote, the rank label doesn't update as it should.

video

Can I ask you if it's possible to introduce the possibility of not allowing to vote your own posts?

Thanks

• By agreeing to these terms, you can simply leave this checkbox checked.

I write it here too:

You're too fast!

Anyway, I found another very little issue:

when you switch from a +1 to a -1 (or viceversa), before a refresh or a click (in an active part of the page?? I cannot find the right words), the two votes remains highlight at the same time.

video

If the 2 forum colors are the same then the upvote and downvote buttons won't have an active look.

I've been thinking about this for a week now and I believe that adding a custom experience and reward system would be ideal for this extension because it falls within the whole idea of "Gamification" itself.

Or should these be separate extensions?

Thoughts? Idea's?

To bring this extension more in line with actual "gamification", we should first discuss #46.

After that has been decided, I believe we should rename the "rankings" page/label/route to say "Leaderboard" instead.

Propositions:

• The new route should point to: https://example.com/leaderboard instead of: https://example.com/ranks.
• The label/button that leads to this route on the IndexPage should be named "Leaderboard" and the trophy icon kept intact.

Suggested by @jordanjay29. Add a hover popup to the vote count number to make it easier for OP find the "Who upvoted/downvoted" modal.

Votes should update w/o refresh

How you started programming?

I installed the extension with the composer command.
Seems like the extension is loading but it's not working correctly.

Texts are shown with the "variable name".
When I upvote a message, the counter is decremented and the vote goes under "downvotes_label"

This weird behaviour started when I clicked on the button to convert the likes into upvotes/downvotes.
When I did, I got an error on the whole website ("There's an error loading the entire version of the website"). This error has disappeared when I enabled (and then disabled) the Debug Mode.

Since then, I can't make the extension working correctly.
Do you know the issue ? Do you know how to fix it ?

A little css animation or something satisfying

Currently, the rank is directly assigned which makes ranks hard to change if you wish to do so in the future. This will allow them to be changed via id.

Uniformity

Hi, sorry for screwing up the issue template.

The ranking page exposes by default the entire user base. While this can be ok for most of the installations, it might be unwanted for some specific ones.

I will try to create a PR to solve this.

This is a feature request.

At the moment, there is a rankings page that ranks users by the number of points that they have acquired on the forum. This is assumed to be a default desired feature of the gamification extension. I would appreciate it if you added the ability to disable this Rankings Page from the admin panel.

Hello, I receive the error seen in the title whenever me or someone else would edit their or someones comment.

POST https://www.localhost/api/posts/100

<br />
<b>Notice</b>:  Undefined index: isUpvoted in <b>/var/www/site/public_html/vendor/reflar/gamification/src/Listeners/SaveVotesToDatabase.php</b> on line <b>80</b><br />
<br />
<b>Notice</b>:  Undefined index: isDownvoted in <b>/var/www/site/public_html/vendor/reflar/gamification/src/Listeners/SaveVotesToDatabase.php</b> on line <b>84</b><br />
<br />
<b>Fatal error</b>:  Uncaught exception 'RuntimeException' with message 'Output has been emitted previously; cannot emit response' in /var/www/site/public_html/vendor/zendframework/zend-diactoros/src/Response/SapiEmitterTrait.php:31
Stack trace:
#0 /var/www/site/public_html/vendor/zendframework/zend-diactoros/src/Response/SapiEmitter.php(27): Zend\Diactoros\Response\SapiEmitter-&gt;assertNoPreviousOutput()
#1 /var/www/site/public_html/vendor/zendframework/zend-diactoros/src/Server.php(162): Zend\Diactoros\Response\SapiEmitter-&gt;emit(Object(Flarum\Api\JsonApiResponse))
#2 /var/www/site/public_html/vendor/flarum/core/src/Http/AbstractServer.php(36): Zend\Diactoros\Server-&gt;listen(Object(Zend\Stratigility\NoopFinalHandler))
#3 /var/www/site/public_html/api.php(16): Flarum\Http\AbstractServer-&gt;listen()
#4 {main}
  thrown in <b>/var/www/site/public_html/vendor/zendframework/zend-diactoros/src/Response/SapiEmitterTrait.php</b> on line <b>31</b><br />

if I reload the page after it says an known error occured, it is edited.
Ofcourse it shouldn't be like this.

Any way to fix this on my side or will this be fixed in an update?

Currently, there is a page that shows how many points a user has and what position they are in the ranking system.

What we could possible add and shouldn't be hard to code is an actual rank page that shows the rank label/badge/color and amount of points needed to get to that rank. This is already done on the Administrative side but this page should be read/view-only.

Ideally, this should be discussed first before addressing #47.

The route for this page should be https://example.com/leaderboard/ranks instead of https://example.com/ranks.

@datitisev @cdk2020 what do you fellas think?

Some examples ofc:

https://crackwatch.com/ranks

Not an ideal representation given that it doesn't go in accordance to this extension but it should be similar in concept.

Should this be a PRO feature or basic addition to this repo?

Hi Everyone - seem to be getting this message despite disabling a variety of extensions, and even disabling floodgate completely (via floodgate.php - see below)

public function assertNotFlooding(User $actor)
{
// if ($this->isFlooding($actor)) {
// throw new FloodingException;
// }
}

Odd thing is that it appeared to be working for quite some time, then only recently, stopped. No matter what extensions I disable, the issue persists. Has anyone seen this before ?

Thanks

Allow them to manually set a user's rank

Add a feature for non-logged users. When they press upvote/downvote, it will show up the login modal.

Show the top users according to votes

Converting likes system has a few bugs.

Add transparency background to the Upvotes and Downvotes buttoms.

Reported @ https://discuss.flarum.org/d/17851-notification-icon-fails-due-to-gamification-extension

ReflectionException: Class Reflar\Gamification\Listeners\PostBasicSerializer does not exist in 
vendor/illuminate/container/Container.php:752

PostBasicSerializer is not imported at https://github.com/ReFlar/gamification/blob/master/src/Listeners/EventHandlers.php#L104

Hi,
If I select Tags as my Homepage, when I sort by "Hotness" in the all discussions page, the url became /allhot instead of /all?sort=hot, sorting by latest.

video

When Flarum is installed in a subdomain, selecting the "Hot" sorting refreshes the page and uses "Latest" instead of the selected "Hot" or any previous non-Latest sorting selection.

Reported by SierraKiloGulf. Colors are not being parsed correctly on the up/downvotes buttoms.

TBD.

Send a notification when a user gets ranked up