Git Product home page Git Product logo

poetradesearchen's People

Contributors

andreienache avatar redsol avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

poetradesearchen's Issues

Auto-fill with reasonable mod value ranges

I'd prefer, when I ctrl+C something, that the searchable modifiers be filled in with a min below the actual value and a max above the actual value, so searches are more likely to yield relevant results. If there is a way to do this from the configuration, I can't discern it from the example.

I'd love to set it to just 80% to 120% so I'm not manually fixing the ranges to try to get hits.

the program is just not functioning.

it needs work. a lot. constantly crashes. doesnt work for majority of items. it just feels hollow, like its
day 1 in beta. is it getting any major update any time soon that could at least get it to level of trade macro? it has nice potential and some useful hot keys, but whats the point if even the CNTRL wheel
stops working and you cant navigate your stash. it just stopped working. and constantly crashes.

How can I configure selected mods ?

Here is example I am using

"checked":[ {"id":"Belts/","text":"# to Strength"}, {"id":"Jewels/Amulets/Rings/Belts/Quivers/Armours/","text":"#% to Fire Resistance"}, {"id":"Jewels/Amulets/Rings/Belts/Quivers/Armours/","text":"#% to Cold Resistance"}, {"id":"Jewels/Amulets/Rings/Belts/Quivers/Armours/","text":"#% to Lighting Resistance"}, {"id":"Jewels/Amulets/Rings/Belts/Quivers/Armours/","text":"#% to Chaos Resistance"}, {"id":"Jewels/Amulets/Rings/Belts/Quivers/Armours/","text":"#% increased Attributes"}, ],

and it wont detect half the mods. Any way to specify if its implicit / crafted ?

Option to count total Energy Shield

Hi,
Could you please make an option to support "total Energy Shield" on the item in anyways? For example like "total resistances" toggle. Thanks

Add gem quality information

When a gem is selected could you show the quality modifier on the Brief page? It's easy enough to click the wiki button so this is a low priority but it was a nice feature of AutoHotKey.

F1 triggering something

F1 in game does something with the chat and I'm not sure what it does as there's nothing in the readme or the config about an F1. Running in admin, win10, default config. I can't tell what It's trying to type into the chat but I can't seem to disable it

LOW PRIORITY: Grey theme

Any chance you could add a grey theme whenever you have time?

As said, this should be a low priority.

Thanks again for everything redsol

Support for Veiled items

This is super low priority, but I noticed that if an item has a veiled mod I cannot select that. The official trade site supports a veiled mod as well as master specific mods such as "Haku's Veiled" or "Of Hillock's Veil". I don't know why some are "of veil" and some are just "veiled", but especially early league some master's veils are worth a lot.

Auto-fill uses range as Min and Max instead of average

So for this item:

Rarity: Unique
Edge of Madness
Etched Greatsword
--------
Two Handed Sword
Physical Damage: 29-59 (augmented)
Chaos Damage: 64-90 (augmented)
Critical Strike Chance: 5.00%
Attacks per Second: 1.40
Weapon Range: 13
--------
Requirements:
Level: 22
Str: 45
Dex: 38
--------
Sockets: G-G-R 
--------
Item Level: 80
--------
40% increased Global Accuracy Rating (implicit)
--------
+1 to Level of Socketed Active Skill Gems
44% increased Physical Damage
Adds 64 to 90 Chaos Damage
1% increased Chaos Damage per Level
Adds 1 to 2 Physical Damage to Attacks per Level
--------
Soon, the pleas for mercy were muted.
Only one voice remained.
Laughing.

the Minimum added Chaos damage was 64 and Maximum was set to 90. On pathofexile.com/trade the value for added damage is the average of the two numbers. So 77 should be the minimum value for this item.

The same is true for 1 to 2 physical damage. Or any added elemental damage on other items.

Allows us to send any keyboard input via config.txt

Like title says like us to do that, this way we can have a fully configurable script allowing us to do things such us

Control + key hotkeys (at this moment you can put a key and then Ctrl = true, but this doesn't work because it doesn't send the text input and Ctrl keys stuck, idk why)
Custom messages "Sorry item has been sold!" Thanks to being able to do ^{enter}

Of course this would make the config.txt much larger since you would need to write every keyinput there but at the end is a huge QoL for us, the users, also it would make the code smaller since every specific method would be removed.

Thanks for your time.

Some examples
Ctrl + 3 = {enter}/delve{enter}
Ctrl + 2 = ^{enter}Sorry this item has been sold!{enter}
Ctrl + 1 = ^{enter}Busy at this moment, could you wait 2min?{enter}

Ability to toggle Item Category and DPS

Right now if I search a one handed axe, that's all I'm gonna see. If I want to expand it to all 1 handed weapons I cannot.

The tool also calculates DPS but does not use it as part of the search. The ability to toggle this on as I want it off most of the time would be good.

Thanks for going over all of these, I know I have a lot :-P

Update Syndicate and Temple default images

I've replaced the images myself but for newer players it could be good to include an English image by default.

https://wraeclast.com/#betrayal has a great syndicate image that they update every league that could replace PoeTradeSearchEN/_POE_Data/Syndicate_0.jpg

There aren't a lot of good updated Temple references but this one https://imgur.com/TpsYIYd does a decent job and might help new players if it replaced PoeTradeSearchEN/_POE_Data/Temple_0.jpg

Also, for what it's worth I would name the images betrayal.png and incursion.png because that's what the other tools use.

Poe Prices API call

Many users don't know what mods on a rare item are even worth searching over. PoePrices returns an estimate of a rare item's price as well as the mods that were used to determine that price. A third tab could be used similar to "brief" and "detailed" that was just "estimate" and would show the price and distribution.

https://www.poeprices.info/

Auto update

Hi,

Would it be possible to have the tool auto update and replace it self with new version?
I love that youre so active in development, so new versions appear every day, and it's a bit tiresome to download and replace by hand every time :D

While at it, would be great to either merge config changes with what's already there done by the user, or if the merge is problematic, then tell user that automerge was not possible and it should be merged by hand

BR,
Adam

Auto-minimize

I am using two screens and usually have PoE on the right screen and a video on the left in fullscreen. Everytime I analyze an item it pops up over my video and I have to tab out to close the window again. Is it possible to implement a toggle to turn on/off auto minimize after 10 sec of not interacting with the program?

Map Modifiers Highlight

This is another feature of AutoHotKey that was super valueable. When you select a rare map all of the mods are loaded already. Now just highlight the mods that a user selected as dangerous in a config file. So for example if my character cannot run reflect maps, if a phys or ele reflect mod shows up it would be highlighted red in the brief page.

Automatically detect corruption status of item

Wondering if it could be possible to automatically detect the corrupted status of a certain item.
I tried price-checking pair of Shaper's Touch but it didn't properly detect the non-corrupted status.

option to always change the stats type to pseudo and add own stats

Hi,

Sometimesd I wish I could change the type to pseudo, like, I've crafted fire and light resists, but i also want to look for items that just have the stat as normal stat to compare mine with crafted to them, since people often just want the stats, no matter if crafted or not, so to do that, I'd like to be able to choose own stats on the list (similar to how it works on the website) with filtering ofc

BR,
Adam

Option to disable item type by default

Hi,

Really like your macro so far, but what I don't like is that the base type is always checked by default and didnt find an option to change that.
What i mean is that it's always price checking for same item base type, like let's say I check an opal ring, it only shows results for opal rings, and not rings in general. Would like to have that off by default.

BR,
Adam

toggle between Offline/Online search for rares

I was wondering if this could be added in because when I price check a rare using the built in price checker in the macro it only pulls up the online results....this is especially useful for rares

Support for Total Elemental Resistance Calc

Would be nice to be able to search for total elemental resistances to a piece of gear, so I could search for "15% elemental resistance" instead of "15% lighting resistance"

Add ^{enter} expression for custom messages

Already coded it, should be something like this:

 else if (valueLower.IndexOf("{ctrlEnter}") == 0)
 {
System.Windows.Forms.SendKeys.SendWait("^{ENTER}");
}

Config.txt:

   {
      "keycode": 59,
      "value": "{ctrlEnter}Sorry, That item has already been sold. item{enter}",
      "position": null,
      "ctrl": true
    },

If there's something wrong, don't hesitate to tell me!

Cannot change Fn keys for shortcuts

Here is what I set my shortcuts to:

		{"keycode":116,"value":"{Enter}/hideout{Enter}","Detail":"은신처 이동 (F5)"},
		{"keycode":0,"value":"{Enter}/exit{Enter}","Detail":"나가기 (F4)"},
		{"keycode":0,"value":"{Enter}/oos{Enter}","Detail":"남은 몬스터 수 (F2)"},
		{"keycode":118,"value":"Syndicate_0.jpg","position":"0x0","Detail":"이미지 출력, 단, .jpg만 가능 (F7)"},
		{"keycode":119,"value":"Temple_0.jpg","position":"0x0","Detail":"이미지 출력, 단, .jpg만 가능 (F8)"},
		{"keycode":0,"value":"{Pause}","Detail":"일시 중지 (F11)"},
		{"keycode":27,"value":"{Close}","Detail":"창 닫기 (ESC)"},
		{"keycode":78,"ctrl":true,"value":"{Link}https://poe.ninja/{Link}","Detail":"닌자 열기 (Ctrl+N)"},
		{"keycode":72,"ctrl":true,"value":"{Wiki}","Detail":"위키 열기 (Ctrl+H)"},
		{"keycode":0,"ctrl":true,"value":"{Run}","Detail":"작동키 (Ctrl+C) 변경은 프로젝트 홈 위키 참고"}

It disables F4 and F2 as expected but it does not change the shortcuts for the Syndicate and Temple to F7 and F8 as desired. Am I doing something wrong?

Rounding error when calculating minimum values

For this item:

Rarity: Unique
Alberon's Warpath
Soldier Boots
--------
Armour: 295 (augmented)
Energy Shield: 17
--------
Requirements:
Level: 49
Str: 47
Int: 47
--------
Sockets: B 
--------
Item Level: 83
--------
16% increased Strength
Adds 1 to 80 Chaos Damage to Attacks
+207 to Armour
+9% to Chaos Resistance
20% increased Movement Speed
+1 to maximum number of Skeletons
--------
Alberon walked among the accursed,
and they welcomed him.

The average for chaos damage to attacks is 40.5, but your code rounds to 41. Since that is over the highest it can ever go it shows no results. My suggestion is either to round down or just leave the 40.5 since that is supported by the official trade site.

Add fast kick and fast invite?

Kick yourself from the current party. Default keybind should be F4.

This will require the character name to be configured as the command is
/kick <playername>

And for fast trade just like lutbot's a sequence of commands that would be
^{enter}{home}{delete}/invite {enter}

Ctrl+enter, picks up @player
home goes to char[0]
delete, deletes the @ and then writes "/invite " with a blank space

Thanks.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.