`Markdown` support for `completion` and `hover` documentation about vscode-xml HOT 13 CLOSED

Most likely caused by the server sending plain text doco. It should return markdown instead.

from vscode-xml.

It should return markdown instead.

Please create an issur for that. But the main problem is that teh xsd:documentation can be written in any format (text, html, other). So how to convert any format to markdown?

from vscode-xml.

Plain text renders fine as markdown. Markdown can include HTML, so HTML renders fine as markdown too. Are there any other formats used in the wild?

from vscode-xml.

@felixfbecker you mean that lsp4xml doesn't need to convert to a markdown format? Just set the the MarkupContent as "markdown" kind?

from vscode-xml.

Yeah. That's what all language servers I know do

from vscode-xml.

Vscode markdown renderer does not support HTML in markdown documentation. See microsoft/vscode#21141 (comment)

from vscode-xml.

But how would marking the content as markdown (which it technically is in that case) be any worse than marking it as plain text? In both cases you see HTML tags in VS Code, but text without HTML renders way nicer and other clients do not have this problem. Also, the hovers already seem to use markdown anyway?

from vscode-xml.

Related server side issue: eclipse/lemminx#245

from vscode-xml.

I quickly tried markdown rendering with remark: https://github.com/fbricon/lsp4xml/tree/remark:

from vscode-xml.

@angelozerr we have Markdown support on hover now but not for completion. Should be pretty straightforward to add

from vscode-xml.

@angelozerr we have Markdown support on hover now but not for completion. Should be pretty straightforward to add

Yes sure, we must just take care of documentationFormat coming from client capabilities:

"completion": {
...
                "completionItem": {
...
                  "documentationFormat": [
                        "markdown",
                        "plaintext"
                    ],

I fear that we have not done that for hover by checking contentFormat capability

from vscode-xml.

Fixed with eclipse/lemminx#528

from vscode-xml.

Also includes link to (local cache of) schema:

from vscode-xml.