redbubble / finch-sangria Goto Github PK

Hey, excellent work on the library. Just trying it out for a POC and ended up with everything wired up nicely including GraphiQL.

Had some issues while upgrading to Finagle 7.0.0 (along with lots of dependency overrides in Build.sbt)

In the utils dependency, rb-scala-utils you include:

META-INF/services/com.twitter.finagle.stats.StatsReceiver

which defines com.redbubble.util.metrics.MetricsStatsReceiver

Finagle have made a few changes here and broken backward-compatibility so you get an error something like this:
An exception or error caused a run to abort: Method com/redbubble/util/metrics/MetricsStatsReceiver.addGauge(Lcom/twitter/finagle/stats/Verbosity;Lscala/collection/Seq;Lscala/Function0;)Lcom/twitter/finagle/stats/Gauge; is abstract

Excluding the library solves this problem:
System.setProperty("com.twitter.finagle.util.loadServiceDenied", "com.redbubble.util.metrics.MetricsStatsReceiver")

I was wondering about the following:

• When would be a good time to upgrade to Finagle 7.*, happy to submit a PR?
• Perhaps the Redbubble stats receiver should not be included in the META-INF of rb-scala-utils anyway, as it is quite easy to miss?