redacted-cartel / pirex-convex Goto Github PK

List of detectors to add (will update as we find more)

• Detect expressions not being assigned to a variable or evaluated in a statement
  • Example: #29 (comment)

Tokenize staking emissions and extra incentives from Convex and enable users to claim.

Create a 1 year simulation of Pirex growth and usage

Dedupe and add missing test cases.

Examples

• to -> receiver
• amount -> assets

https://github.com/Rari-Capital/solmate/blob/main/src/mixins/ERC4626.sol

Functionality which would allow us to safely handle emergency situations

• Add variable address public pirexCvxMigration which can only be set when protocol is paused (i.e. emergencies)
• Add methods for migrating CVX and reward tokens to pirexCvxMigration
  • Everything except outstandingRedemptions (we will allow users who initiated a redemption to withdraw their CVX from the old contract)
• Separate PirexCvx contracts and ERC20Snapshot contract
• Separate token contracts (e.g. upCvx) from PirexCvx
  • Remove instantiating and setting those contracts in the constructor

Stake unlocked CVX and unstake on redemptions.

https://github.com/crytic/echidna

One of the causes is that we're not checking if values derived from calculations with rounding down operations are non-zero.

Enable users to add liquidity and swap lockedCVX and voteCVX for another token (ETH may be most convenient for users).

As a result of separating our token from the PirexCvx contract, there are instances where the CEI pattern is not adhered to

Expanding upon our existing UnionPirexVault.sol with the logic from Union's GenericVault. Also, currently exploring whether Fei Flywheel would be a better alternative to the existing staking strategy.

Similar to how Convex has penalties for not relocking/unlocking vlCVX after the lock expires.

Add contract ABIs and the relevant contract methods to the frontend app.

NOTE: @kphed will notify @justingreenberg and @stevenmichaelthomas after contracts are ready.

Fees

• Unlock fee (1-5% calculated linearly over a period of 17 weeks - longer lock means lower fees)