reasonml-old / bs-node Goto Github PK

Is this the candidate we are shipping back to bucklescript upstream?

Node.Fs.readFileSync(""); works, but Node.Crypto. ... yields The module or file Node.Crypto can't be found. - same with Node_crypto. ... and Crypto. ....

I couldn't find any tests validating that Crypto actually works.

I saw in another issue that there was a plan to create a separate repository for fs bindings. Was the repo created? I'd like to add some bindings fs.readDir to accept options. If no repo was created, I would love to do it and add some bindings.

Is this API incomplete? The binding returns a NodeStringBuffer, but that module has no methods in it.

There is no LICENSE file. Is this by design?

Can we add a bindings for process.on() ? https://nodejs.org/api/process.html

Something like this:

[@bs.send.pipe: Node.Process.t]
external on :
  (
  [@bs.string]
  [
    | `unhandledRejection(string => unit)
    | `SIGINT(unit => unit)
    | `SIGTERM(unit => unit)
  ]
  ) =>
  Node.Process.t =
  "";

It would be awesome if bs-node could be visible in rtop.
After a bit of discussion on Discord I went ahead and discovered things that you folks already know but what it is necessary for it to work is basically to be compatible with ocamlfind/findlib.
After that, #require can be used to load packages directly in it.

This user guide contains the specification of what is some sort of package descriptor (nothing magic there) and I was kind of wondering if I could have a good in achieving this 😀

If you folks are interested of course, I think it is worth having a solid repl driven workflow for many Reasons: it enhanced discoverabily, shortens API browsing time, keeps you focused and in the flow (no context switching). It is some inheritance from my Clojure experience, a good one that I would like to keep.

Among other missing bindings it would be nice to have one for process.env
https://nodejs.org/api/process.html#process_process_env

Hello

Is there any way to contribute? there no contributing.md on how to do so... Thanks!

Btw. I tried adding some functionality then running the npm build script. After it succeded "building" it i used the command:

npm link to test it locally but it did not work :(

That's why i am asking for an contributing.md. I might be doing something wrong!

Cheers.

Calling Node.Path.resolve() breaks the build when using bs-platform 2.2.2.

  We've found a bug for you!
  /home/zach/src/bs-puppeteer/__tests__/puppeteer_test.re

  It's possible that your build is stale.
  Try to clean the artifacts and build again?

  Here's the original error message
  The files /home/zach/src/bs-puppeteer/node_modules/bs-node/lib/ocaml/node.cmi
  and src/Puppeteer-BsPuppeteer.cmi make inconsistent assumptions
  over interface Node

ninja: build stopped: subcommand failed.
>>>> Finish compiling(exit: 1)

I think this is because the type signatures differ between bucklescript's resolve and the one included here. BS has it as string -> string -> string, whereas the one here takes an array of strings using [@@bs.splice].

Not sure what the best way to deal with this is. We actually only really wanted to use the Buffer module.