Git Product home page Git Product logo

Comments (4)

Risto-Stevcev avatar Risto-Stevcev commented on July 18, 2024 1

Yeah, but also just adding it here so I don't forget about it. I'm not sure when I'd be able to work on this

from bs-webapi-incubator.

glennsl avatar glennsl commented on July 18, 2024

Not sure if you're asking for my approval of this, but if you are: I approve!

from bs-webapi-incubator.

yawaramin avatar yawaramin commented on July 18, 2024

@Risto-Stevcev if you are planning to use instanceof, note that it's tricky because different windows have different prototype chains and instanceof doesn't work across windows. This will need to be accounted for. See e.g.

bs-webapi-incubator/src/Webapi/Webapi__Dom/Webapi__Dom__Element.re

Line 8 in aad089a

let asHtmlElement: T.t => option(Dom.htmlElement) = [%raw {|

from bs-webapi-incubator.

Risto-Stevcev avatar Risto-Stevcev commented on July 18, 2024

Thanks for the heads up @yawaramin 🙂

from bs-webapi-incubator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.