realityone / docker-image-py Goto Github PK

Running this code:

from docker_image import reference
reference.Reference.parse('123.dkr.ecr.eu-west-1.amazonaws.com:lol/abc:d')

It seems to hang, and CPU usage goes up.

Edit: Sorry, I wasn't clear. This is an invalid reference, but it ideally shouldn't cause a system to hang and experience CPU spikes if parsed.

/ # python -V
Python 2.7.13

File "/usr/local/lib/python2.7/site-packages/docker_image/regexp.py", line 43, in
class ImageRegexps(object):
File "/usr/local/lib/python2.7/site-packages/docker_image/regexp.py", line 53, in ImageRegexps
optional(repeated(literal(r'.'), HOSTNAME_COMPONENT_REGEXP)),
File "/usr/local/lib/python2.7/site-packages/docker_image/regexp.py", line 16, in literal
return match(_quote_meta(s))
File "/usr/local/lib/python2.7/site-packages/docker_image/regexp.py", line 5, in _quote_meta
special_chars = regex._METACHARS
AttributeError: 'module' object has no attribute '_METACHARS'

When parsing custom images (format: $user/$image) from the default registry (docker hub), split_hostname() returns the user name as registry hostname.

Example:

>>> from docker_image import reference
>>> ref = reference.Reference.parse('containous/traefik')
>>> ref.split_hostname()
('containous', 'traefik')

When parsing images with both a / and a :, split_hostname() returns the wrong hostname.

Example:

>>> from docker_image.reference import Reference
>>> Reference.parse_normalized_named("bitnami/minideb:buster").split_hostname()
('bitnami', 'minideb')
# Expected:
# ('docker.io', 'bitnami/minideb')

Leaving out the tag, split_hostname works as expected:

>>> Reference.parse_normalized_named("bitnami/minideb").split_hostname()
('docker.io', 'bitnami/minideb')