reactiveui / camelotia Goto Github PK

Storing tokens locally will definitely improve the UX.

Implementation Details

We could use Akavache to implement this feature. Akavache is an asynchronous, persistent key-value store that works on all platforms, including Windows, Android, iOS, Linux, OSX (without any need to take care of creating database files, choosing secure paths to store tokens, etc. really a great library)

Task List

• Add Akavache package to Camelotia.Services project
• Create an IStringCache interface with Write and Read methods
• Create AkavacheStringCache class that implements IStringCache
• Write integrational tests for the cache
• Inject the cache into file providers and reuse

Hi @worldbeater I make contributions to open source projects in my spare time by designing logos. For this project I have a functional and minimalist idea in my mind. I'd like to show it to you if you let me. What do you think?

http=>https

Github providers doesn't support two-factory authentication.
Tested on 897fb96 master with Avalonia host.

Describe the bug 🐞

Tried to build UWP app.
Build failed, due to
XDG0008 The name "DirectAuthView" does not exist in the namespace "using:Camelotia.Presentation.Uwp.Views". Camelotia.Presentation.Uwp D:\Downloads\Camelotia-main (2)\Camelotia-main\src\Camelotia.Presentation.Uwp\Views\AuthView.xam
The 'missing' files do exist, and they all render properly in Visual Studio 22.
The Avalonia and WPF example work without any issue.

Step to reproduce

Downloaded the example
Tried to build

Reproduction repository

https://github.com/reactiveui/ReactiveUI

Expected behavior

App should build, and display

Screenshots 🖼️

IDE

Visual Studio 2022

Operating system

Windows 11

Version

No response

Device

No response

ReactiveUI Version

No response

Additional information ℹ️

No response

It's not convenient to download the package

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• chore(deps): update dependency fluentftp to v37.1.2
• chore(deps): update dependency google.apis.drive.v3 to v1.67.0.3373
• chore(deps): update dependency materialdesigncolors to v2.1.4
• chore(deps): update dependency materialdesignthemes to v4.9.0
• chore(deps): update dependency materialdesignthemes.mahapps to v0.3.0
• chore(deps): update dependency microsoft.net.test.sdk to v17.9.0
• chore(deps): update dependency nuke.common to v6.3.0
• chore(deps): update dependency reactivemarbles.observableevents.sourcegenerator to v1.3.1
• chore(deps): update dependency reactiveui to v18.4.44
• chore(deps): update dependency reactiveui.fody to v18.4.44
• chore(deps): update dependency reactiveui.uwp to v18.4.1
• chore(deps): update dependency reactiveui.validation to v3.1.7
• chore(deps): update dependency reactiveui.wpf to v18.4.44
• chore(deps): update dependency reactiveui.xamforms to v18.4.44
• chore(deps): update dependency roslynator.analyzers to v4.12.1
• chore(deps): update dependency vknet to v1.78.0
• chore(deps): update dependency xamlnamereferencegenerator to v1.6.1
• chore(deps): update xunit-dotnet monorepo (xunit, xunit.runner.visualstudio)
• chore(deps): update dependency avalonia.desktop to v11
• chore(deps): update dependency avalonia.diagnostics to v11
• chore(deps): update dependency avalonia.reactiveui to v11
• chore(deps): update dependency citrus.avalonia to v2
• chore(deps): update dependency coverlet.msbuild to v6
• chore(deps): update dependency fluentftp to v50
• chore(deps): update dependency materialdesigncolors to v3
• chore(deps): update dependency materialdesignthemes to v5
• chore(deps): update dependency materialdesignthemes.mahapps to v1
• chore(deps): update dependency nsubstitute to v5
• chore(deps): update dependency nuke.common to v8
• chore(deps): update dependency octokit to v11
• chore(deps): update dependency reactiveui to v19
• chore(deps): update dependency reactiveui.fody to v19
• chore(deps): update dependency reactiveui.wpf to v19
• chore(deps): update dependency reactiveui.xamforms to v19
• chore(deps): update dependency ssh.net to v2024
• chore(deps): update dependency system.reactive to v6
• chore(deps): update dessant/lock-threads action to v5
• 🔐 Create all rate-limited PRs at once 🔐

Pending Status Checks

These updates await pending status checks. To force their creation now, click the checkbox below.

• chore(deps): update dependency akavache to v10

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update dependency avalonia.desktop to v0.10.22
• chore(deps): update dependency avalonia.diagnostics to v0.10.22
• chore(deps): update dependency avalonia.reactiveui to v0.10.22
• chore(deps): update dependency mahapps.metro to v2.4.10
• chore(deps): update dependency octokit to v3.0.1
• chore(deps): update dependency stylecop.analyzers to v1.2.0-beta.556
• chore(deps): update dependency xamarin.forms to v5.0.0.2662
• chore(deps): update dependency akavache to v9.1.20
• chore(deps): update dependency coverlet.msbuild to v3.2.0
• chore(deps): update dependency fluentassertions to v6.12.0
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Adding Yandex Disk file system provider will make the application useful for people who store their files on Yandex Disk. They should be able to easily upload, download, rename and delete files hosted on Yandex servers.

Implementation Details

File browser could be implemented using Refit library to generate REST API clients for Yandex Disk API. A default .NET HTTPListener could be used to receive access code from Yandex OAuth API.

Task List

• Use HTTP Listener and OAuth protocol to authenticate users on Yandex
• Create file browser using Yandex REST API
• Implement Download functionality
• Implement Upload functionality

Avalonia client
Google - The OAuth client was deleted.
Yandex - First OAuth not found,
next - Failed to listen on prefix 'http://127.0.0.1:3000/' because it conflicts with an exiting registration on the machine

Stacktrace:

at System.IO.DriveInfo.get_AvailableFreeSpace()
at Camelotia.Services.Providers.LocalFileSystemProvider.<>c.b__29_0(DriveInfo x) in C:\Users\maxka\Source\Repos\Camelotia\Camelotia.Services\Providers\LocalFileSystemProvider.cs:line 116
at System.Linq.Enumerable.WhereSelectArrayIterator2.MoveNext() at System.Linq.Enumerable.Sum(IEnumerable1 source)
at Camelotia.Services.Providers.LocalFileSystemProvider.GetSizeOnAllDisks() in C:\Users\maxka\Source\Repos\Camelotia\Camelotia.Services\Providers\LocalFileSystemProvider.cs:line 115
at Camelotia.Services.Providers.LocalFileSystemProvider.get_Size() in C:\Users\maxka\Source\Repos\Camelotia\Camelotia.Services\Providers\LocalFileSystemProvider.cs:line 14
at Camelotia.Presentation.ViewModels.ProviderViewModel.get_Size() in C:\Users\maxka\Source\Repos\Camelotia\Camelotia.Presentation\ViewModels\ProviderViewModel.cs:line 281

Current output of Local file system that is displayed on the interface is confusing. The initial view of the file system should be of the Drives, then when drilling down through the drives the drive content should then be displayed. If there is only one drive then the root contents of that drive should be shown. This would allow removable devices to be displayed if present as well.

The current implementation starts with:

_refresh = ReactiveCommand.CreateFromTask( () => provider.Get(CurrentPath), outputScheduler: mainThread);
CurrentPath is null at start and when Get is called on the local provider it passes in "\" So the view output consists entirely of the drive that the app is run from. This excludes other drives.

I suggest that if the initial path is null, we convert that to get the drives and display those. Then when drilling down it can be from any drive. We can also look at allowing a CD/DVD drive if it is available and not exclude it entirely like I did to get rid of the exception. When I implemented that there was no way to view the drive anyway so excluding it to avoid the exception seemed like a valid solution.

This suggestion is entirely contained in the local system provider as I am not sure if the other providers would have a concept of multiple drives, and if they did the implementation would be different anyway.

Let me know if you would like this and I will provide and implementation to it that you can review.
Greg