Comments (7)
Better close this if an IP address is not allowed as per PR comment. We will fork plugin to obey European laws.
from api-plugin-orders.
Well my comment was meant that the correct path would be to add any additional fields you need in a custom plugin that extends the schema not a fork of this one. Will that not work?
from api-plugin-orders.
Would work, however the order plugin already handles names address phone number. So the logic is beyond my comprehension. Specially since it is a legal requirement.
from api-plugin-orders.
Generally I think our approach with fields would not be to try and have every field that everyone might need but the minimum amount of fields that are necessary and an easy way for people to extend with additional fields that are required by their use case
from api-plugin-orders.
Although it might be required in some countries it is not in others, and although it's an optional field sort of making it a sanctioned field while the legal ramifications are not well understood doesn't seem like a good idea when there is a clear and easy path to adding it through extension where each implementation can make sure the data has been properly T&C'd.
If someone can make a clear case there there are no countries where this would ever cause any unwanted PII ramifications I would love to make this change and reopen this issue as I agree that this would be a very handy field to have that a lot of people could benefit from.
from api-plugin-orders.
The difference with name and address is that those are given freely, whereas IP address is taken silently without the users consent.
from api-plugin-orders.
Yes, but at a point where the user is placing an order.
By placing an order you should have to accept the websites privacy policy.
However collecting IP is law and has nothing to do with consent.
Please tell me which countries do not have this law, since some hacker friends might like to order stuff there.
Github itself complies:
Please note that GitHub may collect User Personal Information from visitors to your GitHub Pages website, including logs of visitor IP addresses, to comply with legal obligations, and to maintain the security and integrity of the Website and the Service.
from api-plugin-orders.
Related Issues (10)
- add peerDependency for account plugin
- Generate and send RMA and return instructions to customer HOT 6
- add peerDependency for account-validation plugin
- Add some account fields to order HOT 1
- Possibly change how we do factories for tests
- add peerDependency for Tags plugin
- Order has status "new" and primary shop owner can nothing to do with it HOT 1
- Shop owners should be able to configure order processing time
- Order Followup
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from api-plugin-orders.