react-native-progress-view / progress-view Goto Github PK

View Code? Open in Web Editor NEW

157.0 157.0 40.0 3.41 MB

ProgressView Component for react-native iOS/macOS/Windows

License: MIT License

Java 9.91% JavaScript 43.36% Objective-C 7.69% Ruby 3.87% C++ 25.03% C 0.81% Objective-C++ 9.33%

hacktoberfest ios macos progress-bar react-native windows

progress-view's People

Contributors

Stargazers

Watchers

progress-view's Issues

Add CI for macOS

add workflow in CI to test build for macOS

RN 0.72.3 + fabric enabled => RNCProgressViewComponentDescriptors.h file not found ?

I just freshly installed @react-native-community/progress-view on my RN 0.72.3 project with fabric enabled.

Trying to build the project in XCode now fails with error: node_modules/@react-native-community/progress-view/ios/Fabric/RNCProgressViewComponentView.mm:6:9 'react/renderer/components/progressview/RNCProgressViewComponentDescriptors.h' file not found

Anyone getting this too?

Is this package still running actively?

If maintainers have no intentions to run this package Please let us know. So that we can look for alternative

"RNCProgressView" was not found

Invariant Violation: requireNativeComponent: "RNCProgressView" was not found in the UIManager.

version:
"@react-native-community/progress-view": "^1.2.3",
"react": "16.13.1",
"react-native": "0.63.2",

npm package not published

Feature Request

It seems like @react-native-community/react-native-progress-view is not published as an npm package yet.

ENV['RCT_NEW_ARCH_ENABLED'] == '1'

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @react-native-community/[email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/@react-native-community/progress-view/react-native-progress-view.podspec b/node_modules/@react-native-community/progress-view/react-native-progress-view.podspec
index 7580b30..3ddce84 100644
--- a/node_modules/@react-native-community/progress-view/react-native-progress-view.podspec
+++ b/node_modules/@react-native-community/progress-view/react-native-progress-view.podspec
@@ -1,6 +1,6 @@
 require 'json'
 
-fabric_enabled = ENV['RCT_NEW_ARCH_ENABLED']
+fabric_enabled = ENV['RCT_NEW_ARCH_ENABLED'] == '1'
 
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))

This issue body was partially generated by patch-package.

As mentioned by #109 (comment)

React Native 0.71 support

Attempting pod install on RN 0.71, I get the error:

[!] Unable to find a specification for `React-RCTFabric` depended upon by `react-native-progress-view/fabric`

You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.

Trying the recommended pod repo update and pod install --repo-update do not resolve the issue.

Library version: 1.4.0-beta.0, hermes, old architecture.

Support new React Native new architecture (TurboModules/Fabric)

See https://reactnative.dev/docs/new-architecture-library-intro

https://reactnative.dev/blog/2022/06/16/resources-migrating-your-react-native-library-to-the-new-architecture

Example app is outdated/broken for Windows

Current Steps to run Example App on Windows


1. Clone branch
2. cd into progress_view and run yarn install
3. run yarn add [email protected] --dev (React Native Windows relies on a version of react-native lower than iOS)
4. Start metro server with yarn start:windows
5. Open Visual Studios and open example/windows/ProgressViewExample.sln
6. Set to Debug x64 and start solution

Issues

Looks like the example app needs some work on the windows side. Currently following the steps gives the error Cannot find module 'metro/src/lib/polyfills/require.js' when running yarn start:windows.

I'm also unclear if we still need yarn add [email protected] --dev to run the example app since React Native Windows has since upgraded to 0.66.

-Thanks! :)

[Help needed] How to make a slopped progress bar view

I was trying to make something like this. Is there anyway i can make something like this using this module?

Build with windows

I'm trying to build my app for windows, but I keep getting the following error:

    12>c1xx : fatal error C1083: Datei (Quelle) kann nicht geöffnet werden: "Generated Files\module.g.cpp": No such file or directory [C:\repositories\servicecaseapp\node_modules\@react-native-community\progres
       s-view\windows\progress-view\progress-view.vcxproj]
         ProgressViewViewManager.cpp
         ProgressViewView.cpp
         ReactPackageProvider.cpp
    12>C:\repositories\servicecaseapp\node_modules\@react-native-community\progress-view\windows\progress-view\ReactPackageProvider.h(2,10): fatal error C1083: Datei (Include) kann nicht geöffnet werden: "React
       PackageProvider.g.h": No such file or directory (Quelldatei wird kompiliert ReactPackageProvider.cpp) [C:\repositories\servicecaseapp\node_modules\@react-native-community\progress-view\windows\progress-v
       iew\progress-view.vcxproj]
    10>ClCompile:
         module.g.cpp
         JSValue.cpp
    12>C:\repositories\servicecaseapp\node_modules\@react-native-community\progress-view\windows\progress-view\ProgressViewView.h(6,10): fatal error C1083: Datei (Include) kann nicht geöffnet werden: "ProgressV
       iewView.g.h": No such file or directory (Quelldatei wird kompiliert ProgressViewView.cpp) [C:\repositories\servicecaseapp\node_modules\@react-native-community\progress-view\windows\progress-view\progress
       -view.vcxproj]
    12>C:\repositories\servicecaseapp\node_modules\@react-native-community\progress-view\windows\progress-view\ProgressViewView.h(6,10): fatal error C1083: Datei (Include) kann nicht geöffnet werden: "ProgressV
       iewView.g.h": No such file or directory (Quelldatei wird kompiliert ProgressViewViewManager.cpp) [C:\repositories\servicecaseapp\node_modules\@react-native-community\progress-view\windows\progress-view\p
       rogress-view.vcxproj]
       ClCompile:
         JSValueTreeReader.cpp
    12>C:\Program Files (x86)\Windows Kits\10\bin\10.0.18362.0\XamlCompiler\Microsoft.Windows.UI.Xaml.Common.targets(482,5): error MSB4181: Die Aufgabe "CompileXaml" hat FALSE zurückgegeben, jedoch keinen Fehle
       r protokolliert. [C:\repositories\servicecaseapp\node_modules\@react-native-community\progress-view\windows\progress-view\progress-view.vcxproj]

Versions:
progress-view: 1.2.3
react-native-windows: 0.63.6
react-native: 0.63.3

tvOS support?

When we were using the one from React Native, it also worked on tvOS, that doesn't seem to be the case for this version. Atleast, I can't get it to work so far it seems.. Is my assumption correct that tvOS isn't supported? And if so; are there plans to (re)add tvOS support for this component?

Thanks in advance!

Module not found: Can't resolve './ProgressView'

Hi I am trying to use this component in an Expo (3.25.0) project.
I have installed using npm install

npm install @react-native-community/progress-view --save

I am getting the below error when running ... any help appreciated

Module not found: Can't resolve './ProgressView'

Incorrect runtime dependency on babel@6

Bug report

Summary

Version 1.1.1 of module has incorrect runtime dependency on babel@6 and babel-runtime@6: package.json

This module should not declare runtime dependency on babeb at all, metro bundler will correctly process module code anyway.

Environment info

Library version: 1.1.1

Steps to reproduce

Not applicable

Reproducible sample code

Not applicable

Version Sdk 21

My app works on version 16 and now all versions are SDK 21. How can I solve this without having to upload my version?

Take buildToolsVersion and compileSdkVersion from root project

Description

When using this lib and building for android, a warning is shown due to hardcoded buildToolsVersion version in build.gradle#L16 clashing with newer Android Gradle Plugin.

What is the current behavior?

When building I get the following:

WARNING:: The specified Android SDK Build Tools version (29.0.3) is ignored, as it is below the minimum supported version (30.0.2) for Android Gradle Plugin 4.2.1.
Android SDK Build Tools 30.0.2 will be used.
To suppress this warning, remove "buildToolsVersion '29.0.3'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.
WARNING:: The specified Android SDK Build Tools version (29.0.3) is ignored, as it is below the minimum supported version (30.0.2) for Android Gradle Plugin 4.2.1.
Android SDK Build Tools 30.0.2 will be used.
To suppress this warning, remove "buildToolsVersion '29.0.3'" from your build.gradle file, as each version of the Android Gradle Plugin now has a default version of the build tools.

What is the expected behavior?

No warnings show up and outer config is respected.

What have you tried?

I tried applying the safeExtGet approach that many libs use via patch-package and it solved my problems.

What it boils down to:

def safeExtGet(prop, fallback) {
    rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

android {
    compileSdkVersion safeExtGet("compileSdkVersion", 30)
    buildToolsVersion safeExtGet("buildToolsVersion", "29.0.3")

    defaultConfig {
        minSdkVersion 21
        targetSdkVersion safeExtGet("targetSdkVersion", 30)
        // ...
    }
}

This way the outside config takes precedence, but the old value is still kept as a fallback.

Version info

@react-native-community/progress-view: 1.3.1
react-native: 0.65.1

Setup CircleCI

Feature Request

This repo does not have CircleCI setup yet.

Why it is needed

To verify that pull request does not break lint/test/types/etc.

Possible implementation

See the .circleci folder in other community repositories, such as https://github.com/react-native-community/react-native-progress-bar-android/tree/master/.circleci

Code sample

Fix Windows CI

Updated:

I'd like to add cd example && yarn windows to ci and make sure it runs correctly

Android release build assembling fails with [email protected]

Bug

Android release build fails with [email protected]

Environment info

react-native info output:

System:
    OS: macOS 10.15.4
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 509.36 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 12.16.2 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.4 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 23, 25, 26, 27, 28, 29
      Build Tools: 27.0.3, 28.0.3, 29.0.3
      System Images: android-24 | Google Play Intel x86 Atom, android-25 | Google APIs Intel x86 Atom, android-26 | Google APIs Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 3.6 AI-192.7142.36.36.6308749
    Xcode: 11.4.1/11E503a - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_252 - /usr/bin/javac
    Python: 2.7.16 - /usr/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.11.0 => 16.11.0 
    react-native: 0.62.2 => 0.62.2 
  npmGlobalPackages:
    *react-native*: Not Found

Library version: 1.0.2

Steps To Reproduce

Generate fresh react-native empty project
Install react-native-community/progress-view library
Run assembling release android build (build-tools v29.0.3, android 29)

Describe what you expected to happen:

Release android build is assembled successfully

Error log

2: Task failed with an exception.
 
-----------
 
* What went wrong:
 
Execution failed for task ':react-native-community_progress-view:verifyReleaseResources'.
 
> A failure occurred while executing com.android.build.gradle.internal.tasks.Workers$ActionFacade
 
   > Android resource linking failed
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/a57f657f9eb12bd95b25a6d72d815ff5/appcompat-1.0.2/res/values-v26/values-v26.xml:5:5-8:13: AAPT: error: resource android:attr/colorError not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/a57f657f9eb12bd95b25a6d72d815ff5/appcompat-1.0.2/res/values-v26/values-v26.xml:9:5-12:13: AAPT: error: resource android:attr/colorError not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/a57f657f9eb12bd95b25a6d72d815ff5/appcompat-1.0.2/res/values-v26/values-v26.xml:13:5-16:13: AAPT: error: style attribute 'android:attr/keyboardNavigationCluster' not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/a57f657f9eb12bd95b25a6d72d815ff5/appcompat-1.0.2/res/values-v28/values-v28.xml:5:5-8:13: AAPT: error: resource android:attr/dialogCornerRadius not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/a57f657f9eb12bd95b25a6d72d815ff5/appcompat-1.0.2/res/values-v28/values-v28.xml:9:5-12:13: AAPT: error: resource android:attr/dialogCornerRadius not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/b1035ff6f51c7705ab78936f582a5533/core-1.0.1/res/values/values.xml:57:5-88:25: AAPT: error: resource android:attr/fontStyle not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/b1035ff6f51c7705ab78936f582a5533/core-1.0.1/res/values/values.xml:57:5-88:25: AAPT: error: resource android:attr/font not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/b1035ff6f51c7705ab78936f582a5533/core-1.0.1/res/values/values.xml:57:5-88:25: AAPT: error: resource android:attr/fontWeight not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/b1035ff6f51c7705ab78936f582a5533/core-1.0.1/res/values/values.xml:57:5-88:25: AAPT: error: resource android:attr/fontVariationSettings not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/b1035ff6f51c7705ab78936f582a5533/core-1.0.1/res/values/values.xml:57:5-88:25: AAPT: error: resource android:attr/ttcIndex not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/b1035ff6f51c7705ab78936f582a5533/core-1.0.1/res/values/values.xml:89:5-125:25: AAPT: error: resource android:attr/startX not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/b1035ff6f51c7705ab78936f582a5533/core-1.0.1/res/values/values.xml:89:5-125:25: AAPT: error: resource android:attr/startY not found.
 
         
 
     /Users/distiller/.gradle/caches/transforms-2/files-2.1/b1035ff6f51c7705ab78936f582a5533/core-1.0.1/res/values/values.xml:89:5-125:25: AAPT: error: resource android:attr/endX not found.

Xcode 12 compatibility

Builds on Xcode 12 and above fail due to this library.

The issues seems to be related to this. To fix it we would need to make changes as mentioned here to the podspec,

- s.dependency     'React'
+ s.dependency     'React-Core'

https://github.com/wonday/react-native-pdf/pull/509/files#diff-5faac750e13626b2dc95e4621e009a7130bc2919068cd64ae68beb55e0899344L17-R17

react-native-progress-view / progress-view Goto Github PK

progress-view's People

Contributors

Stargazers

Watchers

Forkers

progress-view's Issues

Feature Request

Current Steps to run Example App on Windows

Issues

Bug report

Summary

Environment info

Steps to reproduce

Reproducible sample code

Description

What is the current behavior?

What is the expected behavior?

What have you tried?

Version info

Feature Request

Why it is needed

Possible implementation

Code sample

Bug

Environment info

Steps To Reproduce

Error log

Recommend Projects

Recommend Topics

Recommend Org