Do not store routing in redux about react-boilerplate-cra-template HOT 4 CLOSED

My opinion is it should be up to users. It might be in the redux, as it also says there, or it might not. Trade-off. I know people want to update their locations with redux actions even though it can be done differently.

One use case I can think of is if you are using location in redux-saga. Feeding the location with action parameters could fail and go stale as redux-saga yields multiple times. Thanks for pointing it out though. I wasn't aware of this suggestion. I am adding it as a comment for everyone to decide on their own

from react-boilerplate-cra-template.

I ve had a change of heart :) . We don't need it in the boilerplate. I will remove it and put it on example repos for people who wanna enable it

from react-boilerplate-cra-template.

That was fast! Awesome.

from react-boilerplate-cra-template.

I don't agree with this change; here's a few reasons why:

1. having to continuously pass this information in a payload to sagas is a pain; instead using the router selector makes for an easier time
2. not every instance of an action will have access to history; if I'm dispatching from a socket connection, I now have no way of seeing the current route and executing redirects/actions based on the route
3. accessing the current route parameters for global validation (think of something like activeProductId) now gets offloaded to a component to then have to dispatch actions to the global state to ultimately do what a single selector was doing before
4. debugging now becomes a pain; it's easy to look at the redux store and determine what happened and what redirects occurred before something unexpected. Now I have to set breakpoints or console log and those feel like terrible alternatives

Please reconsider this change @Can-Sahin

from react-boilerplate-cra-template.