Git Product home page Git Product logo

Comments (6)

Can-Sahin avatar Can-Sahin commented on May 22, 2024

I dont follow much. Utils and App folders are tightly coupled. There was never a case you need to modify just one without touching other. What good would it do to make them separate packages? Configs and lint prettier etc they hardly ever change anyway.

It can be never easy to just 'upgrade' to new version, sorry I have given lot of thoughts about it and still no good trade-off.

A monorepo would be way harder to maintain and keep it simple.

from react-boilerplate-cra-template.

sabarnix avatar sabarnix commented on May 22, 2024

I will try to share a PR by this week

from react-boilerplate-cra-template.

sabarnix avatar sabarnix commented on May 22, 2024

@Can-Sahin this is still WIP. https://github.com/sabarnix/react-boilerplate-cra-template/tree/wip. See if you like the idea.

from react-boilerplate-cra-template.

Can-Sahin avatar Can-Sahin commented on May 22, 2024

thanks will check it out.

from react-boilerplate-cra-template.

Can-Sahin avatar Can-Sahin commented on May 22, 2024

Ok I checked it and its pretty much what I imagined at first. But still struggling to understand how helpful would this be?

  • dotfiles folder almost NEVER change. The last change was probably 2 years ago.
  • internals file will be updated mostly 80% of the time when template folder is updated. Starting templates and generators are directly targeting the real app so its highly coupled. Meaning, almost all the releases will have 2 release with first template package and then internals package.

This monorepo would only come handy when doing version bumps for template package because you cant just bump the version of react there and dont touch other packages.

I like the idea actually but I feel like the components of the boilerplate is all together single unit of work. There are not really independent pieces isolated from others. I have several future plans like switching to redux toolkit query and ditching redux-saga etc but considering those with this monorepo approach I have to 3 releases (each package) and it would even complicate things for everybody willing to update

from react-boilerplate-cra-template.

sabarnix avatar sabarnix commented on May 22, 2024

After doing some more research I found that, since react-boilerplate is tied to cra, the current implementation is probably the best suited for most uses.

In my case, I maintain a lot of apps created form the react-boilerplate which has some modifications like some uses rtk-query, some only redux and few uses typescript. My goal is to maintain the dotfiles for all projects in a repo and have different versions of generators. I will continue to work on the fork for my projects. I am also exploring razzle which might be better suited for my need. Will work on creating a react-boilerplate like setup for razzle.

regarding switching to redux toolkit query, it is great but only when your project is simple fetch and show data. When things gets complicated I feel the code becomes more complex as you have to do more in transform response to store in normalised form. For which I think it is better to use just the redux toolkit.

from react-boilerplate-cra-template.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.