Comments (3)
rdp
commented on August 16, 2024
this is a bug in GetMediaType?
…On Tue, Jan 31, 2023 at 7:51 PM yin kaisheng ***@***.***> wrote:
the following code outputs:
Camera capability 0, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kRGB32, rateControl:0
Camera capability 1, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kRGB32, rateControl:0
Camera capability 2, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kRGB32, rateControl:0
Camera capability 3, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kRGB32, rateControl:0
Camera capability 4, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kRGB32, rateControl:0
Camera capability 5, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kRGB32, rateControl:0
Camera capability 6, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kI420, rateControl:0
----
Camera capability 0, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kI420, rateControl:0
Camera capability 1, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kI420, rateControl:0
Camera capability 2, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kI420, rateControl:0
Camera capability 3, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kI420, rateControl:0
Camera capability 4, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kI420, rateControl:0
Camera capability 5, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kI420, rateControl:0
Camera capability 6, VideoInfo1, size:2560 x 1440, fps:30, video sub type:kI420, rateControl:0
ComPtr<IAMStreamConfig> streamConfig;
hr = outputPin->QueryInterface(IID_IAMStreamConfig, (void**)&streamConfig);
AM_MEDIA_TYPE* pmt = nullptr;
VIDEO_STREAM_CONFIG_CAPS caps;int count = 0;int size = 0;
hr = streamConfig->GetNumberOfCapabilities(&count, &size);
int enumTimes = 2;for (int n = 0; n < enumTimes; ++n)
{
for (int index = 0; index < count; ++index)
{
hr = streamConfig->GetStreamCaps(index, &pmt, reinterpret_cast<BYTE*>(&caps));
//print pmt properties;
}
printf("\n----\n");
}
In CPushPinDesktop::GetMediaType, pmt->Subtype() is always I420
(!=GUID_NULL) after enumerating once, pmt->SetSubType is never called.
HRESULT CPushPinDesktop::GetMediaType(int iPosition, CMediaType *pmt) // AM_MEDIA_TYPE basically == CMediaType
{
//...
if (*pmt->Subtype() == GUID_NULL) {
const GUID SubTypeGUID = GetBitmapSubtype(&pvi->bmiHeader);
pmt->SetSubtype(&SubTypeGUID);
}
}
if I change the code to the following, then IAMStreamConfig::GetStreamCaps
will get correct result when enumerating twice.
HRESULT CPushPinDesktop::GetMediaType(int iPosition, CMediaType *pmt) // AM_MEDIA_TYPE basically == CMediaType
{
//...
if (iPosition < 6) {
const GUID SubTypeGUID = GetBitmapSubtype(&pvi->bmiHeader);
pmt->SetSubtype(&SubTypeGUID);
}
}
—
Reply to this email directly, view it on GitHub
<#162>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADBUC2C6ABGYUF5OT4NVTWVHFSVANCNFSM6AAAAAAUNFPJM4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
from screen-capture-recorder-to-video-windows-free.
yinkaisheng
commented on August 16, 2024
Yes, when app calls streamConfig->GetStreamCaps with index 0,... 6, CPushPinDesktop::GetStreamCaps will be called.
m_mt's Subtype is set and is not GUID_NULL anymore, SubType is I420 when the last index is 6.
If app calls streamConfig->GetStreamCaps with index 0,... 6 again, pmt->SetSubtype is never called because *pmt->Subtype() != GUID_NULL, the SubType in pmt that app gets is always I420。
HRESULT STDMETHODCALLTYPE CPushPinDesktop::GetStreamCaps(int iIndex, AM_MEDIA_TYPE **pmt, BYTE *pSCC)
{
CAutoLock cAutoLock(m_pFilter->pStateLock());
HRESULT hr = GetMediaType(iIndex, &m_mt); // setup then re-use m_mt ... why not?
...
*pmt = CreateMediaType(&m_mt);
}
HRESULT CPushPinDesktop::GetMediaType(int iPosition, CMediaType *pmt) // AM_MEDIA_TYPE basically == CMediaType
{
//...
if (*pmt->Subtype() == GUID_NULL) {
const GUID SubTypeGUID = GetBitmapSubtype(&pvi->bmiHeader);
pmt->SetSubtype(&SubTypeGUID);
}
}
from screen-capture-recorder-to-video-windows-free.
rdp
commented on August 16, 2024
Check it, see if it works for you...
from screen-capture-recorder-to-video-windows-free.
Related Issues (20)
- Stopped working HOT 3
- cannot display select window HOT 2
- Windows Graphics Capture API
- Can you use this tool with Media Foundation? HOT 1
- Why save settings to the registry instead of a config file? HOT 1
- How can I separate the audio tracks and also change the container back to mp4? HOT 2
- Sound capture config unavailable if USB headphones are plugged in
- doesn't exit right if options pane closed weird
- As soon as I click Start! it stops immediately. HOT 1
- Can't load audio device HOT 6
- source code files are tab/space mixed indent, could I fix this? HOT 2
- wants better default save to dir
- typo or bug:
- Screen capture recorder don't works in win 11. If i press start also stop became not clickable HOT 5
- uninstall HOT 2
- Unable to use dshow devices with gdigrab/ddagrab anymore HOT 17
- Windows 10 Chinese character GKB problem HOT 3
- Timecode in MP4 or MKV isn't working
- I would like to add a field in the UI
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from screen-capture-recorder-to-video-windows-free.