RcppArmadillo sp_mat doesn't interpret Sparse Symmetric Matrix correctly about rcpparmadillo HOT 14 CLOSED

FYI:

Sparse support was just added today for...

• symmatu() / symmatl() in conradsnicta/armadillo-code@d99b824
• trimatu()/trimatl() in conradsnicta/armadillo-code@f294d3b

from rcpparmadillo.

This seems very similar to #17 .

I will take a look in the weekend.

from rcpparmadillo.

Thanks for the bug report, and for bringing it here. I will try to take a look.

I think the overarching issue may be that we have a larger number of possibly representations in the Matrix package than are currently handled by the converters. So it will require someone to sit down and write those.

from rcpparmadillo.

I was thinking using symmatu() / symmatl() to handle the symmetric matrix. However, it only works on arma::mat not arma::sp_mat.

More complicated than I thought.

from rcpparmadillo.

WOW~!

Let's complete GSOC project idea!

from rcpparmadillo.

@conradsnicta being Conrad, I am of course prohibited from following the repo. #facepalm

from rcpparmadillo.

You can prohibit someone from following a repo?

from rcpparmadillo.

Apparently. Looks like you snug in before he changes that setting.

from rcpparmadillo.

Great, it looks like it exists in the upstream Armadillo project, but if I understand correctly there is no wrapping in Rcpp?

from rcpparmadillo.

Should be coming over the summer according to the GSOC project:

https://github.com/rstats-gsoc/gsoc2017/wiki/Sparse-matrix-automatic-conversion-in-RcppArmadillo

from rcpparmadillo.

Slowly, young man. Having file a GSoC proposal is not the same as getting it accepted after which it may still not get done right ...

from rcpparmadillo.

The support for symmetric numeric sparse matrices inherited from CsparseMatrix, TsparseMatrix & RsparseMatrix has been added. You are welcomed to use it and report possible bugs when the newest package is released. @jeffwong-nflx If you have need to use logical sparse matrices, could please give me some examples of their applications?

from rcpparmadillo.

@binxiangni Given your PRs in master, can we close this?

from rcpparmadillo.

I believe so.

from rcpparmadillo.