Git Product home page Git Product logo

Comments (9)

CeleritasCelery avatar CeleritasCelery commented on July 24, 2024 2

thanks for looking into it

from bash-preexec.

d630 avatar d630 commented on July 24, 2024

Maybe you can define a preexec function with something like echo "$BASH_COMMAND" to see what is beeing executed by "edit-and-execute-command".

I get the follwowing:

fc -e "${VISUAL:-${EDITOR:-$(command -v editor || echo emacs)}}"
/usr/bin/vim /run/user/1000/tmp/bash-fc.IUxsw9

Edit:
Or just use set -v

from bash-preexec.

CeleritasCelery avatar CeleritasCelery commented on July 24, 2024

when I use set -v I get and try the command echo foo

fc -e "${VISUAL:-${EDITOR:-emacs}}"
__bp_preexec_invoke_exec
vim /tmp/bash-fc-9053782316985282392
__bp_preexec_invoke_exec
echo foo
__bp_preexec_invoke_exec
foo

Does it not inject the function into the output for you?

from bash-preexec.

rcaloras avatar rcaloras commented on July 24, 2024

@CeleritasCelery Yes. I'm getting the same output as in your firsst example. Wondering what's causing it in bash-preexec.

from bash-preexec.

dschep avatar dschep commented on July 24, 2024

I've noticed this behavior for a while but I just ignore it 😛

from bash-preexec.

rcaloras avatar rcaloras commented on July 24, 2024

I'm not positive there's anything that can be done about this since bash-preexec relies on bash's DEBUG trap.

Even setting a no-op here for the trap will be echoed out. Using your example from above @CeleritasCelery e.g.

$ trap -- ':' DEBUG
Ctrl-x Ctrl-e
echo foo
:
foo

from bash-preexec.

rcaloras avatar rcaloras commented on July 24, 2024

@CeleritasCelery unfortunately this is a product of using the DEBUG trap which is pretty much a must.
@d630 any idea why edit and execute pulls in the contents of the trap?

from bash-preexec.

d630 avatar d630 commented on July 24, 2024

@rcaloras It's not because of Readline's "edit-and-execute-command", it's due to fc, that
sets the verbose flag before executing the file. See
http://git.savannah.gnu.org/cgit/bash.git/tree/builtins/fc.def?h=devel

I suppose you can avoid it, if you bind your own "edit-and-execute-command" ...

Edit:
See also http://git.savannah.gnu.org/cgit/bash.git/tree/bashline.c?h=devel

from bash-preexec.

rcaloras avatar rcaloras commented on July 24, 2024

@d630 Thanks! Looking back at your previous comment more closely makes sense now 👍
@CeleritasCelery Sorry for the verbose output, but closing this as this is intended functionality by edit and execute.

from bash-preexec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.