Comments (2)
bash-preexec
doesn't support the case where PROMPT_COMMAND
is modified after the shell startup and the first prompt. However, Midnight Commander installs its hook by directly inputting PROMPT_COMMAND+=...
, etc. as user commands from stdin after starting the shell.
More specifically, bash-preexec
requires that all the other PROMPT_COMMAND
hooks are enclosed between __bp_precmd_invoke_cmd
and __bp_interactive_mode
. This is normally achieved through the initial DEBUG
trap (__bp_install
) installed by bash-preexec
. However, Midnight Commander injects codes after the shell startup and modifies PROMPT_COMMAND
. This results in the following value of PROMPT_COMMAND
:
$ declare -p PROMPT_COMMAND
declare -- PROMPT_COMMAND=$'__bp_precmd_invoke_cmd\n__bp_interactive_mode\npwd>&11;kill -STOP $$'
The substring pwd>&11;kill -STOP $$
is the hook installed by mc
. We can see that the mc
hook string is not enclosed within __bp_precmd_invoke_cmd
and __bp_interactive_mode
. Instead, this should look like the following:
PROMPT_COMMAND=$'__bp_precmd_invoke_cmd\npwd>&11;kill -STOP $$\n__bp_interactive_mode'
I'm not sure if there is a solution at the user side.
from bash-preexec.
Thanks, this info is enough for me.
After patching subshell/common.c
in the mc
sources it works like a charm!
--- common.c 2023-03-06 13:14:44.536493089 +0100
+++ common.c.patched 2023-03-06 13:13:51.448906309 +0100
@@ -825,7 +825,7 @@
{
case SHELL_BASH:
g_snprintf (precmd, buff_size,
- " PROMPT_COMMAND=${PROMPT_COMMAND:+$PROMPT_COMMAND\n}'pwd>&%d;kill -STOP $$'\n"
+ " PROMPT_COMMAND='__bp_precmd_invoke_cmd\npwd>&%d;kill -STOP $$\n__bp_interactive_mode'\n"
"PS1='\\u@\\h:\\w\\$ '\n", subshell_pipe[WRITE]);
break;
from bash-preexec.
Related Issues (20)
- Preexec is called when exiting bash with Ctrl-D HOT 2
- Return immediately when running in Zsh HOT 3
- [Bug] HISTCONTROL ignore* setting should be respected HOT 7
- `__bp_preexec_invoke_exec "$_"` printed when running multiple commads
- Tests fail with bats 1.5.0 HOT 7
- official way to detect whether bash-preexec is loaded HOT 2
- Line number exit outpu command ? HOT 1
- Bash 5.1 supports making PROMPT_COMMAND an array HOT 5
- ShellCheck highlights several issues with the file - Shellcheck could be disabled, or issues resolved HOT 2
- post_cmd functionality addition HOT 2
- Some tests fail with bats 1.9 HOT 6
- preexec() does not work where as precmd() is working as intended. HOT 1
- Library Authors documentation can still lead to issues HOT 2
- preexec $1 is missing some commands HOT 1
- detailed bash log with preexec and precmd HOT 2
- Not working on Windows using Bash in MSYS2 HOT 7
- preexec doesn't work for no-op command `:`
- `bash-preexec` will cause `hishtory` to be particularly time-consuming for commands including pipeline.
- New release when?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bash-preexec.