Remove subshells and external commands (= sed) about bash-preexec HOT 3 CLOSED

Hey @d630!

Thanks for the contributions, I'll give them a look over the next day and pull them in. What would you say are the major benefits of removing the subshells and sed? Simplicity, portability, speed?

Appreciate it 👍

from bash-preexec.

Hey!

It is unnecessary to use sed, because bash can do the job itself (and in the end even faster). Command substitutions are only necessary, if we do need the output of a command. But in #15 and #16 it is sufficient to work with exit/return status. See also SubShell.

So, the major benefits are simplicity and speed

from bash-preexec.

Thank you for the contributions @d630! Much appreciated. 👍

Would love your feedback or input on my project Bashhub which uses bash-preexec if you're interested.

from bash-preexec.