rc9000 / nd2-worker-plugin-aci Goto Github PK

[3668107] 2024-02-16 18:00:27  info App::Netdisco version 2.072003 loaded.
[3668107] 2024-02-16 18:00:27  info macsuck: [172.27.129.2] started at Fri Feb 16 18:00:27 2024
[3668107] 2024-02-16 18:00:27  info  [172.27.129.2] cisco aci macsuck - fetching data from  https://172.27.129.2:443/api
Redundant argument in sprintf at /home/netdisco/nd2-worker-plugin-aci/lib/App/NetdiscoX/Worker/Plugin/Macsuck/Nodes.pm line 64.
[3668107] 2024-02-16 18:00:30  info  [172.27.129.2] cisco aci macsuck - updating epg participation in device_port
[3668107] 2024-02-16 18:00:30  info macsuck: finished at Fri Feb 16 18:00:30 2024
[3668107] 2024-02-16 18:00:30  info macsuck: status error: Can't call method "make_column_dirty" on an undefined value at /home/netdisco/nd2-worker-plugin-aci/lib/App/NetdiscoX/Worker/Plugin/Macsuck/Nodes.pm line 24.

[516674] 2022-10-25 06:33:48  info App::Netdisco version 2.057008 loaded.
[516674] 2022-10-25 06:33:49  info discover: [10.10.10.10] started at Tue Oct 25 08:33:49 2022
Use of uninitialized value in string eq at /data/netdisco/nd2-worker-plugin-aci/lib/App/NetdiscoX/Worker/Plugin/Discover/Properties.pm line 14.
[516674] 2022-10-25 06:33:49  info  [10.10.10.10] NetdiscoX::Properties - not an ACIController, ignored
[516674] 2022-10-25 06:33:49  info discover: finished at Tue Oct 25 08:33:49 2022
[516674] 2022-10-25 06:33:49  info discover: status info: skip: driver or action not applicable

diff --git a/lib/App/NetdiscoX/Util/ACI.pm b/lib/App/NetdiscoX/Util/ACI.pm
index 15bf3cd..a743f86 100644
--- a/lib/App/NetdiscoX/Util/ACI.pm
+++ b/lib/App/NetdiscoX/Util/ACI.pm
@@ -12,7 +12,7 @@ use URL::Encode ':all';
 use Hash::Merge qw(merge);
 use Moo;
 use namespace::clean;
-
+use Socket;
 
 has port => (
   is  => 'rw',
@@ -31,7 +31,7 @@ has [qw(host user password)] => (
 
 sub url {
   my $self = shift;
-  return "https://" . $self->{host} .  ":" . $self->{port} . "/api";
+  return "https://" . gethostbyaddr(inet_aton($self->{host}), 2) .  ":" . $self->{port} . "/api";
 }
 
 sub nodeinfo {

09:31 <dietmar> Hi, i do not have the config anymore, but that is what i had in use, about the aci user/passwd null values :
09:33 <dietmar> device_auth:
09:33 <dietmar>   - tag: aci_prod
09:33 <dietmar>     driver: netconf
09:33 <dietmar>     only:
09:33 <dietmar>       - 1.1.1.11
09:33 <dietmar>     user: 'read'
09:33 <dietmar>     password: 'read'
09:33 <dietmar>   - tag: aci_switches_prod
09:33 <dietmar>     user: user
09:33 <dietmar>     auth:
09:33 <dietmar>       pass: 'xxxxxx'
09:33 <dietmar>       proto: SHA
09:33 <dietmar>     priv:
09:33 <dietmar>       pass: 'xxxxxx'
09:33 <dietmar>       proto: AES128
09:33 <dietmar>     only:
09:33 <dietmar>       - 1.1.1.21-254
09:33 <dietmar>       - 1.1.1.11

diff --git a/lib/App/NetdiscoX/Util/ACI.pm b/lib/App/NetdiscoX/Util/ACI.pm
index fa73dbe..3241bbf 100644
--- a/lib/App/NetdiscoX/Util/ACI.pm
+++ b/lib/App/NetdiscoX/Util/ACI.pm

@@ -71,15 +72,21 @@ sub read_info_from_json {
 
   my $ts = $tsj->{imdata};
   my @node_records; 
-  my @nodeip_records; 
+  my @nodeip_records;
 
   foreach my $d (@{$resp->{imdata}}){
     my $dn = $d->{fvCEp}->{attributes}->{dn};
     my $mac = $d->{fvCEp}->{attributes}->{mac};
-    my $ip = $d->{fvCEp}->{attributes}->{ip};
+#    my $ip = $d->{fvCEp}->{attributes}->{ip};
     my $vlan = $d->{fvCEp}->{attributes}->{encap} ? $d->{fvCEp}->{attributes}->{encap} : 0;
     $vlan =~ s/vlan-//;
 
+
+    foreach my $child_fvCEp ( @{$d->{fvCEp}->{children}} ) {
+       #       print Dumper($child_fvCEp->{fvIp}->{attributes}->{addr});
+       my $ip = $child_fvCEp->{fvIp}->{attributes}->{addr};
+       next unless $ip;
+
     my @child_tdns = map { $_->{fvRsCEpToPathEp}->{attributes}->{tDn} } @{$d->{fvCEp}->{children}};
     
     foreach my $c (@child_tdns){
@@ -161,7 +168,7 @@ sub read_info_from_json {
       }
     }
   }
-
+  }
   return { nodes => \@node_records, node_ips => \@nodeip_records };
 }