Git Product home page Git Product logo

sregex's People

Contributors

jcgregorio avatar

Watchers

 avatar

sregex's Issues

sres() y// can miss empty matches

HL7 messages often include empty fields, so have consecutive field separators, 
such as "||". A simplified example:

>>> 
list(sres("MSH|^~\&|XY|YZ|||20130821235952|1234567890|DFT^P03|316387|P|2.3||||||
|||", "y/\|/"))

The from_y() function gets confused by the consecutive '|' seperation 
characters and returns this list:
['MSH', '^~\\&', 'XY', 'YZ', '|', '20130821235952', '1234567890', 'DFT^P03', 
'316387', 'P', '2.3', '|', '|', '|', '|', '\n']

Instead, I expect it to return all the fields, including the empty ones, 
without any '|' characters, like this: 
['MSH', '^~\\&', 'XY', 'YZ', '', '', '20130821235952', '1234567890', 'DFT^P03', 
'316387', 'P', '2.3', '', '', '', '', '', '', '', '', '\n']

This can be fixed by removing the test for "if mbegin != begin" in the from_y() 
function and instead always calling "yield (begin, mbegin)" and "begin = mend" 
when there is a match.

However, there must have been some specific reason why you put this test in 
there, so I may be missing some other corner case.

Thanks for this excellent package! -Ross 

Original issue reported on code.google.com by [email protected] on 23 Aug 2013 at 5:40

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.