raynos / error Goto Github PK

Hi,

I get the following error TypeError: "name" is read-only related to line 25 extend(createError, args); in file typed.js
.

Can you help me ?

What is the right way to check an err is a ServerError?

var TypedError = require("error/typed")

var ServerError = TypedError({
    type: 'server.5xx',
    message: '{title} server error, status={statusCode}',
    title: null,
    statusCode: null
});

var error = new ServerError({
    title:'some title',
    statusCode: 500
});

error instanceof ServerError // false

or by using err.name, err.type or err.fullType? (what are all these properties for?)

Thanks!

Hi,

Could you provide typescript definitions for your package?
Unfortunately I didn't found community definitions (on DefinitelyTyped/DefinitelyTyped), and I'm not enough skilled to create one (I can try but it would take time :x).

Thanks,

Regards.

So like a lot of projects are on 4.x... I'd like to use wrapped error, added somewhere after 5.?... and why not go to 7.x while I'm at it? Well there's no file to tell me why not, or what to do...

Using typed error and trying to log the error (or anything which causes toString to be called) results in a fatal 'illegal access' error in 0.10.x

willy@localhost:~/sync (willFetch)$ nave use 0.10
already using 0.10.38
willy@localhost:~/sync (willFetch)$ node
> var TypedError = require('error/typed')
undefined
> var Test = TypedError({type:'foo'})
undefined
> var e = Test()
undefined
> e

util.js:329
  return '[' + Error.prototype.toString.call(value) + ']';
                                        ^
illegal access

willy@localhost:~/sync/ (willFetch)$ nave use 0.12
Already installed: 0.12.4
using 0.12.4
willy@localhost:~/sync/ (willFetch)$ node
>  var TypedError = require('error/typed')
undefined
> var Test = TypedError({type:'foo'})
undefined
>  var e = Test()
undefined
> e
{ [FooError] type: 'foo', name: 'FooError', fullType: 'foo' }

Obviously this isn't something which can be fixed, but it's a hard to debug problem, so a warning in the readme would help here.

It would be nice to call an error like so:

class CustomError extends SError {
  static defaultTemplate =  'there was a problem with foo: {foo}'
}

error = CustomError.create({foo: 'bar'})
// => error.message = 'there was a problem with foo: bar'

Having the message template defined with the error seems to separate responsibilities better: the error message knows how to display the error, and the call-site does not need to know that. Seems to me to better design in some cases, by moving more logic to the error object and away from the call-site.

v8 engine support Error.captureStackTrace to shift stacktrace to real place where error created.

Do you accept a PR to add this feature for only node.js/io.js?

Hi,

Could you please add a LICENSE file to this repo. Noticed that the package.json mentions "license": "MIT". However i couldn't find LICENSE file.
This is causing issue in synk scan.

Thanks,
Deepali

Hey Jake and thanks for this module.

I'd really like to use this module for some simple error throwing in different low-level modules, but since this module depends on "assert" and "util" sadly that's not really an option.

By requiring assert and util (I'm only bothered by assert, because I use the "typed" errors), browserify will bundle all its builtins and this is a total bummer for small modules.

Maybe we could just throw instead of asserting? I know the code would be a bit more messy, but in return it'd make it much more light-weight.

I could make a PR if you're interested?

First off let me say thanks for all your open-source work! It is because of people like you I've learned some incredible things.

I also want to say I'm not sure what to do about this, or where the fix should lie so feel free to point the finger elsewhere 😄

This issue is related to this issue in cycle.js. cycle.js runs in strict mode. This recent commit ends up assigning the name property of source to the target function object createError which is usually a no-op but throws under strict mode with at least chrome.

Uncaught TypeError: Cannot assign to read only property 'name' of function createError(opts) {
            var result = new Error()... <more>

v7.0.2 is available on npm, but the latest version on the repo here is v7.0.1.