Is there a simple way to add a custom User-Agent header so that my application can be a good GitHub citizen? If not, I'm happy to add it. Any pointers on where it would most easily fit?

Thanks.

The readme claims one should use :client-token <client_token> for oauth2, whereas the correct key is :access-token.

Hi all, I plan to use tentacles for my next application and update the dependencies and maybe merge other prs and maintainance.

If somebody wants to join efforts for updating the library and co-maintaining it, feel free to open an issue there: https://github.com/clojure-garden/tentacles

The docstring of events/performed-events has a typo: "perofmred".
Nothing major but a small buglet still :)

I'm implementing an app that needs to use REST APIs for a number of services. I'm implementing a connector for Pivotal Tracker right now, and it looks to me like tentacles.core could be a good basis for this. I'd have to make it a bit more generic though (e.g. the API base URL has to be a parameter and not hardcoded, and there needs to be some way to add arbitrary headers).

Would you consider a pull request along these lines?

Once current user rate limit threshold is crossed all calls will return a 403 status code.
Currently this code is ignored by safe-parse thus cannot be handled by caller.

Is there any other way to catch those errors?

It seems like the source code of 0.2.5 contains api-meta but the jar on clojars doesn't.

Hi @Raynes, loving your work 😃 I've been having a problem writing to the GitHub API and I think it's caused by my defaults not being added to the request correctly.

In tentacles.core/make-request we build up a request, adding headers if necessary. After adding headers, the defaults are merged into the query map. This process means that defaults can appear in a request body (for put/post/delete) or in the query string (for get etc), but they cannot go into headers.

I'm trying to use GitHub Trees API and I'm finding that the :oauth-token value I have in my tentacles defaults is ignored. It appears to be because this API does not allow the token to be supplied in the body, it has to be in the Authorization header.

I think we should merge defaults in before deciding which headers to add. Does this sound sensible? If so I'm happy to submit a PR for this.

Hi @Raynes,

Would you be kind enough to publish the new version to Clojars so we can use the new update in the project.clj.

Currently the last publish version was at 0.5.1.
Thanks again for your great contribution.

I am a Clojure noob, so there is a higher than normal probability of this being user error.

However, while I can successfully use functions like specific-issue, I find that with edit-issue, I get a response from Github that indicates a 404 error.

I notice that the Github issues API docs indicate that the edit endpoint should use PATCH, however edit-issues appears to be using POST.

Output with redacted user/repo names

user=> (issues/edit-issue "my-user" "my-repo" 1 {:body "new issue body"})
{:orig-content-encoding "gzip", :trace-redirects ["https://api.github.com/repos/my-user/my-repo/issues/1"], :request-time 638, :status 404, :headers {"Access-Control-Expose-Headers" "ETag, Link, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval", "Server" "GitHub.com", "Content-Type" "application/json; charset=utf-8", "Access-Control-Allow-Origin" "*", "X-Content-Type-Options" "nosniff", "X-Frame-Options" "deny", "Strict-Transport-Security" "max-age=31536000; includeSubdomains; preload", "X-RateLimit-Limit" "60", "X-RateLimit-Remaining" "46", "X-RateLimit-Reset" "1416809234", "Connection" "close", "Transfer-Encoding" "chunked", "Status" "404 Not Found", "X-GitHub-Request-Id" "redacted-request-id", "X-GitHub-Media-Type" "github.v3; format=json", "Date" "Mon, 24 Nov 2014 05:46:02 GMT", "Access-Control-Allow-Credentials" "true", "X-XSS-Protection" "1; mode=block", "Content-Security-Policy" "default-src 'none'"}, :body {:message "Not Found", :documentation_url "https://developer.github.com/v3/issues/#edit-an-issue"}}

https://developer.github.com/changes/2016-05-12-reactions-api-preview/

I made this issue using the library, because I needed to test this particular API call. Ignore me.

https://github.com/blog/1564-code-search-api

🔥

I'm currently finishing up a half-baked fork with the codebase ported to CLJX so as to support ClojureScript. The motivation was a) to have cljs support; and b) to allow pluggable HTTP clients, which in turn allows caching to be performed at the request level so users (i.e. me) don't have don't have to wrap the whole API.

I'm considering submitting a PR but don't want to spend time tidying this up if the idea is a non-starter for you.

Thoughts?

for instance if I want to use e.g. https://api.github.xyz.com/ is this the correct/preferred method?

(binding [tentacles.core/url "https://api.github.xyz.com/"] (pp/pprint (users/me )))

Hey there, I'm running into an issue trying to use tentacles with clojure 1.8.0.

I get the following error when requiring the tentacles.pulls namespace:

CompilerException java.lang.NoClassDefFoundError: IllegalName: compile__stub.clj_http.headers.clj-http.headers/HeaderMap, compiling:(clj_http/headers.clj:105:1) 

Thanks for the sweet tool.

Is there a reason for responses returning a collection of github objects to include an empty element at the end or is that a bug?

(pulls/pulls "Raynes" "tentacles" {:auth "cddr:M24thbdinF"
                                                     :per-page 1})
=> [{:created_at "", :assignee nil.....} {}]

Would you accept a PR fixing it or would that be considered a breaking change?

How can I make conditional requests with tentacles?
https://developer.github.com/v3/#conditional-requests

I did not find the way to see response headers and to set my own headers in request...

If I could, It will be possible to tune tentacles requests to be conditional...

Motivation

https://developer.github.com/v3/git/refs/

In the above link there's discussion about pulling a specific branch from GH requiring a heads prefix to be passed into the references api call. While Tentacles does have support for pulling all branches defined here, pulling a single branch requires more work via the references endpoint.

Unfortunately, if you try to use said endpoint herein, you get the following:

(tdata/reference username reponame
                     (str "head/" branch-name)
                     {:oauth-token github-access-token
                      :throw-exceptions true
                      :all_pages true})

=> CompilerException clojure.lang.ExceptionInfo: clj-http: status 404 {:status 404, :headers ..., :body "{\"message\":\"Not Found\",\"documentation_url\":\"https://developer.github.com/v3/git/refs/#get-a-reference\"}", :request-time 203, :trace-redirects ["https://api.github.com/repos/CircleCITestOrg/circle-dummy-branch-repo/git/refs/head%2Fabranchname], :orig-content-encoding "gzip"}, compiling: ...

Note the url encoded / which comes from the heads/abranchname.

I'm not really sure what to do to provide this functionality in this repo as forward slashes are legal ref names...

Suggested Musical Pairing

https://soundcloud.com/misterwives/coloring-outside-the-lines-rac

api-call has no 5 params implementation

GitHub paginates responses to API calls. It would be nice if Tentacles would support this.

Evaluate the following:

(tentacles.pulls/specific-pull "Malabarba" "lazy-map-clojure" 1 {:accept "application/vnd.github.VERSION.patch"})

You'll immediately get an exception because the :body is a patch file, and parse-safe tries to parse it as json.

Thanks for this great package!

Hey @Raynes,

First off: this project is great.

I’m still very new to clojure so I may be doing something wrong, but with-defaults doesn’t seem to be working for me. (Side note: the first entry in every API response is always an empty hash for me...)

Example:

(ns project.repl
  (:require [tentacles.core :as t]
            [tentacles.orgs :as orgs]))

(def defaults { :oauth-token "LOOK_ITS_MAH_TOKEN"
                  :per-page 100 })

;; I assume this should automatically merge these defaults with any provided options for every API request
(t/with-defaults defaults)

;; so this request should have my authorization token and return private teams
(defn teams [org]
  (orgs/teams org))

(teams "skookum") ;; -> only public teams

;; so I have to manually pass in the options object to get private teams
(defn teams-manual-defaults [org]
  (orgs/teams org defaults))

(teams-manual-defaults "skookum") ;; -> all teams

Maybe I'm missing something (new to Clojure), but I don't think the update file api is included currently: https://developer.github.com/v3/repos/contents/#update-a-file.

Accept: application/vnd.github-blob.raw

Example: https://gist.github.com/1074083#file_blobsraw.json

Reference: http://developer.github.com/v3/media/

Hi,

I am calling to empty content file and I am getting an error.

Code:

(tentacles.repos/contents "USER" "REPO" "EMPTY_FILE" {:str? true})

0.2.7:

ArrayIndexOutOfBoundsException -1 clojure.data.codec.base64/pad-length (base64.clj:53)

master:
I get the next error, even If I specify {:str? false}
ArityException Wrong number of args (0) passed to: core$byte-array clojure.lang.AFn.throwArity (AFn.java:437)

When editing a milestone, I am getting a 400 with a Problems parsing JSON error back.

The whole thing is completely testless at the moment. Still figuring out what the best way to go about tests would be.

'lein test' or 'lein check' throw

Exception in thread "main" java.lang.IllegalArgumentException: Parameter declaration str should be a vector

I tried running the tests with java 1.7.0_35, and 1.6.0_27 in Ubuntu 13.04 and 13.10.
I created a file "testinfo.clj" at the root containing a map similar to the one described on the README with my personal data.

When an error occurs like rate-limit exceeded, the response is unparsed (safe-parse not applied?), thus it's not clear that an error occur from the client side, because keys like :status or :trace-redirects or :body could be part of a valid response. Maybe the response should be a nil or an exception should be thrown (which I like much less). Then the client can check for nil and do the api-meta call to see what went wrong.

Btw, the api-meta seems not to work for me. I guess it's because the metadata gets lost after the call and assigning it to a variable. But is necessary for inspection and decision, e.g.

(defn succeeded? [meta]
  (and meta (not= (403 (:status meta)))))

(let [res (repos/languages "Raynes" "tentacles")]
  (when (succeeded? (core/api-meta res)))
    res)
;=> nil

While I was reading your README file, I noticed a misspelling (highlighted in bold-italics below)

We can get specific pages of output the same way by using _hte_ :page option. Additionally, :all-pages true can be passed, which will return a lazy seq of all items on all pages.

I try to implement a small server application where I would like to use the 5000 requests/h rate-limit when using basic authentication or oauth. When testing, I get:

(tentacles.core/with-defaults {:client-id "foobar" :client-token "foobar"}
  (tentacles.core/rate-limit))

Thus, I assume e.g. tentacles.core/rate-limit ignores the authentication credentials, as described in the documentation?

If an API function has no options and authentication would have no uses for that particular call, the options map is not a parameter at all.

Hi,

Do you plan to support the releases API? I couldn't find the functions for it here: https://developer.github.com/v3/repos/releases/

Thanks.

https://github.com/clj-commons/tentacles