rawgraphs / rawgraphs-core Goto Github PK

• implement a "getEnabledOptions" helper for evaluating which options should be disabled
• when an option is disabled ideally it should not be passed to render. let's pass in the default value for now (could break some charts). see chart rendering and getOptionsValues helper in options module

see https://observablehq.com/@fil/occlusion

It seems that having multiple values in mapping doesn't allow aggregation.
See the below example:

{
    id: 'bars',
    name: 'bars',
    validTypes: ['number'],
    required: true,
    multiple: true,
    operation: 'get',
    aggregation: true,
    aggregationDefault: {
      number: 'sum',
    },
  },

this code will throw this error:

Uncaught RAWError: Aggregator "s" is is not registered in RAW.

Is there something I'm missing?

See alluvial diagram as reference.

in the mapping function i create a property called source, and i'd like to use it for colors.

However, the colorScale returns an empty array

Hello,

I display a cloud of points as bubblechart.
I want to reset only data.
So I do :
compassCalibCurve = chart( bubblechart, { ...
Then I display datas. (it works well).
Then I want to reset data:
compassCalibCurve.data = []
compassCalibCurve.renderToDOM(compassCalibDiv)
But nothing occurs. I see rawgraphs-core displayaing the previous datas.
Best regards.

The mapping function is called three times, tested in a couple of visual models

• when whe get casting errors, also specify the column name for the cell
• when we find empy cells, dont't try too cast, but return empty string for string data type and null for number and dates

https://github.com/ajv-validator/ajv

In short, for stacks it doesn't make sense to expose a "color" dimension, bot from technical and conceptual point of view.
the color scale should be updated by the render.js - or the mapping function should be able to export stacks.

Visual models based on stacks (stacked bar chart, streamgraph, bump chart) requires to compute the d3.stack() function in render.js. This creates a new structure that keeps only stacks keys and values. I think it takes as implicit that colors can only be mapped on keys (one color for each stack serie).

Furthermore, it does not have any logic to use the color in a different way than on stacks.

add CI with github action workflow

1. test
2. release on push tag

It would be nice if columns with currencies symbols or % to be automatically parsed as numbers

Could you please take a look at #56. This fixes a ReDoS security issue in one of the dependencies for rawgraphs core.

https://security.snyk.io/vuln/SNYK-JS-D3COLOR-1076592

Cheers,
Sylvan

even if the render.js handles exceptions, if the color is not mapped it throws the following error:
colorAggregator is not a function

https://github.com/rawgraphs/rawgraphs-core/blob/master/src/raw.js#L142

If we use style prop we lose it when we export to .svg.
Background should be a <rect fill="my background color" width="full width" height="full height" x="0" y="0" /> element inside the svg

Hi there!

I was looking for the docs for rawgraphs-core but the URL on the GitHub repo:

..and rawgraphs docs page:

Both give a 404 - page not found - error. The URL is https://www.rawgraphs.io/rawgraphs-core/docs

Thought you might like to know in case this is accidental.

Cheers,

Phil

Why don't we manage the DOM element as other chart prop (data,etc) with getter/setter and avoid https://github.com/rawgraphs/rawgraphs-core/blob/api-experiments/src/raw.js#L111

const mychart = chart(visualModel, config, DOM_node)

At the moment, among the visual options types there is only colorScale (see https://rawgraphs.github.io/rawgraphs-core/docs/chart-interface#visualoptions).

Would be nice to have an option to define a single color, as for the background option.

At the moment, dates datatype is noted as:
dimension.dataType.type: 'date'

while for numbers is
dimension.dataType: 'number'

which makes more complex its usage in rendere (e.g. to understand if we should create a numerical or temporal scale).

My proposal is to use the dimension.dataType.type for all the types

Add util to apply multiple styles to a d3 selection.

Sometimes when you copy a table from a spreadsheet software you also get a lot of empty rows at the end of the table. These empty rows can create problems in parsing the data type. I would suggest to not import empty rows if possible.