Git Product home page Git Product logo

ravenwallet-android's People

Contributors

ben-abraham avatar blondfrogs avatar dts avatar gutyn avatar harlantwood avatar jadebyfield89 avatar jmacwhyte avatar kawww avatar menwitz avatar paulsky avatar samuraisam avatar spyder46n2 avatar tronblack avatar tyzbit avatar voisine avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ravenwallet-android's Issues

Price (in $) not updating

With Version 1 on mainnet, the price for RVN is not updating. May or may not be related to message when first launched "Checking info...." that stays on for a while.

Seed import shows high fee

Users report a very high fee message when trying to swipe a private key, which makes them very concerned in using the feature.

Asset Icon Artifacting

The A\ icon on the asset token looks like it has artifacting because of the background color around the icon. A new icon is needed to correct this.

Expert mode - Asset creation bug

When in Expert mode, if you don't put in an address, then it gives error "“The destination address is not an address” This may or may not be considered a bug. It might say "Address required in Expert Mode" to give a clue to turn off Expert mode. Or if the field is left blank, then default to the behavior when not in expert mode and create the asset anyway.

Then if you put in an address (not from Generate) but by hitting [Receive] button and pasting in the latest address, then another error occurs that says something to the effect that you can't send to yourself.

Create Asset Keyboard Inconsistencies

When creating an asset, the name field uses OS keyboard and number fields do not. Using the os keyboard adds consistency and allows a better workflow by allowing the use of the next key to go from field to field.

Cannot View Full Text in Tutorial

When viewing the Tutorial on smaller devices you cannot see the full text if it is more than two lines. Users need to be able to scroll on those pages or have them scaled down.

This also occurs on the "Almost Done!" page.

These screenshots provided are from a Sony Xperia XA2
tutorial

This is from an LGV30 Model VS996 running Android Versin 8.0.0
almost done

Barcode is not compatible

The barcode shown with the app (Version 1) is not readable by the iPhone - either from the RVN wallet on the iPhone, or from the built-in camara QR code reader.

Loading indicators on transaction screen are showing for transactions that are already done

Asset build 14
Nexus 5X
Android 8.1.0

On the transaction screen, when you have multiple transactions, adding a new one (via creating an asset for example) will cause a loading indicator to show up on older previous transactions. Leaving the transaction screen and coming back in sometimes fixes this issue.

It may have to do with if there is a transaction currently being processed. I have a video recording of this, but it is too long to attach to the GitHub issue. https://send.firefox.com/download/aaad966a40ef201e/#iW1MrUCA192Vgx9anGRWVA

No link to Terms of Use

While setting up a new wallet on the, "Almost done! Let's review" page, the last checkbox at the bottom asks, "I have read, understood, and agree to the Terms of Use." Normally there is somewhere I can click to review those terms. As it currently stands I have no way to go see what it is that I'm agreeing to. We should add a link somewhere on that page that I can click on to read the Terms of Use...

Padding Issues on Fingerprint Spending Limit Page

Device: Nexus 5X
OS: Android 8.1.0

The title text of the Fingerprint Spending Limit screen touches the help icon. The description text under the title is cut off / runs off the right side of the screen.

Check availability for assets not working

A user came by on a Galaxy S8 and the check availability functionality for assets was not working. The text changed to checking availability..., but then changed back. And there was no green / red indication of availability.

Cells Expand on Asset Display Settings screen

Asset build 14
Nexus 5X
Android 8.1.0

Tapping the Hide / Show button adds padding between the cells on the screen.

To reproduce:

  1. Have several assets
  2. Go to Asset Display Settings screen
  3. Tap on the Show / Hide button a handful of times
  4. Observe the extra space being added to the bottom of the cells.

Attached a screen capture of the problem:
displaysettings.mp4.zip

Default to Lowercase Keyboard For Seed Phrase Confirmation

When setting up a new they keyboard defaults to a capitalized first letter on the step where the user enters two of the words to confirm that they were written down correctly. This should default to lowercase as it will not work if the first letter is capitalized.

This is happening on the Android version (not sure if it is the same case on iOS).

Create Asset Check Availability button text changing inconsistently

On the create asset screen when tapping on the "Check Availability" button, the text changes to "Checking Availability..." then changes to "Check availability" (notice the lowercase availability) then it changes to Check Availability again.

Oddly enough, interacting with the "Check Availability" button also affects the capitalization of the "Create Asset" button in the same way.

unique asset creation error issue

Hi. im using ravenwallet-android to send tx..
i sent unique asset creation tx.. and it succeed..
but as you can see below.. the end of right side in the script pub key 's asm .. error marked.
it sometimes happen when i create unique asset with ipfs_hash code.
i checked the hex strings with the offset .. but i don't know why error shows up
do you have any idea about this ?

"value": 0.00000000,
"n": 3,
"scriptPubKey": {
"asm": "OP_DUP OP_HASH160 88a19423d47afba4b02c87ffce412a238835e3da OP_EQUALVERIFY OP_CHECKSIG OP_RVN_ASSET [error]",
"hex": "76a91488a19423d47afba4b02c87ffce412a238835e3da88acc04e72766e711c474957554e47415353455423756e692830303132333435363738392900e1f50500000000000001122031479ede5414b18e9205f0ab03b8cfac02f4c449ae9a993fc91c9b88c84efbcc75",
"reqSigs": 1,
"type": "new_asset",
"asset": {
"name": "GIWUNGASSET#uni(00123456789)",
"amount": 1.00000000,
"expire_time": 123145565922176,
"units": 0,
"reissuable": 0,
"ipfs_hash": "QmRf22bZar3WKmojipms22PkXH1MZGmvsqzQtuSvQE3uhm"
},
"addresses": [
"RMjdYHeqncFyoEA2FobvjC88Bq5yE7quet"
]
}

the full serialize hex is here..
010000000215f5db3a6e4ed8d66eb1e80a79118f612a7d26f311a74ec4b81797b9a2936d2f010000006b483045022100e098e2d28e8879237398eaf92fdc1b7255b171eab9d1d64364a866c5db3dd1b302203aabfed3d4349d2602aceb724f174581e3e3cebd0e65d6255f9785cdbe7dd5a3012103d0da93473c2b53dfa59254890787f8f920cef8ba331fd09e26540579a62c9fafffffffff15f5db3a6e4ed8d66eb1e80a79118f612a7d26f311a74ec4b81797b9a2936d2f020000006b483045022100c8c471e31f9ccb1521ad626960ea3ac3e002f19532ff29db626aebf8e6b1157302207b2f914ff972a370f9ebb89d3a02c5021752e1a055a48fbacf3674a7c709d6c1012103d0da93473c2b53dfa59254890787f8f920cef8ba331fd09e26540579a62c9fafffffffff040065cd1d000000001976a914f62e63b949bfcad8258fbc0d9e4d8f71b64796be88ace4561182090000001976a91488a19423d47afba4b02c87ffce412a238835e3da88ac00000000000000003576a91488a19423d47afba4b02c87ffce412a238835e3da88acc01972766e740c474957554e4741535345542100e1f505000000007500000000000000006a76a91488a19423d47afba4b02c87ffce412a238835e3da88acc04e72766e711c474957554e47415353455423756e692830303132333435363738392900e1f50500000000000001122031479ede5414b18e9205f0ab03b8cfac02f4c449ae9a993fc91c9b88c84efbcc7500000000

Asset warnings in classic RVN wallet

Please add a warning at the receiving addresses that the wallet is not asset aware.

Example: "Do not send assets to this address".

Users report that they mistakenly sent assets there because the wallet is "official".

Improvement: Favor Inline Error Messages over Error Dialogs

There are a lot of dialogs being used for error messages for fields. Consider using inline errors for the fields they apply to. The error dialogs are overly intrusive, require extra user taps, and are only handled one at a time. Using inline error messages for fields can solve all of these user pain points.

Create Asset: Hints Disappear When Data Is Entered

When first going to the Creat Asset screen, it is not clear what the field is for Units because it is prepopulated to 0. It looks like it is the entry for Quantity because the hints disappear when a value is entered. Having a title for these fields similar to the iOS wallet will alleviate this problem.

Full asset list does not adhere to Hide Asset Display Settings

Asset build 14
Nexus 5X
Android 8.1.0

When you have more than four assets showing and others hidden (via Asset Display Settings), and you tap on Show More to view the full asset list, it displays all assets even if the assets are set to Hide in Asset Display Settings.

fail sync

fail sync in auto mode. nodes refuse connection?

Inconsistent Results creating SubAsset

First time creating a sub-asset off of TRYTEST. Created NOTRYJUSTDO Qty: 21B No-reissue, 0 Units. Got confirmation with TxID. Never completed.

Second time, Sub-asset: JUSTDOIT Qty: 21B Units: 8 No-reissue. Got confirmation. Then a message that transaction failed.

Third time, Sub-asset: BLAH Qty: 21B Units 8 Reissuable. Got confirmation with TxID, then crashed. When I went back into the app, the asset was created.

Issue Sub Asset - check availability - no error on empty sub asset name

Describe the issue

"Check availability" button doesn't function correctly when nothing is entered for sub asset name when issuing sub asset

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

  1. Go to issue sub asset screen
  2. Tap "Check Availability" button without entering a sub asset name (so the name field should display something like TESTASSET/)

Expected behaviour

Should display error "invalid name" or similar

Actual behaviour

Button text changes from "Check Availability" to "Checking Availability..." but doesn't ever progress past this point

Screenshots.

image

Cannot see the name text field for sub assets when keyboard is up

Asset build 14
Nexus 5X
Android 8.1.0

When creating a sub-asset or unique asset from the full asset list (the screen you get to after you have more than 4 assets and tap Show More), if the keyboard is up, you cannot see the name field. If you try to scroll the dialog to move the name field into view, the dialog closes.

They keyboard is shifting the dialog up and pushing the name field out of view. This issue does not happen when you create sub-assets from the main screen. Just from within the full asset list.

Video attached:
textinput.mp4.zip

UI - text overlapping on transaction logs

In the transaction log, long asset names and/or amounts overlap such that it is difficult to read them without tapping to view the extended details (see screenshot)

image

Device: Pixel 2; Android 9
Android wallet version 25

Crash when creating sub asset w/ max quantity

Describe the issue

Android wallet app crashes when issuing a sub asset with max quantity

Can you reliably reproduce the issue?

If so, please list the steps to reproduce below:

  1. Create a main asset with any quantity
  2. Issue Sub Asset > enter name and check availability, then set sub asset quantity to 21,000,000,000
  3. Click Create -- app crashes immediately

Expected behaviour

Confirmation prompt should appear prompting user to confirm new sub asset details

Actual behaviour

App crashes

Screenshots.

If the issue is related to the GUI, screenshots can be added to this issue via drag & drop.

What version of bitcoin-core are you using?

List the version number/commit ID, and if it is an official binary, self compiled or a distribution package such as PPA.

Device specs:

Pixel 2
Android 9
Wallet version 25

Additional notes:

This issue is not limited to sub assets with maximum quantity only - I have also experienced crashes with other large quantities (all of them above 999,999,999 I believe) but crash consistently happens with max quantity

Review page needs warning when trying to proceed without checking all boxes

There are three items that need to be agreed to on the, "Almost done! Let's review" page. If any one-or-two of these are not selected the Confirm and Finish button does nothing (which is good), but it should have a pop-up warning indicating that all of the items need to be agreed to before the app can proceed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.