Git Product home page Git Product logo

sub-tv's Introduction

Sub-TV

Download Movies and Series subtitles via a intuitive node CLI.

Issues

Having some problem? Please report via GH Issue :)

License

MIT License © Raul Melo

sub-tv's People

Contributors

cassmtnr avatar raulfdm avatar semantic-release-bot avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

sub-tv's Issues

Do not found any subtitles

I installed and in usage not found any subtitle.

My software specifications are follow:
OS: Lubuntu 16.04.1
NodeJS: v9.3.0
NPM: 5.5.1

I recorded a asciinema to demonstrate.

asciicast

Cannot read property name from undefined

Scenario

  • Serie: Mr Robot
  • Season: Season 1
  • Episode: Episode 8
  • Language: English
  • Subtitle: Rating: -2 | Name: Mr.Robot.S01E08.REAL.720p.HDTV.x264-KIL
    LERS

Error Trace

Trace: TypeError: Cannot read property 'name' of undefined
    at Promise (/home/raul/.npm-global/lib/node_modules/sub-tv/src/service/Download.js:11:21)
    at Promise (<anonymous>)
    at download (/home/raul/.npm-global/lib/node_modules/sub-tv/src/service/Download.js:7:10)
    at bootstrap (/home/raul/.npm-global/lib/node_modules/sub-tv/src/index.js:83:26)
    at <anonymous>
    at bootstrap (/home/raul/.npm-global/lib/node_modules/sub-tv/src/index.js:87:13)
    at <anonymous>

Update security

Since I've released this project a lot of vulnerability were found in some dependencies in this project. So it should be upgraded to the most recent one without break the app.

Rewrite README

It's not written in a nice way. There's a lot of grammar mistakes and also the information isn't totally clear.

It should be rewritten.

Big Refactor

  • TDD (required);
  • Move code to es6;
  • split up code (e.g. questions);
  • Create class to log;
  • Replace let to const when it's possible;
  • Focus on functional programming;

Update dependencies

yarn audit console:

245 vulnerabilities found - Packages audited: 9486
Severity: 161 Low | 68 Moderate | 16 High

Remove ESLINT

Since it's been used prettier, isn't necessary anymore eslint.

Add Rollup bundler

Now we're serving as a CLI the files without any kind of transpilation.

Should be add rollup to generate a bundle file smaller and with the code we do need (e.g. dependencies)

Do not found subtitles (scenario)

Case to test:

  • Série: Grey's anatomy
  • Season: 1
  • Episodes:

In this scenario, it shows any episode and it is not possible to return to previous question.

It must to inform that do not have any subtitles for this season and return to Season question.

[bug] Error: Could not resolve '../models/Serie' from src/service/Serie.js

After #17, the build fails:

$ yarn build
yarn run v1.12.3
$ rollup -c

src/index.js → dist/subtv.js...
[!] Error: Could not resolve '../models/Serie' from src/service/Serie.js
Error: Could not resolve '../models/Serie' from src/service/Serie.js
    at error (/Users/raulmelo/projects/personal/sub-tv/node_modules/rollup/dist/rollup.js:3597:30)
    at /Users/raulmelo/projects/personal/sub-tv/node_modules/rollup/dist/rollup.js:17532:25

error Command failed with exit code 1.

Add build command to travis

To keep everything working fine and avoid implement which breaks the build, should be added yarn build to scripts.

Add prettier

Instead using eslint, should be replaced by prettier and also add a staging hook to keep the code quality

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.