ratanakvlun / sequelize-odbc-mssql Goto Github PK

Getting this when trying to install:
../src/odbc.cpp:893:9: error: ‘boolean’ was not declared in this scope
boolean* v = (boolean*)malloc(sizeof(boolean));
^
../src/odbc.cpp:893:18: error: ‘v’ was not declared in this scope
boolean* v = (boolean*)malloc(sizeof(boolean));
^
../src/odbc.cpp:893:31: error: expected primary-expression before ‘)’ token
boolean* v = (boolean*)malloc(sizeof(boolean));
2018-01-26T22_00_07_706Z-debug.log
MyEnv.txt
npm i sequelize-odbc-mssql.txt

Hi! Not exactly an issue but a feature request.
I started using this sequelize dialect and after a while I figured that not every MS Sql Server installation is the same, so I can' t really rely on a standarized configuration (for my app). So the only thing I can trust is using a Windows x64 ODBC connection, connection via it' s DSN.

Current code in the Connection class makes some adjustments to the connectionString so it takes the SQL Server specific format, using the SQL Server Native Client, the SQL Native Client or the SQL Server driver, but no option to use the DSN of an ODBC connection.
A boolean useDSN could be an option, or checking if there's a dsn/DSN setting in the config object or the connectionString, so the constructor skips the actual driver detection.

Hope you consider this feature.
Best regards,
Jose Ignacio

Hi,

I can't connect to my database using trusted connection unless I provide an "options" object inside the "dialectOptions", like this:

"dialectOptions": { "options": { "driver": "ODBC Driver 17 for SQL Server", "trustedConnection": true } }

Not including it results in:
ERROR: Login failed for user ''.