raphamorim / lucario Goto Github PK

Now lucario is also available on Windows Terminal #70. I think it would be awesome to update the About section of this repo to add Windows Terminal as well. 😁

After stumbling upon non-palette colors in #60 and #63, I just ran a quick grep over the files in this repository to get an overview of all color hex-codes used.

Here is a list of the files that include RGB color codes and the colors they use:

readme.md
#19242f
#243443
#2b3e50
#5c98cd
#e6db74
#f8f8f2

lucario.tmtheme
#10171e
#19242f
#243443
#2b3e50
#3f9ab7
#49483e
#5c98cd
#61bbc8
#66d9ef
#72c05d
#75715e
#a6e22e
#ae81ff
#e6db74
#f8f8f0
#f8f8f2
#f92672
#ca94ff
#ff6541
#ffab28

gnome-terminal/lucario.sh
#2b3e50
#4f4f4f
#5796ed
#6b9fed
#8ee478
#eeeeee
#f8f8f2
#fa6960
#fbb036
#fc6ffa
#feffb9
#ff6c60
#ff73fd
#ffffb6
#ffffff

styles/colors.less
#19242f
#199c4b
#243443
#2b3e50
#5c98cd
#66d9ef
#6be5fd
#72cc5a
#8be0fd
#ca94ff
#e6db74
#e94b35
#f0cc04
#f8f8f0
#f8f8f2
#ff6541
#ffab28

styles/syntax-variables.less
#2196f3
#263238
#65737e
#96cbfe
#a8ff60
#cc6666
#cdd3de
#e9c062
#c0c5ce

css/lucario.css
#2b3e50
#7ce5e6
#84dffe
#b3d6b3
#d7d787
#e6b5ff
#f8f8f2
#ffb3b5
#ffffcc

xfce4-terminal/lucario.theme
#2b3e50
#4f4f4f
#5796ed
#6b9fed
#8ee478
#e6db74
#eeeeee
#f8f8f2
#fa6960
#fbb036
#fc6ffa
#feffb9
#ff6c60
#ff73fd
#ffffb6
#ffffff

colors/lucario.vim
#19242f
#204a87
#26446c
#2b3e50
#354758
#405160
#478815
#5c98cd
#61bbc8
#66747f
#66d9ef
#72c05d
#8c0c10
#929ba1
#ca94ff
#e6db74
#f8f8f0
#f8f8f2
#f92672
#ff6541
#ffab28

termux/lucario.colors
#2b3e50
#4f4f4f
#5796ed
#6b9fed
#8ee478
#e3bf21
#eeeeee
#f8f8f2
#fa6960
#fbb036
#fc6ffa
#feffb9
#ff6c60
#ff73fd
#ffffb6
#ffffff

Comparing the colors used in the different implementations of the theme, it turns out that the default foreground and background colors are the only ones that are used in all implementations. The following table gives for each color the number of files it was found in.

In order to make the Lucario color theme more consistent across different Editors/Terminals, I think there are two steps to be taken:

1. Expand the "official" color palette. I mean all of the above listed implementations use more than the 6 basic colors and providing more "official" colors would reduce the clutter. For example it might make sense to define a 16-color palette that can be used by terminal schemes in conjunction with the foreground and background color.

2. Overhaul all implementations so that they use only colors from the expanded color palette.

I really like the overall looks of lucario and I use it for several applications and I would love it to be more consistent, so I'd be willing to invest some time on this issue. However, I don't think I would be much help when it comes to expanding the color palette, but I could definitely help out updating the different implementations.

Sorry for the lengthy issue, looking forward to hear your opinion on this topic.

It would be great if this were available via Sublime's package manager

In index.less: Target the selector :host, atom-text-editor instead of .editor for shadow DOM support.

lucario is showing some commands as deprecated in Atom:

• iTerm
• terminal.app

The color codes in the CSS style are not the ones defined for lucario in the README.
For example for strings #d7d787is used instead of #e6db74. Is this done on purpose?

Hi there,

Came across another issue that I unfortunately don't have the time to troubleshoot (for now).

Something with your atom theme causes the gutter to go crazy and hide line numbers at random intervals. It really is quite unpredictable.

Here's a screenshot:

Let me know what you think. I'll see if I can get to troubleshooting this further in a week or so when I have more time.

Thanks

Edit: I have a sneaking suspicion that it has something to do with the git diff package. It only happens on lines that are marked as edited, removed, or added..

Is this intended behavior?

Absolutely love this theme! If possible, could you please support gnome-terminal? Should be easy I hope.

After installing this theme via Package Manager I noticed there was an error popping up in my console that's coming from another plugin, SublimeLinter. I checked the file and line number where that error was coming from and it looks like an XML error with Lucario's theme.

The variable scheme_text is the Lucario color scheme and that is getting passed to ElementTree.XML which then throws the ParseError. Looking at other themes that don't cause this error I think the issue might be with your comments that are on the first line of .tmTheme.

Error trace is below.

Traceback (most recent call last):
File "/Users//Library/Application Support/Sublime Text 3/Packages/SublimeLinter/lint/util.py", line 239, in generate_color_scheme_async
plist = ElementTree.XML(scheme_text)
File "X/xml/etree/ElementTree.py", line 1356, in XML
xml.etree.ElementTree.ParseError: XML or text declaration not at start of entity: line 8, column 0

Hi,
I am wondering whether you do not know why the scheme highlight the same code differently in Atom and Sublime. The desired one is the one of Atom.

Atom example [correct]:

Sublime example (functions are of the colour of text):

Thank you for ideas.

I guess this is more of a suggestion than an issue. This is hands down the best theme I have ever had for sublime. Except one thing: the instance keywords this and self for java and python respectively are unaffected and though i tried changing them myself, i couldn't. Would someone mind pointing me in the right direction as to how i should change these, or can i just suggest it become implemented? It would be 100x better 👍

The difference is really profound. gVim looks great but I like terminal Vim and that looks not-do-good. Isn't it possible to get at least the bgcolor a little closer to the gVim one?

The One Dark theme happens to currently be the default UI theme in Atom. Tabs in the One Dark theme (and other UI themes) show up as white when using Lucario, which is clearly not intended.

Hi, @raphamorim. I'm using Lucario as my color scheme on Vim within the terminal. Given that the background is dark, I'm wondering if 16 is an aproprieted color for the visual mode selection. Is this the intended behavior?

I would expect something like:

Which means replace 16 by 60 on the following line:

hi Visual       ctermfg=NONE ctermbg=16 cterm=NONE guifg=NONE guibg=#19242f gui=NONE

If it is ok for you, I'll be happy to send a PR.

Kitty is a fast, featureful, GPU based terminal emulator.

It would be nice to have the Lucario color scheme available to it.

Useful links:

• Documentation
• Some examples of Kitty themes

The fast way - Convert Lucario.tmTheme to vscode theme:
https://code.visualstudio.com/Docs/customization/themes#_adding-a-new-theme

here is what happens when i put the color theme into iterm2.

and here is what happens when i allow the lucario theme in vim, while running the same color schemes in iterm2

this is what it looks like when i don't change iterms color themes at all:

this is macs stock terminal program:

and i checked that for both iterm2 and iterm
the echo $TERM is:
screen-256color or

and it doesn't work when i get out of tmux

I'm confused about how to get this awesome color sheme to work!

Thanks so much in advance!

In Lucario\index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• .comment => .syntax--comment

• .string => .syntax--string

• .constant => .syntax--constant

• .variable => .syntax--variable

• .variable.other.readwrite.instance => .syntax--variable.syntax--other.syntax--readwrite.syntax--instance

• .constant.character.escaped, .constant.character.escape, .string .source, .string .source.ruby => .syntax--constant.syntax--character.syntax--escaped, .syntax--constant.syntax--character.syntax--escape, .syntax--string .syntax--source, .syntax--string .syntax--source.syntax--ruby

• .keyword, .storage => .syntax--keyword, .syntax--storage

• .storage.type => .syntax--storage.syntax--type

• .entity.name.class => .syntax--entity.syntax--name.syntax--class

• .entity.other.inherited-class => .syntax--entity.syntax--other.syntax--inherited-class

• .entity.name.function => .syntax--entity.syntax--name.syntax--function

• .variable.parameter => .syntax--variable.syntax--parameter

• .entity.name.tag => .syntax--entity.syntax--name.syntax--tag

• .entity.other.attribute-name, .markup.heading => .syntax--entity.syntax--other.syntax--attribute-name, .syntax--markup.syntax--heading

• .support.function => .syntax--support.syntax--function

• .support.constant => .syntax--support.syntax--constant

• .support.type, .support.class => .syntax--support.syntax--type, .syntax--support.syntax--class

• .support.other.variable, .variable.unordered, .variable.ordered => .syntax--support.syntax--other.syntax--variable, .syntax--variable.syntax--unordered, .syntax--variable.syntax--ordered

• .invalid, .invalid.deprecated => .syntax--invalid, .syntax--invalid.syntax--deprecated

• .markup.bold, .markup.italic => .syntax--markup.syntax--bold, .syntax--markup.syntax--italic

• .markup.raw => .syntax--markup.syntax--raw

• .punctuation.definition.tag.xml.plist, .constant.name.xml => .syntax--punctuation.syntax--definition.syntax--tag.syntax--xml.syntax--plist, .syntax--constant.syntax--name.syntax--xml

• atom-text-editor, :host => atom-text-editor,atom-text-editor

• atom-text-editor .line.cursor-line, :host .line.cursor-line => atom-text-editor .line.cursor-line,atom-text-editor .line.cursor-line

• atom-text-editor .invisible, :host .invisible, atom-text-editor .invisible-character, :host .invisible-character => atom-text-editor .invisible,atom-text-editor .invisible, atom-text-editor .invisible-character,atom-text-editor .invisible-character

• atom-text-editor .selection .region, :host .selection .region => atom-text-editor .selection .region,atom-text-editor .selection .region

• atom-text-editor .selection .cursor, :host .selection .cursor => atom-text-editor .selection .cursor,atom-text-editor .selection .cursor

• atom-text-editor .indent-guide, :host .indent-guide => atom-text-editor .indent-guide,atom-text-editor .indent-guide

• atom-text-editor .wrap-guide, :host .wrap-guide =

It's possible?
i've used the colors available in the 256 colors pallete. But as soon loses the magic

Please could you make this awessome theme for intellij IDEA. Im currently using it in Vim and some other editors. It would be great. :)

Hi @raphamorim, I know that it is possible to style IncSearch and Search differently, but I would expect these two styles to be the same.

Besides, I prefer the one you have chosen for IncSearch; it provides a stronger contrast than just an underline, which is desirable since it is the style for things we are looking for.

So, what do you think about replacing this:

For this:

If you agree, I would be happy to send a PR for that.

In index.less: Use the atom-text-editor tag instead of the editor class.

Hello dude, what is up? I am here to ask you about your project, I think that it is a good color scheme and I think that could be included as vim-airline color scheme in a future... 👯 👍

there is an issue open in the vim repository, to distribute more colorschemes with Vim. Would you kindly give your permission to distribute this colorscheme with Vim?

Just tried it on my terminal and this was the result:

I guess this is something related to supporting color 256.

In Lucario/index.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• .comment => .syntax--comment

• .string => .syntax--string

• .constant => .syntax--constant

• .variable => .syntax--variable

• .variable.other.readwrite.instance => .syntax--variable.syntax--other.syntax--readwrite.syntax--instance

• .constant.character.escaped, .constant.character.escape, .string .source, .string .source.ruby => .syntax--constant.syntax--character.syntax--escaped, .syntax--constant.syntax--character.syntax--escape, .syntax--string .syntax--source, .syntax--string .syntax--source.syntax--ruby

• .keyword, .storage => .syntax--keyword, .syntax--storage

• .storage.type => .syntax--storage.syntax--type

• .entity.name.class => .syntax--entity.syntax--name.syntax--class

• .entity.other.inherited-class => .syntax--entity.syntax--other.syntax--inherited-class

• .entity.name.function => .syntax--entity.syntax--name.syntax--function

• .variable.parameter => .syntax--variable.syntax--parameter

• .entity.name.tag => .syntax--entity.syntax--name.syntax--tag

• .entity.other.attribute-name, .markup.heading => .syntax--entity.syntax--other.syntax--attribute-name, .syntax--markup.syntax--heading

• .support.function => .syntax--support.syntax--function

• .support.constant => .syntax--support.syntax--constant

• .support.type, .support.class => .syntax--support.syntax--type, .syntax--support.syntax--class

• .support.other.variable, .variable.unordered, .variable.ordered => .syntax--support.syntax--other.syntax--variable, .syntax--variable.syntax--unordered, .syntax--variable.syntax--ordered

• .invalid, .invalid.deprecated => .syntax--invalid, .syntax--invalid.syntax--deprecated

• .markup.bold, .markup.italic => .syntax--markup.syntax--bold, .syntax--markup.syntax--italic

• .markup.raw => .syntax--markup.syntax--raw

• .punctuation.definition.tag.xml.plist, .constant.name.xml => .syntax--punctuation.syntax--definition.syntax--tag.syntax--xml.syntax--plist, .syntax--constant.syntax--name.syntax--xml

• atom-text-editor, :host => atom-text-editor,atom-text-editor

• atom-text-editor .line.cursor-line, :host .line.cursor-line => atom-text-editor .line.cursor-line,atom-text-editor .line.cursor-line

• atom-text-editor .invisible, :host .invisible, atom-text-editor .invisible-character, :host .invisible-character => atom-text-editor .invisible,atom-text-editor .invisible, atom-text-editor .invisible-character,atom-text-editor .invisible-character

• atom-text-editor .selection .region, :host .selection .region => atom-text-editor .selection .region,atom-text-editor .selection .region

• atom-text-editor .selection .cursor, :host .selection .cursor => atom-text-editor .selection .cursor,atom-text-editor .selection .cursor

• atom-text-editor .indent-guide, :host .indent-guide => atom-text-editor .indent-guide,atom-text-editor .indent-guide

• atom-text-editor .wrap-guide, :host .wrap-guide => atom-text-editor .wrap-guide,atom-text-editor .wrap-guide

• atom-text-editor .gutter .line-number, :host .gutter .line-number => atom-text-editor .gutter .line-number,atom-text-editor .gutter .line-number

• atom-text-editor .gutter .line-number.git-line-added, :host .gutter .line-number.git-line-added => atom-text-editor .gutter .line-number.git-line-added,atom-text-editor .gutter .line-number.git-line-added

• atom-text-editor .gutter .line-number.git-line-modified, :host .gutter .line-number.git-line-modified => atom-text-editor .gutter .line-number.git-line-modified,atom-text-editor .gutter .line-number.git-line-modified

• atom-text-editor .gutter .line-number.git-line-removed, :host .gutter .line-number.git-line-removed => atom-text-editor .gutter .line-number.git-line-removed,atom-text-editor .gutter .line-number.git-line-removed

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

You should put full link to fix the issue