rakambdaorg / fallingtree Goto Github PK

It crash with the following error:

The game crashed whilst initializing game
Error: java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'falling_tree'!
Exit Code: -1

We should cache list of items/blocks instead of loading them each time we access it.

This will mainly apply to the whitelists and blacklists and should improve a bit performances.
These only need to be refreshed when the config is reloaded/updated.

Hi there,

Today I updated the mod to the 1.16.4-2.8.1 version and it simply crashed Minecraft when loading. I'm attaching the crash report below.

crash-2020-12-21_16.49.04-fml.txt

Contact me if you need any other info.

Best regards and thank you for your work and dedication to the community.

Describe the bug
A clear and concise description of what the bug is.

Alright so i am experiencing the same that the other person reported although he poorly described it. When i add the fabric mod to my mod folder on my server the server crashes on boot. giving the fatal error Could not find required mod: falling_tree requires {minecraft @ [1.16.4]}. This is on a 1.16.3 server, i also tried the 1.16.2 version, does the same thing.

To Reproduce
Steps to reproduce the behavior:

1. Add the mod to the mod folder
2. Boot the fabric server

Infos:

• Minecraft verson: [e.g. 1.16.3]
• Mod loader: [Fabric]
• Mod version: [2.5.1]

If you provide a crash report please include it in a readable way (like pastebin or gist for example).
https://pastebin.com/U3bjS7fD

With leaf break active, the collective block breaking sound can be deafening. If there's a way to mitigate how loud leaf decay is, that would be great :)

Describe the bug
So i don't know if it's a bug as there is no example on adding to the whitelist, but when i add to the whitelist it looks like this [mekanismtools:wood_paxel] and gives an error for any of those tools

To Reproduce
Steps to reproduce the behavior:

1. add the tools to the whitelist

Infos:

• Minecraft verson: 1.16.1 forge
• 1.16.1 Mekanism Tools .430

If you provide a crash report please include it in a readable way (like pastebin or gist for example).

https://github.com/RakSrinaNa/FallingTree/wiki/Behavior

Describe the bug
Project MMO allows the player to gain woodcutting stats when chopping down trees.
But if I use this mod to cut trees, no stats are gained. The mod dev said the proper events are not being sent.

To Reproduce
Steps to reproduce the behavior:

1. Install Project MMO
2. Chop down trees both with and without Falling Tree.

Infos:

• Minecraft verson: 1.15.2
• Mod version: 2.1.3+28
• Project MMO version: 2.42

Describe the bug
No matter what and how I enter in the whitelist for the tools (or the blacklist for that matter) it will only save an empty list.

To Reproduce
Steps to reproduce the behavior:

1. Enter the mod's settings in the main menu
2. Enter the 3rd submenu of the 3x "falling_trees" (see screenshot)
3. Enter various tools into the whitelist, in my case "tconstruct:hatchet", "tconstruct:lumberaxe", "tconstruct:mattock"
4. Press "Done" until back in the mod list
5. Enter the mod's settings again => "Reset" button for the settings still greyed out because nothing was saved : (

Infos:

• Minecraft verson: 1.12.2
• Mod loader: Forge 14.23.5.2854
• Mod version: 2.4.0

Edit 1: I just tried the version released before this one and there it works.
But the 'release' version of the mod can neither load nor save these settings : (

Edit 2: However, with this version is the problem that it doesn't care about what it's loading -_-

Describe the bug
Changing the "Speed multiplicand" does not affect the tree breaking speed. Seems to be stuck at 0

To Reproduce
Steps to reproduce the behavior:

1. Changed speed multiplicand via the client mod menu ( trees still break at speed 0 )
2. Changed speed multiplicand in the config file ( trees still break at speed 0 )

Infos:

• Minecraft verson: [e.g. 1.16.5]
• Mod loader: [Forge - version 36.0.1] also tested with 36.0.15
• Mod version: [2.10.0]

Just something for you to put into your ”idea box” to consider in the future if you want. :) Maybe you’ve already thought of it, if not:

I was thinking of ways to identify/separate trees from other log/wood structures. Not leaves necessarily, but the logs themselves.
What I came up with:
(A use case for a "connected block" whitelist)

Test for blocks connected to the log that is to be removed (blocks connected to the furthest log from the cutting point). So for example, if the log is connected to wooden planks or glass it won’t be considered part of a tree and won’t be removed. However if for example it’s instead connected to any of the following:
(All possible natural blocks connected to a generated tree[log] I could think of)

• leaves, air, vines, cocoa beans, fire, bee nests, bamboo, sugar cane or another log.

In the case of nether ”trees:”

• air, crimson/warped stem, nether wart block, warped wart block, weeping vines, twisting vines, shroomligt.

Only under these conditions would it be considered part of a tree and be removed like normal. If anything else is in contact, it’s not part of a tree but some other wooden structure and won’t be removed.

So a config whitelist for blocks that are allowed to be in contact with a log for it to be considered part of a tree and be removed. A whitelist would be better than a blacklist as there are far more blocks that aren’t connected to generated trees than there are ones that are connected (naturally that is).

Visualization of blocks connected to log (barriers being connected blocks):

Senario image below:
(cutting point being the lowest log in the image)
In a case like this where the tree scan finds a "non-tree log"(log in contact with a non-whitelisted block). I'm not sure if the scan should stop when finding this log and ignore any blocks above/after it and only remove the 3 blocks below it (considering it a dead end). Or if the scan should remove the 1 block above skip the non-tree log and then the three logs below it. So if a "non-tree log" should be a dead end for the scan or not. I'm guessing that a dead end would be more useful in most cases.

https://www.curseforge.com/minecraft/mc-mods/falling-tree?comment=337

Describe the bug
No config file generated in the mods folder or anywhere else in the server files. I'm trying to increase the max tree size and can't because there is simply no config file at all.

To Reproduce
Steps to reproduce the behavior:

1. Installed Fabric server launcher for 1.16.4 remapping Vanilla 1.16.4 server jar
2. Installed FallingTree for Fabric 1.16.4 and the Fabric API into the mods folder
3. Started the server
4. Mod works, but default max tree size is much smaller than I'd like
5. Went to configure and found no configuration file in the mods folder even after restarting the server and refreshing files multiple times

Infos:

• Minecraft verson: Fabric 1.16.4 through Vanilla 1.16.4
• Mod loader: Fabric
• Mod version: FallingTree-Fabric-1.16.4-2.10.0

If you provide a crash report please include it in a readable way (like pastebin or gist for example).

Describe the bug
While having break_leaves set to true, any sapling planted will have their leaves break when grown.

#When set to true, leaves will be broken instantly
break_leaves = true

https://i.imgur.com/87fzlSh.gifv

To Reproduce
Steps to reproduce the behavior:

1. Plant a sapling
2. Wait for it to grow

Infos:

• Minecraft verson: 1.15.1
• Mod version: FallingTree-1.15.1-2.0.1+11
• Forge 30.0.35

If you provide a crash report please include it in a readable way (like pastebin or gist for example).

Basically have had this happen a few times. A player went to chop one log off the house and the whole house is gone. Would it be possible to prevent this?

https://i.imgur.com/z0cquzL.jpg
https://i.imgur.com/Z1Sq1UJ.jpg

Describe the bug
A clear and concise description of what the bug is.
Mod doesnt function at all in forge server, but client it works.

To Reproduce
Steps to reproduce the behavior:
1.
2.

Infos:

• Minecraft verson: [e.g. 1.14.4] 1.16.3
• Mod version: [e.g. 1.0.0] Latest release

If you provide a crash report please include it in a readable way (like pastebin or gist for example).
No crash occurs.

A config option for a hybrid mode between Instantaneous and Shift Down modes.

Basically what I am talking about here is that after the tool breaks/1 durability shift down the rest of the tree. This should 'cut' down the number of floating trees, and provide a solution that doesn't involve an insane amount of time cutting down a forest in Shift Down mode or nerdpoles. This will really help cut out the grind in regards to clearing forests involving larger trees that tend to interconnect.

Describe the bug
A clear and concise description of what the bug is.
As soon as I launch my Minecraft, an error message will pop up saying that Falling Tree has failed to load correctly.

Here's a screenshot:

To Reproduce
Steps to reproduce the behavior:

1. Put the mod in the mod folder
2. Launch MC
3. Let it simmer
4. VOILA! A brand new crash report!

Infos:

• Minecraft verson: 1.16.4
• Mod loader: Forge
• Mod version: 2.8.0

If you provide a crash report please include it in a readable way (like pastebin or gist for example).
Here is the crash report: https://pastebin.com/8ER7m3v6

Add an option to not cut the whole tree down if it's going to break the axe.

I'm using the fabric version for 1.16.4: FallingTree-Fabric-1.16.4-2.8.1

(When using SHIFT_DOWN mode)
When using "above_cut" the discription for it says: "will break only blocks that are connected from above the cut point."
However when you put logs in a row horizontally you can still use shift down to clear that row from one end by simply breaking the other end repeatedly. So the feature works horizontally the same way as it does vertically.
How I expected/wish it would work is for "above_cut" to only break blocks that are connected to the cut point but are also ABOVE IT. A good idea as well would be to have a limit to horizontal breaking when they are above the cutting point. So that one cant clear a 100 block long horizontal row of logs. This wouldn't break the intentional use of the feature, would just leave a stem that one would have to manually clear in 2x2 trees.
All of this could be solved of course if trees could be somehow identified, sadly that doesn't seem to be possible :/

I originally noticed this when accidentally trying this feature on a village farm, I just felt that it was in a way "game breaking" to have this work so well horizontally as well. (might be just me). I feel like this applies more for shift_down mode. As it's more "vanilla-like."

Farm thing:

So in short

1. Have "above_cut" only break blocks above the cut point. (atleast with "shift_down" enabled).
2. Have a limit set to horizontal breaking (when it's above the cut point). Have a configurable number of logs. And maybe have "shift_down" only work if there are no parts on the tree horizontally that are above the limit. Kinda like pistons cant push above 12 blocks.
3. Thanks for your efforts and time :)

If you have any questions I can try to clearify any part of my bad explanation :p

Hi. Can you please add a config option to increase tool damage? I want people on my server to have a choice either to fall small trees manually or to fall large trees with double damage to the tool. Thanks!

https://www.curseforge.com/minecraft/mc-mods/falling-tree?comment=54

Describe the bug
Whenever hitting a tree with the speed setting at 1 or above, the game crashes.

To Reproduce
Steps to reproduce the behavior:

1. Start a new game, or join a game
2. Change the settings for speed to 1 or greater
3. Try to chop down a tree with any axe

Infos:

• Minecraft verson: 1.16.2
• Mod version: 2.2.2 (Fabric)
  I am also using other mods, but after trying again on a fresh install with only Falling Tree, it still crashed.

Crash Report with other mods: https://pastebin.com/SvJWqFAU
(just to be extra detailed) Crash Report without other mods: https://pastebin.com/3NKhRmZW

Describe the bug
A clear and concise description of what the bug is.
it doesnt work when i loaded it up on fabric 1.16.2 and i tried to redownload it but it still doesnt work
To Reproduce
Steps to reproduce the behavior:

1. fix it
2. help me

Infos:

• Minecraft verson: [e.g. 1.16.2]
• Mod version: [e.g. 1.0.0]?????

If you provide a crash report please include it in a readable way (like pastebin or gist for example).

See https://www.curseforge.com/minecraft/mc-mods/falling-tree?comment=408

Add option to only activate mod when sneaking

If trees are too close together the leaves won't break until you chop down all the trees. If possible, have some way of breaking the leaves in a radius around the logs removed.

Describe the bug
The Server crashes when trying to print a leaf block with the Create Schematicannon. The crash has been reported on the Create discord (i am a dev following up on those reports). The log says java.lang.ClassCastException: com.simibubi.create.content.schematics.SchematicWorld cannot be cast to net.minecraft.world.server.ServerWorld

To Reproduce
Steps to reproduce the behavior:

1. Install Falling Trees and Create in the same instance (1.15.2, presumably 1.14.4 too)
2. Make a schematic of a leaves block
3. Try to print that schematic in any world/server with a schematicannon
4. Crash

Infos:

• Minecraft verson: 1.15.2 (presumably 1.14.4 too, as those are the versions Create is available on)
• Mod version: FallingTree-1.15.2-2.3.0
• Crash log: https://pastebin.com/VucrppA1

Causing that issue is Create introducing a world type SchematicWorld that is remote (so the check !event.getWorld().isRemote() at https://github.com/RakSrinaNa/FallingTree/blob/1.15.2/src/main/java/fr/raksrinana/fallingtree/ForgeEventSubscriber.java#L107 returns true), yet the world is not an instance of ServerWorld.

I am working on a fix with an instanceof check, i will open a pull request when i am done.

Edit: typo

https://github.com/RakSrinaNa/FallingTree/wiki/Settings

1.16.4-2.8.1 version. It simply crashed on the loading screen. Error-Code: Java.lang.IllegalAccessError: no such constructor

crash report:
crash-2021-01-03_14.44.00-fml.txt

Infos:

• Minecraft verson: [1.16.4]
• Mod loader: [Forge]
• Mod version: [FallingTree-Forge-1.16.4-2.8.1]

Thank you for your work :D

https://github.com/RakSrinaNa/FallingTree/wiki/Behavior

Describe the bug
When Reverse sneaking is activated it cuts down trees while shifting and also while not shifting
To Reproduce
Steps to reproduce the behavior:

1. activate Reverse sneaking
2. cut down a tree while sneaking and while not

Infos:

• Minecraft verson: 1.16.4
• Mod loader: Forge
• Mod version: 2.8.1

Even with the mod install on both the client and server, i still get the weird block not breaking when mined and tree taking a full minute to fall issue, am i doing something wrong?

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Mods -> Falling Tree -> Config
2. Hover over various options.

Affected options are:
Reverse Sneaking- depends if the mouse is hovering over reverse it's fine but if it's over the sneaking part then it's unreadable
All of the Trees options except "Trunk Breaking"
All of the Tools Options.

Infos:

• Minecraft verson: 1.16.4
• Mod loader: Forge 35.1.4
• Mod version: 2.8.0

Describe the bug
I've noticed, that in 1.15.2, if break_leaves is set to true, whenever you manually break a leaf block, it causes any other leaf blocks touching it to tick over and over. While, this behavior isn't noticeable in vanilla, it can break other mods. Nature's Aura, or Fruit Trees, for example, where waiting for leaf blocks to tick for something to happen, is extremely accelerated by your mod.

Detailed Examples:
In Nature's Aura, you need to turn a leaf block golden, and wait for a while, so it can slowly spread to surrounding leaf blocks, eventually converting all the leaves that are touching. However, if you break a leaf block manually, it causes the surrounding ones to immediately convert, making it extremely easy to get the golden leaves.

In Fruit Trees, leaf blocks produce fruit inside them over time and eventually drop it as an item, but if you break a leaf block, the surrounding ones will immediately start producing and dropping fruit at an alarming rate, over and over.

Conclusion:
Setting break_leaves to false, stops this behavior. So, I'm currently forced to use this mod for only the tree chopping, and a separate mod for the leaves (fast leaf decay) which doesn't cause this to happen.

To Reproduce
Steps to reproduce the behavior:

1. Enable leaf breaking from this mod.
2. Install another mod that relies on leaf blocks changing over time.
3. Manually break a leaf block touching another leaf block where ticking is visible.

My brother and I were looking for a mod like this for ages now and we finally found one until we got on and saw it didn't work. We checked all the settings but nothing worked. If we had to rate it out of stars I would give it a 1 out of 5 because the false advertising was on point it made you believe it was going to work.

Hello! I downloaded this mod for my server, and I have too many type of axes and too many types of wood. I was wondering if it is possible to make all axes usable on all types of wood. I have seen the config file, but it looks to hard to modify, and I am not an expert on config. Hope you can help. Thanks!!

Describe the bug
When I attempt to chop down a tree that is too big, the following message is displayed in chat:

chat.fallingtree.tree_too_big

To Reproduce
Steps to reproduce the behavior:

1. chop down a large tree

Infos:

• Minecraft verson: [e.g. 1.16.5]
• Mod loader: [Fabric]
• Mod version: [FallingTree-Fabric-1.16.5-2.10.2]

If you provide a crash report please include it in a readable way (like pastebin or gist for example).

Describe the bug
Growing an ancient tree from natures aura with
break_leaves = true
It causes all leaves to break when the tree grows.
To Reproduce
Steps to reproduce the behavior:

1. plant ancient tree and use bonemeal to grow it

Infos:

• Minecraft verson: 1.15.2
• Mod version: FallingTree-1.15.2-2.0.3+19

Curse comment

Describe the bug

• The newest update crashes the server.

To Reproduce
Steps to reproduce the behavior:

1. Load mod on server.
2. Crash.

Infos:

• Minecraft v1.16.4
• Mod loader: Forge v31.1.28
• Mod version: v2.8.2

Crash Report

https://github.com/RakSrinaNa/FallingTree/wiki/Behavior

https://www.curseforge.com/minecraft/mc-mods/falling-tree#c94

Describe the bug
When your mod is installed with some other mods I have (Biomes O' Plenty and Oh The Biomes You'll Go) it causes some pretty annoying issues. When creating a world, everything works perfectly fine...but the second I close the world and attempt to join back, it freezes the entire game at 100% to the point where I can only close it with Task Manager. I have been testing mods for 2 weeks now trying to figure out which mod in my pack was causing the issue, and I finally pin-pointed it to your mod. There are no errors in the console, so I don't know how the issue is happening.

To Reproduce
Steps to reproduce the behavior:

1. Create a World
2. Exit world and attempt to join same world or another

Infos:

• Minecraft verson: 1.16.1
• Mod version: FallingTree-1.16.1-2.2.1

A clear and concise description of what you want to happen.

Describe the bug
When breaking a tree, if the axe you are using breaks, sometimes it will only partially destroy the tree.

Infos:

• Minecraft verson: 1.16.5
• Mod loader: Fabric

A clear and concise description of what you want to happen.
I got other mods installed that gives me more axe . How to I add it to the mod

is it possible to make certain tools do the shift down method while have other tools do the instantaneous method (ie a diamond or netherite axe?)

The mod works like a charm, but every time I cut down a tree or wood, the axe gets duplicated by the number of blocks I cut down and stacks. I have now hundreds of axes in my inventory.

To Reproduce
Steps to reproduce the behavior:

1. Cut down a tree or wood
2. Watch your axe multiply buy the number of blocks you just cut down

Infos:

• Minecraft verson: release fabric loader 0.93 build.207 1.16.1
• Mod version: FallingTree-Fabric-1.16.1-2.3.1