Git Product home page Git Product logo

pages-plugin's People

Contributors

acasar avatar alekseybobkov avatar alxy avatar bennothommo avatar blazorazem avatar cracki avatar daftspunk avatar felixinx avatar gabsource avatar gergo85 avatar gpasztor87 avatar jan-vince avatar jimcottrell avatar luketowers avatar mahony0 avatar marininicola avatar merodeador avatar mjauvin avatar octoberapp avatar patrickward avatar petehalverson avatar pvullioud avatar rike-cz avatar samgeorges avatar theservat avatar tobias-kuendig avatar tomaszstrojny avatar vbarinov avatar vojtasvoboda avatar vshepel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

pages-plugin's Issues

Incomplete documentation on Syntax fields

Syntax fields are awesome! But I can't figure out how to use the repeater type. There is only limited documentation present in the read me and documentation of the plugin itself.

I can get the repeater to show, but I can't get any fields in the repeater.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Snippet from partial is not saved

Hi guys,

I'm unable to save my freshly created snippet from partial. It says it was saved but my snippet does not appears in the snippets list from the pages backend. :/

Edit :

Ok it works if i manually add the minimimum required viewBag part in my partial snippet file, like this :

[viewBag]
staticPageSnippetCode = "services"
staticPageSnippetName = "Services"

properties input wrongly escaped

Hi,

if I make a property field type "text" and enter there html-tags like

<br />

the following problems will occur:

  1. if I enter
<br />

pages plugin will convert it to

<br ></figure>

after saving!
2. if I enter

<br>

and use the twig raw-filter in fronted output, it will be still written as

<br>

in the text... Also the twig filter nl2br doesn't work.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Bug] Preview URL not correct

When clicking preview the URL is incorrect i.e

My October URL is http://localhost:8888/october, page URL is /sample-page so the preview link should be

http://localhost:8888/october/sample-page

but it goes to

http://localhost:8888/sample-page

Again, if this is on the BETA todo, just close :)

Issue inserting link in pages using CMS build 292 and pages 1.16

Get the following error when inserting links

exception 'October\Rain\Exception\SystemException' with message 'A widget with class name 'formPage764acf950e353a03ff27931dfcf61dcd55e86b56382ecMarkup' has not been bound to the controller' in /var/www/html/modules/backend/classes/Controller.php:512
Stack trace:
#0 /var/www/html/modules/backend/classes/Controller.php(423): Backend\Classes\Controller->runAjaxHandler('formPage764acf9...')
#1 /var/www/html/modules/backend/classes/Controller.php(233): Backend\Classes\Controller->execAjaxHandlers()
#2 /var/www/html/modules/backend/classes/BackendController.php(95): Backend\Classes\Controller->run('index', Array)
#3 [internal function]: Backend\Classes\BackendController->run('rainlab/pages')
#4 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Controller.php(246): call_user_func_array(Array, Array)
#5 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(162): Illuminate\Routing\Controller->callAction('run', Array)
#6 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(107): Illuminate\Routing\ControllerDispatcher->call(Object(Backend\Classes\BackendController), Object(Illuminate\Routing\Route), 'run')
#7 [internal function]: Illuminate\Routing\ControllerDispatcher->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#8 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(141): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#9 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#10 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(101): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#11 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(108): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#12 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(67): Illuminate\Routing\ControllerDispatcher->callWithinStack(Object(Backend\Classes\BackendController), Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request), 'run')
#13 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Route.php(204): Illuminate\Routing\ControllerDispatcher->dispatch(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request), 'Backend\Classes...', 'run')
#14 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Route.php(134): Illuminate\Routing\Route->runWithCustomDispatcher(Object(Illuminate\Http\Request))
#15 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(701): Illuminate\Routing\Route->run(Object(Illuminate\Http\Request))
#16 [internal function]: Illuminate\Routing\Router->Illuminate\Routing{closure}(Object(Illuminate\Http\Request))
#17 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(141): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#18 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#19 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(101): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#20 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(703): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#21 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(670): Illuminate\Routing\Router->runRouteWithinStack(Object(Illuminate\Routing\Route), Object(Illuminate\Http\Request))
#22 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(628): Illuminate\Routing\Router->dispatchToRoute(Object(Illuminate\Http\Request))
#23 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(214): Illuminate\Routing\Router->dispatch(Object(Illuminate\Http\Request))
#24 [internal function]: Illuminate\Foundation\Http\Kernel->Illuminate\Foundation\Http{closure}(Object(Illuminate\Http\Request))
#25 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(141): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#26 /var/www/html/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(55): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#27 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(125): Illuminate\View\Middleware\ShareErrorsFromSession->handle(Object(Illuminate\Http\Request), Object(Closure))
#28 /var/www/html/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(61): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#29 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(125): Illuminate\Session\Middleware\StartSession->handle(Object(Illuminate\Http\Request), Object(Closure))
#30 /var/www/html/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php(36): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#31 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(125): Illuminate\Cookie\Middleware\AddQueuedCookiesToResponse->handle(Object(Illuminate\Http\Request), Object(Closure))
#32 /var/www/html/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(40): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#33 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(125): Illuminate\Cookie\Middleware\EncryptCookies->handle(Object(Illuminate\Http\Request), Object(Closure))
#34 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/CheckForMaintenanceMode.php(42): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#35 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(125): Illuminate\Foundation\Http\Middleware\CheckForMaintenanceMode->handle(Object(Illuminate\Http\Request), Object(Closure))
#36 [internal function]: Illuminate\Pipeline\Pipeline->Illuminate\Pipeline{closure}(Object(Illuminate\Http\Request))
#37 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(101): call_user_func(Object(Closure), Object(Illuminate\Http\Request))
#38 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(115): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#39 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(84): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
#40 /var/www/html/index.php(44): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
#41 {main}

{% if placeholder(name') %} -> no more editable

If I wrap a placeholder with an if-clause, like:
{% placeholder link title="Link" type="html" %}{% placeholder link title="Link" type="html" %}{% endif %}

The placeholder will not appear in the static pages editor as editable content.... Why this??? How can I now fill-in something to the placeholder?

Accessing placeholders within static menu's

I have a need to allow clients to set an icon on a static page menu item, and without an image/select placeholder I was going to use the type of "text" for the time being. That being said, I am not sure if there is a way to access that information when outputting the menu item.

Something along the lines of "item.extra.placeholdername" would be awesome. Is it already possible?

Thanks guys.
Jon

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

content field keeps getting filled with paragraph

I'm having issues with default content in placeholders, when I filled my placeholder but I want to get the default value back, it won't show. Because there is still a paragraph tag in the "put".

You can reproduce this by:

  1. Making a static page which has a placeholder with default content
  2. Fill the placeholder and save the page
  3. Remove all contents from the placeholder (in the static page plugin)
  4. Look at the page and there will be no default value because of the paragraph tag (see example below)
{% put placeholder1 %}
<p><br></p>
{% endput %}

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Open menu item in new tab

Is there a reason there is no possibility to add menu items (e.g. of type URL) with the option to open in a new tab? For example an external link to another website.

Error after upgrading to v.1.0.7

Just upgraded my Static Pages instance to version 1.0.7.
When I click Pages in the back-end menu bar, the following error occurs:

Undefined variable: result
[path_to]\october\plugins\rainlab\pages\classes\SnippetManager.php line 161

"Hide In Navigation" on Page doesn't hide it from Menu

When creating static pages, there are some I need to hide just because there's no content on the page. On the page there is a checkbox labeled "Hide in navigation - Check this box to hide this page from automatically generated menus and breadcrumbs."

Thing is, I've checked this on several pages and they still display in the menu which I've called using the default method as outlined in the documentation.

I've checked the website when not logged in and the pages are still displayed in the menu.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Bug?] Contents not saving

Hi, when I edit an existing content or create a new content, then I click save, the changes aren't saved

Problem with Menu

There is a problem after clicking add button in menu addition. Maybe problem with escaping

screen shot 2015-03-07 at 20 56 47

[Feature Request] - Placeholders with type image/select

Love the idea of placeholders in the system, and I am sure you are planning to add more types but 2 types I am really in need of at the moment is the ability to set an image placeholder and a select so I am able to set icons for pages etc.

1 way that MODX did selects was to have an input of "name==value||name==value" for the multiple options. Just a thought.

Build 261

Not sure how to fix this but when I updated to build 261, the static pages plugin is no longer working. any pages created remain blank. I notice this happening on sites that I created in beta and updated to to rc server logs show.

[Mon Jun 08 17:07:23.280599 2015] [core:notice] [pid 1168] AH00051: child pid 1998 exit signal Segmentation fault (11), possible coredump in /etc/apache2

Issue with PageList class

I was attempting to use the findByUrl method in the PageList class and it squawked about RouterHelper not being loaded.

Class 'RainLab\Pages\Classes\RouterHelper' not found

When I resolve that dependency in PageList.php I get...

Class 'RainLab\Pages\Classes\Config' not found

When I resolve that, I get...

Call to undefined method RainLab\Pages\Classes\PageList::getRouterObject()

With a code dump of: (emphasis on $router = $this->getRouterObject(); )

/*
             * Find the page by URL and cache the route
             */

            if (!$fileName) {
               $router = $this->getRouterObject();

                if ($router->match($url)) {
                    $this->parameters = $router->getParameters();

                    $fileName = $router->matchedRoute();

I'm guessing this is a fragment from laravel 4, and I can get the data I want by other means, but I figured I'd post this here. :)

No longer able to add snippets to the editor

With the latest version of the Pages plugin (v1.1.3) and build 277 of OctoberCMS, it's no longer possible to insert snippets from the menu in the backend. Attempting to do so shows an alert saying "Snippets can only be added to page Content or HTML placeholders".

image

Existing snippets still work and it is possible to fudge a new snippet by inserting HTML in the code so I think it's just a validation bug upon insertion.

I haven't had time to look into this further but I assume it will be an easy fix. I've confirmed this bug exists in a couple of different installs.

Thanks!

[Bug] Content source not appearing correctly

HI guys,

Don't like being the first to find an issue :( I understand it's still in BETA, so if it's not a problem, just close.

Anyway, just a small issue where the page source isn't showing correctly:

sample-page-1

sample-page-2

[Bug?] Plain Text placeholder

Hi guys, firstly, great update with the content blocks, really taking shape now :)

Just noticed a small bug when trying things out - if I put a type="text" on a placeholder, I still get the WYSIWYG editor for that content.

Missing images in the editor after saving

The new media manager looks fantastic - great job guys! I'm excited to finally have the ability to easily add images to static pages.

When I insert an image, save the page and then close the editor, everything seems fine until I go back to edit the page - all traces of the images are gone when Redactor loads. It's almost as if it strips images on load. I have the latest version of the plugin (1.0.12) and the latest build of October (247).

The image tag is saved to the HTML but the editor doesn't show it upon loading the file.

Also a quick side question: are there plans to add an edit feature for inserted images? Being able to set the alt/title plus a caption would be very helpful.

Thanks!

Unable to sort newly created menu items

In reference to this commit - octobercms/october@20fb98d

The update function was commented out in the file modules\backend\assets\js\october.treeview.js

// It seems the method is not used anymore as we re-create the control
// instead of updating it. Remove later if nothing weird is noticed. 
// -ab Apr 26 2015
//
// TreeView.prototype.update = function() {
//     this.$allItems = $('li', this.$el)
//     this.createItemControls()
//     this.initSortable()

//     var dataId = this.$el.data('oc.active-item')
//     if (dataId !== undefined)
//         this.markActive(dataId)
// }

The Static Pages plugin makes 3 references to .treeView('update') and there is a noticeable bug when creating a new menu item.

This is likely caused by the onCreateItem function in plugins\rainlab\pages\formwidgets\menuitems\assets\js\menu-items-editor.js which makes reference to:

this.$treeView.treeView('update')

How to replicate

  1. Open the back-end, navigate to Pages in the menu, select Menus from the sub-menu
  2. Create a new menu / Open an exisiting menu
  3. Add an item to the menu
  4. Save the menu
  5. Refresh the page
  6. Open the menu previously created
  7. Notice the menu item can be sorted (the drag handle appears next to the delete button)
  8. Add another item to the menu
  9. Notice the new menu item does not have a drag handle

Snippets mess up html

Using snippets to add inline images doesn't work. The snippet strips the surrounding <p> or places it in new <p>. If desired effect is typed in the HTML mode, same behaviour occurs.

Is there any other way to add images to the Rich editor?

screen shot 2015-04-09 at 11 36 32
screen shot 2015-04-09 at 11 43 09

Menu Item Deleting not working

Hi, on my October installation,
When I go in the Pages section, then in the left Menus section,
In a menu, the Trash button (for deleting a menu item) doesn't work and I don't understand why.
I got the same problem on my website on production. Any idea ?
Thank you very much.

Request: Extended partial properties

Hi, the properties in the partials are quite useful.

But I am heavily missing some more features for the backend:

  • A textarea/string type instead only a textfield/string.
  • A pagelink type instead a plain string url. So that the customer simply can select a target page in a select box instead entering a raw url...

How could I add these by myself? Thx.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Uploading images

Can't add any images (only shows placeholder image)
I can edit the html but my client doesn't understand :(

Besides that it is a great plugin!!

Content created/edited with CKEditor will not be saved.

The following JavaScript error is returned when trying to save content made with CKEditor enabled:

Uncaught TypeError: Cannot read property '$textarea' of undefined.

CKEditor probably uses another name for it's textarea.

Placeholder tabs no longer showing in the editor

Hi Alexey and Samuel,

First of all, thanks for all your amazing work on October CMS :)

Now to the problem - the placeholder content tabs are no longer displaying when editing static pages. I just did a fresh install of the latest build (225) and the only plugin I added was Static Pages (v1.0.10).

I have an older install of October elsewhere running build 211 and v1.0.8 and it is working as expected there so this problem has occurred sometime since then. Could you please take a look?

My setup is Laravel Homestead / Vagrant on OS X 10.9.4.

Many thanks,

Stephen

[Bug?] CMS page dropdown

When selecting Blog Category or All blog categories from the TYPE dropdown, the CMS Page dropdown is empty - is this correct?

untitled

untitled

CSS is transformed to default in editor

Hi,

This is a bug, that is not pleasent. For example, I want to add a Bootstrap Jumbotron in my home page. I go to the editor, and go to code, add my Jumbotron, but after, I can't save my code just like that, I have to return to the WYSIWYG editor, and it transform my code, and the Jumbotron <div> go away. The only way to have my Jumbotron, is to go to /themes/MYTHEME/content/static-pages/PAGE.htm and edit it.

I will work on it and make a future pull request.

Thanks

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.